From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63202C00140 for ; Tue, 2 Aug 2022 07:03:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232948AbiHBHDC (ORCPT ); Tue, 2 Aug 2022 03:03:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234754AbiHBHC7 (ORCPT ); Tue, 2 Aug 2022 03:02:59 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8B9D22BCB for ; Tue, 2 Aug 2022 00:02:57 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id a13so14619726ljr.11 for ; Tue, 02 Aug 2022 00:02:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=uPIE0DvOSHMXit1jmkLwyZQysttuDQSfP5UeIHQUUqI=; b=IXx1qRJE6nDUs27fpGtUJ2VR2du0AzgKQv4ljCBjX5cpfOd2vdBaQ2bYHwmkS8iIt0 rnXUIBwZ6gdVEBxvR0LkqxXH2LZ+6u1CaQYvB+Pc2+hLdE3SUJmEqu8TpM7BG+r9hD+0 W7uBKHOs3bFovvY1jYrkrgQbClKIU4p5NN2Odkz7LXcZCQ1uoS0RmhVLnslPNXWQs3pN 7xLl9CUAaFTl2N1kwbBKX8+02GHDSoBG7JHSOvbLsSukiPhVKZ/Qn+149On5ymFk1ZMN IIU8DJH1V3dogD1q/grozvDT3IBcI56G4qnzCbY3Cwv3NAh9FIjIEuzfoMui5aL6dngk MpAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=uPIE0DvOSHMXit1jmkLwyZQysttuDQSfP5UeIHQUUqI=; b=cdtZYUjIMIP+BI3xVvLlCq/0oV9AIQgTTqK+Br/NSh3HFbc6dOW5ll2XBwYstxO8zg 0WB5czy30rCXWg5tp1uUNJnJ0sMDU5709wIxrk+XvAPOwKAyX7FQS0Hi/YcTGX68+Q3z Yr/m31L18ih2us/IL6q3Kz58rtUk5AzHMPaOd+VHEyB/9VN2DGLgfX0zFNlrmGc6dOQP b0B5TLhTVQW1zRaYbWsFo+UYrOyGZUDZpU166VAwjuXd9fstIv7hCBnq8vGnDncj1DLD lJfflDKnOGytZMvrkhQ4td/k0QvDtP1QcQa72svywCeF9kLvvtnBd28SdpJKHUFffvLy KKUQ== X-Gm-Message-State: ACgBeo0I2Ck27/suWWmJ75HYxHZkqGJzwsZhu/2pYQ2dN23XH/1xMpB8 Vr9BzIwapzoFNXie4VC2Iun3fQ== X-Google-Smtp-Source: AA6agR5dt356YyFOcD1+pyoDhGjAY8tfrUgU4K+3aRTPoYYfoZxGFDq8wAjVyquuNMnOReurxMVYSg== X-Received: by 2002:a05:651c:335:b0:25e:4ac0:86e2 with SMTP id b21-20020a05651c033500b0025e4ac086e2mr3326877ljp.427.1659423775966; Tue, 02 Aug 2022 00:02:55 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id b22-20020a05651c033600b0025e4cdd9771sm716904ljp.117.2022.08.02.00.02.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Aug 2022 00:02:55 -0700 (PDT) Message-ID: Date: Tue, 2 Aug 2022 10:02:54 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 3/5] clk: qcom: gpucc-sc7280: Add cx collapse reset support Content-Language: en-GB To: Akhil P Oommen , freedreno , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Rob Clark , Bjorn Andersson , Stephen Boyd Cc: Douglas Anderson , Andy Gross , Konrad Dybcio , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <1659172664-10345-1-git-send-email-quic_akhilpo@quicinc.com> <20220730144713.3.I5e64ff4b77bb9079eb2edeea8a02585c9e76778f@changeid> From: Dmitry Baryshkov In-Reply-To: <20220730144713.3.I5e64ff4b77bb9079eb2edeea8a02585c9e76778f@changeid> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 30/07/2022 12:17, Akhil P Oommen wrote: > Allow a consumer driver to poll for cx gdsc collapse through Reset > framework. > > Signed-off-by: Akhil P Oommen > --- > > drivers/clk/qcom/gpucc-sc7280.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/clk/qcom/gpucc-sc7280.c b/drivers/clk/qcom/gpucc-sc7280.c > index 9a832f2..f5df51d 100644 > --- a/drivers/clk/qcom/gpucc-sc7280.c > +++ b/drivers/clk/qcom/gpucc-sc7280.c > @@ -433,12 +433,18 @@ static const struct regmap_config gpu_cc_sc7280_regmap_config = { > .fast_io = true, > }; > > +static const struct qcom_reset_map gpucc_sc7280_resets[] = { > + [GPU_CX_COLLAPSE] = { .op = gdsc_wait_for_collapse, .priv = &cx_gdsc }, This will break bisectability. Please swap this one and the patch 4. > +}; > + > static const struct qcom_cc_desc gpu_cc_sc7280_desc = { > .config = &gpu_cc_sc7280_regmap_config, > .clks = gpu_cc_sc7280_clocks, > .num_clks = ARRAY_SIZE(gpu_cc_sc7280_clocks), > .gdscs = gpu_cc_sc7180_gdscs, > .num_gdscs = ARRAY_SIZE(gpu_cc_sc7180_gdscs), > + .resets = gpucc_sc7280_resets, > + .num_resets = ARRAY_SIZE(gpucc_sc7280_resets), > }; > > static const struct of_device_id gpu_cc_sc7280_match_table[] = { -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A3E2C00140 for ; Tue, 2 Aug 2022 07:03:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5669E2A3E9; Tue, 2 Aug 2022 07:03:10 +0000 (UTC) Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by gabe.freedesktop.org (Postfix) with ESMTPS id C4BF92A354 for ; Tue, 2 Aug 2022 07:02:57 +0000 (UTC) Received: by mail-lj1-x22e.google.com with SMTP id m9so14634571ljp.9 for ; Tue, 02 Aug 2022 00:02:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=uPIE0DvOSHMXit1jmkLwyZQysttuDQSfP5UeIHQUUqI=; b=IXx1qRJE6nDUs27fpGtUJ2VR2du0AzgKQv4ljCBjX5cpfOd2vdBaQ2bYHwmkS8iIt0 rnXUIBwZ6gdVEBxvR0LkqxXH2LZ+6u1CaQYvB+Pc2+hLdE3SUJmEqu8TpM7BG+r9hD+0 W7uBKHOs3bFovvY1jYrkrgQbClKIU4p5NN2Odkz7LXcZCQ1uoS0RmhVLnslPNXWQs3pN 7xLl9CUAaFTl2N1kwbBKX8+02GHDSoBG7JHSOvbLsSukiPhVKZ/Qn+149On5ymFk1ZMN IIU8DJH1V3dogD1q/grozvDT3IBcI56G4qnzCbY3Cwv3NAh9FIjIEuzfoMui5aL6dngk MpAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=uPIE0DvOSHMXit1jmkLwyZQysttuDQSfP5UeIHQUUqI=; b=AvtFKdMZaHAwXbwKluhMab+w1krLXIoY8oBh80IoNhQ37K7YmEOtaQJ8bNSz1Bk30P byHrh84Jd/HtncGloWTfnhlDNc+Jmbgs/2oK56ghHLKjg5ttKzWFevz0xGmUxTCK7Ks1 9RCF9zTVK5Zq3tMj7M+HFIIvo6W2R1Wepou8CqtqWA8t89S/5LxeM7OE4j6UK6weVTqK GhZwwREjtlL8CloLZF3qhvX0NaGoFTmqydeKs06AzuiuE8d53HGk1/PLvvtmWIMOOmqD m9mNRJWtjoYSpxVlNE/Nct7rzWuONS5yDYzR+wuUw/cEEoCSmUY4F50QDbDX/UyXRtDX 0N3Q== X-Gm-Message-State: ACgBeo1DQIBELbBrj/xyN6n7D1nYXGfOZMdx8z++iL1lVynbSoDSGETb CUd8xQmFTVHyuo8A+70tXhoCAA== X-Google-Smtp-Source: AA6agR5dt356YyFOcD1+pyoDhGjAY8tfrUgU4K+3aRTPoYYfoZxGFDq8wAjVyquuNMnOReurxMVYSg== X-Received: by 2002:a05:651c:335:b0:25e:4ac0:86e2 with SMTP id b21-20020a05651c033500b0025e4ac086e2mr3326877ljp.427.1659423775966; Tue, 02 Aug 2022 00:02:55 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id b22-20020a05651c033600b0025e4cdd9771sm716904ljp.117.2022.08.02.00.02.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Aug 2022 00:02:55 -0700 (PDT) Message-ID: Date: Tue, 2 Aug 2022 10:02:54 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 3/5] clk: qcom: gpucc-sc7280: Add cx collapse reset support Content-Language: en-GB To: Akhil P Oommen , freedreno , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Rob Clark , Bjorn Andersson , Stephen Boyd References: <1659172664-10345-1-git-send-email-quic_akhilpo@quicinc.com> <20220730144713.3.I5e64ff4b77bb9079eb2edeea8a02585c9e76778f@changeid> From: Dmitry Baryshkov In-Reply-To: <20220730144713.3.I5e64ff4b77bb9079eb2edeea8a02585c9e76778f@changeid> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Boyd , Michael Turquette , Konrad Dybcio , Douglas Anderson , linux-kernel@vger.kernel.org, Andy Gross , linux-clk@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 30/07/2022 12:17, Akhil P Oommen wrote: > Allow a consumer driver to poll for cx gdsc collapse through Reset > framework. > > Signed-off-by: Akhil P Oommen > --- > > drivers/clk/qcom/gpucc-sc7280.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/clk/qcom/gpucc-sc7280.c b/drivers/clk/qcom/gpucc-sc7280.c > index 9a832f2..f5df51d 100644 > --- a/drivers/clk/qcom/gpucc-sc7280.c > +++ b/drivers/clk/qcom/gpucc-sc7280.c > @@ -433,12 +433,18 @@ static const struct regmap_config gpu_cc_sc7280_regmap_config = { > .fast_io = true, > }; > > +static const struct qcom_reset_map gpucc_sc7280_resets[] = { > + [GPU_CX_COLLAPSE] = { .op = gdsc_wait_for_collapse, .priv = &cx_gdsc }, This will break bisectability. Please swap this one and the patch 4. > +}; > + > static const struct qcom_cc_desc gpu_cc_sc7280_desc = { > .config = &gpu_cc_sc7280_regmap_config, > .clks = gpu_cc_sc7280_clocks, > .num_clks = ARRAY_SIZE(gpu_cc_sc7280_clocks), > .gdscs = gpu_cc_sc7180_gdscs, > .num_gdscs = ARRAY_SIZE(gpu_cc_sc7180_gdscs), > + .resets = gpucc_sc7280_resets, > + .num_resets = ARRAY_SIZE(gpucc_sc7280_resets), > }; > > static const struct of_device_id gpu_cc_sc7280_match_table[] = { -- With best wishes Dmitry