From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED1E6D3399B for ; Mon, 28 Oct 2024 16:12:39 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.826813.1241219 (Exim 4.92) (envelope-from ) id 1t5SM3-0007qv-4h; Mon, 28 Oct 2024 16:12:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 826813.1241219; Mon, 28 Oct 2024 16:12:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1t5SM3-0007qo-18; Mon, 28 Oct 2024 16:12:31 +0000 Received: by outflank-mailman (input) for mailman id 826813; Mon, 28 Oct 2024 16:12:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1t5SM2-0007qg-1X for xen-devel@lists.xenproject.org; Mon, 28 Oct 2024 16:12:30 +0000 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [2a00:1450:4864:20::12b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6ddc8629-9547-11ef-a0c2-8be0dac302b0; Mon, 28 Oct 2024 17:12:29 +0100 (CET) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-539f0f9ee49so4739662e87.1 for ; Mon, 28 Oct 2024 09:12:29 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4319360eb09sm114249035e9.48.2024.10.28.09.12.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Oct 2024 09:12:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ddc8629-9547-11ef-a0c2-8be0dac302b0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1730131948; x=1730736748; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=gLucz75e0eeHPfhiDBLyzySJzHHSgVtc0infk9O0FMw=; b=gcd9Bti/9AhiBHpOjNeHAx2TwQMKG3P8wtYZOIQBrhd553Cjzc3k1IehIzPeFtXh0e qfNtmd7Pd/vBPou6aWSQLgkel+uzjHf5insp5oV5AgUCkTh+oeMN5z5wGVEopWuX62yq 0xbJkYhlCD19dH83jepduV4lPKq8RsJj50v6TTM0b2R5gmUSUMitPhtUM7VETpS62Sbr cekXuPfQksmzcORF66RQreaawSdEH8uqnJ2l3EohBPO2Pw2umTdFDpOc8MK5yQpL4F1P eDjxbmNKL68L6Ob3zDzl+bGwrt/gKlg67NtZJnhOUYfx3V7hTO4qhIf8SxbPnNVRG5r3 RaFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730131948; x=1730736748; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gLucz75e0eeHPfhiDBLyzySJzHHSgVtc0infk9O0FMw=; b=uMyaQrlgPvgachwc37vzsMii3uq47V3oKwfCjekaEahefZVM6/EAH6P9W67FhXzytV 9N+HPWM5pvhzPO3qeUXD+AJvZi46lxHoDvQUDWbRTdAcXPVFd+VJwc42CNYSVw/rSh/e /PzvNCfJJwASxfI3Dy4E3ELWlX04SCxFxTHr17Zri23JnIJCBRq9TM+KrmofrbpDrJnp 42q/LzpqctQUEhMxzrzreCWNZJ3kY0uXkQX+hmGSGFzZa35Geub3Puf5AxE2kdiGO2Fi UTfFEWLLAPiK2KFKFGYb5tweRTRAZoRsWHhR+zxs8LfZ7GFMWmuuO3oRW4FNeCgHpoJ7 HjBQ== X-Forwarded-Encrypted: i=1; AJvYcCW4Df4D4qS+fWq1zLhLzqgoz+t+x++bkC+sObs2mBGzcKRnxikLiEWXWWIvRoBlDb+uTKOnPgHxpcw=@lists.xenproject.org X-Gm-Message-State: AOJu0YyqUDsmF/aODhjgmxznOsjUp3L8c0jmpWlZElAjkOXpsS9CzqHG VnwrYIPPMpX18NCF8XpGoBauZ7R/AsiTOcPJi8aelLwLJOJgxMHwdt/siF/zJQ== X-Google-Smtp-Source: AGHT+IEKA3GjAwtYgMrI5/cFhQoXIeg7UIHhMKlMwBDLvlgrh/j3ZlxruT0m3AXswLRZqerBEvGCCA== X-Received: by 2002:a05:6512:2385:b0:539:e14b:309c with SMTP id 2adb3069b0e04-53b348cb1c6mr3219430e87.19.1730131948475; Mon, 28 Oct 2024 09:12:28 -0700 (PDT) Message-ID: Date: Mon, 28 Oct 2024 17:12:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] earlycpio: constify find_cpio_data()'s "data" parameter To: Andrew Cooper Cc: Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" References: <764c0116-88ed-48af-8e53-f2a0f6e850a3@citrix.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <764c0116-88ed-48af-8e53-f2a0f6e850a3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 28.10.2024 17:07, Andrew Cooper wrote: > On 28/10/2024 4:03 pm, Jan Beulich wrote: >> As with 9cbf61445cda ("xen/earlycpio: Drop nextoff parameter"): While >> this is imported from Linux, the parameter not being pointer-to-const is >> dubious in the first place and we're not plausibly going to gain a write >> through it. >> >> Signed-off-by: Jan Beulich > > You haven't tried compiling this, have you? Of course I have. Is there any subtlety with compiler versions? Or what else am I missing? Jan