From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C94351E4B2 for ; Wed, 11 Sep 2024 16:13:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726071226; cv=none; b=Jx1mNKf+rQWJdCjTCVkiuQK7+DafZ7MdHdjk9KbnnT6SinHw4gZweowD69enW6eeqsSphh6O3bjPJEUBRSQKWn+8LyAtGkBrRIvqD3fjc/R/056nHV+GW8CVHjuufZ3JEXZM5r+85ufIM1K3DstxbUN3Luc8cU41Ypc715rkrrU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726071226; c=relaxed/simple; bh=EGcPAzrTApZauvg3WWEXaOaLit6hcI8xIY4mqgyeCXw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nO2vJ2YmaV5DBeLg1KNPplBisL7oUKxX/009ZsA/1HsaXOVnPkILnHUDgw1IVUS8hQzSnXrz7k9F1CCZyhWEraWGTRHZZGOS7y23e75eG9LBDdvrUoSQ3CQjz9AizLvy6RTUIFmZ4g7cN1wA8BsL4L/BTfHg1P9T/YyG6FiVKLA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Kkl/tywz; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Kkl/tywz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726071223; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eseXdDpfz/U6BsWSABfXPfB77+/2Dy1yLZdnZJ55/wc=; b=Kkl/tywz8FZ6peJzEl5Y9dynZCxypzBwqGf4QVJIIGPYBWsTfQ4pfa5t9uxrmDgOn+2Hbt ievQHH8uRD+UVgLXM7sOxOC9H+8OeCZx8S8j0KtaW6Gb1QbqU437lhg9pivfUEBwpvqXX8 f4/WxoVGulszmFjQOcqeTRKnSH7LAmQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-542-dQazZsJRNOGVgOpVgUfa_A-1; Wed, 11 Sep 2024 12:13:42 -0400 X-MC-Unique: dQazZsJRNOGVgOpVgUfa_A-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-377a26a5684so17081f8f.0 for ; Wed, 11 Sep 2024 09:13:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726071221; x=1726676021; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eseXdDpfz/U6BsWSABfXPfB77+/2Dy1yLZdnZJ55/wc=; b=PiIyxzunwW7ET9w+2OCb6yVVAyIz1UQwiay9/pkT1GKtQY70acaM67shGkmcbpnGmt IKVq0rFPPHW3/Jm6sms+Y+sQiqP0LASyMVAB6EtnLE9E8tirM167O1fEmMxPhJWipDdg cdh4pHGk7pBqAlmGqxZZ7PmoqS/E7+djUW0ofkNdesE+jvj2wUk8MHrZzxhq0W5IT+4g iXGxgnqDGmQCgwTb5zyjreS9kVTZLdrIsA3BHfxHuoD+i0/zaKZnjnM+zD4g1X0gcZ9c 9dzKTAhcbWEeKg9XOWzeWjxmnJ221nWrWFhQuqJ7zSINZIQZXi4PMeeWFP5synAYEMJX Rw7g== X-Forwarded-Encrypted: i=1; AJvYcCVc4GwlvdKp3Gonu3cQmbuEB0jcmUCYsVUgtL94latlhg0SIrOfIbmCGdpk9rKxleo+2A0=@vger.kernel.org X-Gm-Message-State: AOJu0YwxZsx+NGmorDJQgO7JOf2oEKhwbNiAFckSwsu9K55Lhx/ek7Y2 J0Ie3HLJYuAsV6V1OUAP3yDbElqsXdoa3IMfsx25AaJljc61saZ/umfDbHbhB33xxHiyXShDhni PgcCve06ZRINIAkLtndQXcXI3HwzzQtAy+9oFOXqc9U7Y+LYvkg== X-Received: by 2002:adf:8b9c:0:b0:375:f59f:221 with SMTP id ffacd0b85a97d-378895c70bemr10513503f8f.14.1726071220939; Wed, 11 Sep 2024 09:13:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFmZNEciv+KogJ0ibsMr+MURRXrV9Wkmn6DSsHwshjGKum8j5Ar+qjKntUdlqLO2jT78DuIVg== X-Received: by 2002:adf:8b9c:0:b0:375:f59f:221 with SMTP id ffacd0b85a97d-378895c70bemr10513446f8f.14.1726071220269; Wed, 11 Sep 2024 09:13:40 -0700 (PDT) Received: from [192.168.0.6] (ip-109-43-178-122.web.vodafone.de. [109.43.178.122]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378956dddacsm11852571f8f.107.2024.09.11.09.13.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Sep 2024 09:13:39 -0700 (PDT) Message-ID: Date: Wed, 11 Sep 2024 18:13:36 +0200 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached() To: "Richard W.M. Jones" , "Maciej S. Szmigiero" Cc: Eric Blake , Pierrick Bouvier , qemu-devel@nongnu.org, Zhao Liu , Joel Stanley , Kevin Wolf , Paolo Bonzini , qemu-arm@nongnu.org, Corey Minyard , Eric Farman , Keith Busch , WANG Xuerui , Hyman Huang , Stefan Berger , Michael Rolnik , Alistair Francis , =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , Markus Armbruster , Sriram Yagnaraman , Palmer Dabbelt , qemu-riscv@nongnu.org, Ani Sinha , Halil Pasic , Jesper Devantier , Laurent Vivier , Peter Maydell , Igor Mammedov , kvm@vger.kernel.org, =?UTF-8?Q?Alex_Benn=C3=A9e?= , Richard Henderson , Fam Zheng , qemu-s390x@nongnu.org, Hanna Reitz , Nicholas Piggin , Eduardo Habkost , Laurent Vivier , Rob Herring , Marcel Apfelbaum , qemu-block@nongnu.org, qemu-ppc@nongnu.org, Daniel Henrique Barboza , Christian Borntraeger , Harsh Prateek Bora , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Nina Schoetterl-Glausch , "Michael S. Tsirkin" , Fabiano Rosas , Helge Deller , Dmitry Fleytman , Daniel Henrique Barboza , Akihiko Odaki , Marcelo Tosatti , David Gibson , Aurelien Jarno , Liu Zhiwei , Yanan Wang , Peter Xu , Bin Meng , Weiwei Li , Klaus Jensen , Jean-Christophe Dubois , Jason Wang References: <20240910221606.1817478-1-pierrick.bouvier@linaro.org> <20240910221606.1817478-2-pierrick.bouvier@linaro.org> <10d6d67a-32f6-40fc-aba9-c62a74d9d98d@maciej.szmigiero.name> <20240911125126.GS1450@redhat.com> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20240911125126.GS1450@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/09/2024 14.51, Richard W.M. Jones wrote: > On Wed, Sep 11, 2024 at 02:46:18PM +0200, Maciej S. Szmigiero wrote: >> On 11.09.2024 14:37, Eric Blake wrote: >>> On Wed, Sep 11, 2024 at 07:33:59AM GMT, Eric Blake wrote: >>>> On Tue, Sep 10, 2024 at 03:15:28PM GMT, Pierrick Bouvier wrote: >>>>> Signed-off-by: Pierrick Bouvier >>>>> --- >>>> >>>> A general suggestion for the entire series: please use a commit >>>> message that explains why this is a good idea. Even something as >>>> boiler-plate as "refer to commit XXX for rationale" that can be >>>> copy-pasted into all the other commits is better than nothing, >>>> although a self-contained message is best. Maybe: >>>> >>>> This patch is part of a series that moves towards a consistent use of >>>> g_assert_not_reached() rather than an ad hoc mix of different >>>> assertion mechanisms. >>> >>> Or summarize your cover letter: >>> >>> Use of assert(false) can trip spurious control flow warnings from some >>> versions of gcc: >>> https://lore.kernel.org/qemu-devel/54bb02a6-1b12-460a-97f6-3f478ef766c6@linaro.org/ >>> Solve that by unifying the code base on g_assert_not_reached() >>> instead. >>> >> >> If using g_assert_not_reached() instead of assert(false) silences >> the warning about missing return value in such impossible to reach >> locations should we also be deleting the now-unnecessary "return" >> statements after g_assert_not_reached()? > > Although it's unlikely to be used on any compiler that can also > compile qemu, there is a third implementation of g_assert_not_reached > that does nothing, see: > > https://gitlab.gnome.org/GNOME/glib/-/blob/927683ebd94eb66c0d7868b77863f57ce9c5bc76/glib/gtestutils.h#L269 That's only in the #ifdef G_DISABLE_ASSERT case ... and we forbid that in QEMU, see osdep.h: #ifdef G_DISABLE_ASSERT #error building with G_DISABLE_ASSERT is not supported #endif So in QEMU, g_assert_not_reached() should always abort. Thomas