From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57567) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bm605-0006Tp-76 for qemu-devel@nongnu.org; Mon, 19 Sep 2016 17:21:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bm604-0007hX-18 for qemu-devel@nongnu.org; Mon, 19 Sep 2016 17:21:17 -0400 References: <1474303471-12509-1-git-send-email-jsnow@redhat.com> From: John Snow Message-ID: Date: Mon, 19 Sep 2016 17:21:08 -0400 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 0/2] block: allow flush on devices with open tray List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org On 09/19/2016 04:58 PM, Max Reitz wrote: > On 19.09.2016 18:44, John Snow wrote: >> Final re-send for wording. >> >> The move to blk_flush altered the behavior of migration and flushing >> nodes that are not reachable via the guest, but are still reachable >> via QEMU and may or may not need to be flushed. >> >> This is likely the simplest solution for now until we nail down our >> policy a bit more. >> >> This is intended for 2.6.2 and/or 2.7.1, to fix problems with libvirt >> et al being unable to migrate QEMU when the CDROM tray is open. >> >> v4: >> Commit message update. >> >> v3: >> Trying to take a hint from Kevin, reinstating bdrv_flush_all. >> If it's not what we want, we can try moving back to v2, >> acknowledging that a nicer solution in the future: >> (A) Can skip flushing on devices that just don't need it, and >> (B) Optionally institutes some sort of flush-on-eject policy. >> >> ________________________________________________________________________________ >> >> For convenience, this branch is available at: >> https://github.com/jnsnow/qemu.git branch atapi-tray-migfix >> https://github.com/jnsnow/qemu/tree/atapi-tray-migfix >> >> This version is tagged atapi-tray-migfix-v4: >> https://github.com/jnsnow/qemu/releases/tag/atapi-tray-migfix-v4 >> >> John Snow (2): >> block: reintroduce bdrv_flush_all >> qemu: use bdrv_flush_all for vm_stop et al >> >> block/io.c | 25 +++++++++++++++++++++++++ >> cpus.c | 4 ++-- >> include/block/block.h | 1 + >> 3 files changed, 28 insertions(+), 2 deletions(-) > > Reviewed-by: Max Reitz > http://i.imgur.com/DNltmfT.jpg