All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhuoying Cai <zycai@linux.ibm.com>
To: luoyonggang@gmail.com, "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org, shentey@gmail.com,
	cohuck@redhat.com, farman@linux.ibm.com, mjrosato@linux.ibm.com
Subject: Re: [PATCH v1] test/qtest: Remove s390x boot device support check in pxe-test.c
Date: Thu, 8 Oct 2026 16:00:26 -0400	[thread overview]
Message-ID: <c63d1003-1966-45d2-87af-06cfbddd9547@linux.ibm.com> (raw)
In-Reply-To: <CAE2XoE9Dg2CQGF9uQvM2=LEaXdGR+1Djt0DnYxntfASP-uD5OQ@mail.gmail.com>

On 10/8/26 2:46 PM, Yonggang Luo wrote:
> On Thu, Oct 8, 2026 at 11:47 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
>>
>> On Thu, Oct 08, 2026 at 11:34:35AM -0400, Zhuoying Cai wrote:
>>> The s390x PXE tests used `memmem` to probe the s390-ccw.img firmware
>>> for device support strings before running each test. MinGW-w64 does
>>> not provide `memmem`, breaking the MSYS2/GCC build.
>>>
>>> Remove the check as a workaround.
>>
>> Removing the testing on every platform due to a Windows limitation
>> is rather a big hammer. Why not wrap the code in  #ifndef WIN32   ?
> 
> I did it in another way:
> [PATCH 0/2] tests/qtest: fix and gaurd PXE test build on MinGW
> https://lore.kernel.org/qemu-devel/20261008184119.142-1-luoyonggang@gmail.com/T/#t
> 
> 

Thanks for the suggestion and for the fix!

Since I had already sent v1, I went ahead and sent a v2 with the
suggested WIN32 guard as another option:

https://lore.kernel.org/qemu-devel/20261008195158.289711-1-zycai@linux.ibm.com/

[...]



      reply	other threads:[~2026-10-08 20:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-08 15:34 [PATCH v1] test/qtest: Remove s390x boot device support check in pxe-test.c Zhuoying Cai
2026-10-08 15:45 ` Daniel P. Berrangé
2026-10-08 18:46   ` Yonggang Luo
2026-10-08 20:00     ` Zhuoying Cai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c63d1003-1966-45d2-87af-06cfbddd9547@linux.ibm.com \
    --to=zycai@linux.ibm.com \
    --cc=berrange@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=farman@linux.ibm.com \
    --cc=luoyonggang@gmail.com \
    --cc=mjrosato@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=shentey@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.