From: Quentin Schulz <quentin.schulz@cherry.de>
To: Johan Jonker <jbx6244@gmail.com>
Cc: kever.yang@rock-chips.com, sjg@chromium.org,
ilias.apalodimas@linaro.org, trini@konsulko.com,
u-boot@lists.u-boot-project.org
Subject: Re: [PATCH v1] rockchip: spl: replace ifdef by IS_ENABLED for timer_init() call condition
Date: Fri, 24 Jul 2026 10:45:25 +0200 [thread overview]
Message-ID: <c6530788-e823-4cb4-905a-5473d9c00914@cherry.de> (raw)
In-Reply-To: <cded3ae1-b908-49c6-af92-30b931d160c1@gmail.com>
Hi Johan,
On 7/24/26 12:17 AM, Johan Jonker wrote:
> Not all Rockchip SoC models use the ARM arch timer.
> Call the function timer_init() only when
> CONFIG_SYS_ARCH_TIMER is available.
> Replace the ifdef call condition by IS_ENABLED
> to increase build coverage and make the code easier to read.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
>
> Previous version not needed for serie, so resend separate.
> https://patchwork.ozlabs.org/project/uboot/patch/20220403230659.12039-5-jbx6244@gmail.com/
>
You didn't answer Kever's question in the linked patch and I have the
same question.
This is essentially the same code, so what's the benefit, are you trying
to fix a specific issue? How does this improve the situation?
How does doing that increase code coverage... etc :)
Cheers,
Quentin
next prev parent reply other threads:[~2026-07-24 8:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 22:17 [PATCH v1] rockchip: spl: replace ifdef by IS_ENABLED for timer_init() call condition Johan Jonker
2026-07-24 8:45 ` Quentin Schulz [this message]
2026-07-24 9:53 ` Johan Jonker
2026-07-30 15:37 ` Quentin Schulz
2026-07-30 22:06 ` Tom Rini
2026-08-06 16:46 ` Quentin Schulz
2026-08-06 17:40 ` Jonas Karlman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6530788-e823-4cb4-905a-5473d9c00914@cherry.de \
--to=quentin.schulz@cherry.de \
--cc=ilias.apalodimas@linaro.org \
--cc=jbx6244@gmail.com \
--cc=kever.yang@rock-chips.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.u-boot-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.