Re: [PATCH 3/7] btrfs-progs: rename struct open_ctree_flags to open_ctree_args

[Anand Jain <anand.jain@oracle.com>]

On 08/06/2023 14:14, Qu Wenruo wrote:
> 
> 
> On 2023/6/8 14:01, Anand Jain wrote:
>> The struct open_ctree_flags currently holds arguments for
>> open_ctree_fs_info(), it can be confusing when mixed with a local 
>> variable
>> named open_ctree_flags as below in the function cmd_inspect_dump_tree().
>>
>>     cmd_inspect_dump_tree()
>>     ::
>>     struct open_ctree_flags ocf = { 0 };
>>     ::
>>     unsigned open_ctree_flags;
>>
>> So rename struct open_ctree_flags to struct open_ctree_args.
> 
> I don't think this is a big deal.
> 
> Any LSP server and compiler can handle it correct.
> 
> Furthermore the rename would make a lot of @ocf variables loses its
> meaning. (The patch doesn't rename it to oca).
> 
> To me, the better solution would be remove local variable
> open_ctree_flags completely, and do all the flags setting using
> ocf.flags instead.
s/open_ctree_flags/open_ctree_args makes sense as this struct is
not just about the flags.

struct open_ctree_args {
         const char *filename;
         u64 sb_bytenr;
         u64 root_tree_bytenr;
         u64 chunk_tree_bytenr;
         unsigned flags;
};


PS:
We also have
enum btrfs_open_ctree_flags {
::
}

Thanks, Anand