From: Philipp Stanner <phasta@mailbox.org>
To: "Tvrtko Ursulin" <tursulin@ursulin.net>,
"Philipp Stanner" <phasta@kernel.org>,
"Matthew Brost" <matthew.brost@intel.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Christian König" <ckoenig.leichtzumerken@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/sched: Lock drm_sched_entity_is_idle()
Date: Tue, 18 Aug 2026 15:48:46 +0200 [thread overview]
Message-ID: <c65a016801f3151a042f46366c99bbce5597fc91.camel@mailbox.org> (raw)
In-Reply-To: <2dd34398-3ef2-4573-8311-60e5f6b346aa@ursulin.net>
On Thu, 2026-08-13 at 11:37 +0100, Tvrtko Ursulin wrote:
>
> On 13/08/2026 10:45, Philipp Stanner wrote:
> > drm_sched_entity_is_idle() contains a badly documented memory barrier
> > and an invalid lockless access to entity->stopped. Moreover, it also
> > accesses entity->list which is at all other places protected by
> > entity->lock.
> >
> > This function is in no way performance critical, so it is safer, more
> > readable and more maintainable to take the spinlock.
> >
> > Add locking to drm_sched_entity_is_idle().
> >
>
[…]
> Spotted by chance on the mailing list but I believe I gave you r-b for
> this one already.
Applied to misc-next with your r-b.
Thx
prev parent reply other threads:[~2026-08-18 13:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 9:45 [PATCH] drm/sched: Lock drm_sched_entity_is_idle() Philipp Stanner
2026-08-13 10:37 ` Tvrtko Ursulin
2026-08-18 13:48 ` Philipp Stanner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c65a016801f3151a042f46366c99bbce5597fc91.camel@mailbox.org \
--to=phasta@mailbox.org \
--cc=airlied@gmail.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.brost@intel.com \
--cc=mripard@kernel.org \
--cc=phasta@kernel.org \
--cc=simona@ffwll.ch \
--cc=tursulin@ursulin.net \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.