From: Eric Dumazet <eric.dumazet@gmail.com>
To: Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
John Fastabend <john.fastabend@gmail.com>,
Ivan Vecera <ivecera@redhat.com>
Subject: Re: [PATCH net-next v2 1/2] net: sched: add empty status flag for NOLOCK qdisc
Date: Fri, 22 Mar 2019 06:56:27 -0700 [thread overview]
Message-ID: <c6686cad-9bb1-e3e2-df47-91fadffe708d@gmail.com> (raw)
In-Reply-To: <8e2fe320cd3075be079d0bf8c46b98f32935d116.1553188500.git.pabeni@redhat.com>
On 03/22/2019 01:30 AM, Paolo Abeni wrote:
> The queue is marked not empty after acquiring the seqlock,
> and it's up to the NOLOCK qdisc clearing such flag on dequeue.
> Since the empty status lays on the same cache-line of the
> seqlock, it's always hot on cache during the updates.
>
>
> +static inline bool qdisc_is_empty(struct Qdisc *qdisc)
const struct Qdisc *qdisc
> +{
> + if (qdisc->flags & TCQ_F_NOLOCK)
> + return qdisc->empty;
> + return !qdisc->q.qlen;
> +}
> +
Other than that :
Reivewed-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2019-03-22 13:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 8:30 [PATCH net-next v2 0/2] net: dev: BYPASS for lockless qdisc Paolo Abeni
2019-03-22 8:30 ` [PATCH net-next v2 1/2] net: sched: add empty status flag for NOLOCK qdisc Paolo Abeni
2019-03-22 13:56 ` Eric Dumazet [this message]
2019-03-22 8:30 ` [PATCH net-next v2 2/2] net: dev: introduce support for sch BYPASS for lockless qdisc Paolo Abeni
2019-03-22 13:58 ` Eric Dumazet
2019-03-22 10:40 ` [PATCH net-next v2 0/2] net: dev: " Ivan Vecera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6686cad-9bb1-e3e2-df47-91fadffe708d@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ivecera@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.