From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C265C77B60 for ; Wed, 26 Apr 2023 11:43:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cwmFO/uLwZ0pgnZcYGwMuTa5iVQK2VCZ3Z+C1RMEajI=; b=yQiL33VLvqnRPInAtk0FVeFzzo Ffc0li4PLmtvfMJuYwDt7hyjtpKgJrZylel8QpoYIpXX+lgo6yWOYpTYAqMfjaIi0+ek3YJld033t HB4A6tIRdIRiB2s61TePGXkyq+jSi0uurAI+QVfV+S2GWElhni9SV9ivgTvqfqHAjq88Vm5cMrItN NpyQK5DZLHLd8naVzP98upbzGKqYRH0ldkbW0e+gDlaCIyXD3HaQtsT3lrvVuIsyAlTJSoH5Xobdz Y439OniBJHBpUuC6/IjNH+xfjUcL0RKrzIwO1kgOhnBFAqUBe8YtZVIyhIhSm9UUSV7hyWq8s0hhQ BCGFsQmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1prdYp-003o1h-1m; Wed, 26 Apr 2023 11:43:47 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1prdYn-003o0r-0G; Wed, 26 Apr 2023 11:43:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=cwmFO/uLwZ0pgnZcYGwMuTa5iVQK2VCZ3Z+C1RMEajI=; b=aJ1/P8eo6azJ4LDeWyiQ2s7I+n R9Tk+apcsnswrDxxg86vAgxT2sSvjRZzS6FxsHNKN8sM+WTKlQ7AabuEYOoG+Cy1CzPppX023A/+4 8ooW/2XAglSaifSWLjMYb9QtAhjrxtYlPvMdHXRKwgA/RkkT3zcKgY0tyDowjj3K3EhBcvlIwtN8B O/wXHTIdUi6AhJbtdrWriGMnhXoBA/Gq6xPhJbb2Lf4zXurDMErIVn+wfBBuPgWpuQQjKrOmdkc6z O6PsJByDIXyEJhj0ebcFYC9TcAnADI+ruyd04U/5EJ2QWcM1fmRM7KaKzyO7YpqbNpWMQ1jZ+/eNx qlL3yymg==; Received: from madras.collabora.co.uk ([46.235.227.172]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1prdYi-00AyIz-2e; Wed, 26 Apr 2023 11:43:43 +0000 Received: from [IPV6:2001:b07:2ed:14ed:c5f8:7372:f042:90a2] (unknown [IPv6:2001:b07:2ed:14ed:c5f8:7372:f042:90a2]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 2E77D660324E; Wed, 26 Apr 2023 12:43:27 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1682509407; bh=LHVBsT9EmHiYRsufhxP3C7/xLomL6Pg/ovhoh+Syk1o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Fs4E+VJTXcXu0HIh3Az2PWq4QVtLzeQiYlCCf5uMvRydDn/IOEb9gXaq+SJMNWucM dQ/+vmjEfzlCUXG9ZhQLKhoOe/gnZ+b4RbHRuMzSQqdMX7uI4XCJnnvVpD+1Kfll0P JB/4fLORJx1VzJGtWVb9LMFxlXyJeuBfbdNfEf4GgD6WpKxIhVnkt/2gvFFBUVnyEy d+2aUJzV4l6KgkQT0I2EqNk1tabB/S8i2JXQ3MZ/WxwzMKCYlJTwl9h7OhT98m+FLO gRwPs9QANyW7PoxrW83MG+HUa4leBbV6vQXSp7gDtSEkwJq6FaCDBI/vGXgC32v1AH Sv49JFXKHirSQ== Message-ID: Date: Wed, 26 Apr 2023 13:43:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH RESEND v3 0/9] Add gamma lut support for mt8195 To: "Jason-JH.Lin" , Chun-Kuang Hu , Rob Herring , Krzysztof Kozlowski , Matthias Brugger Cc: CK Hu , Rex-BC Chen , Singo Chang , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220912013006.27541-1-jason-jh.lin@mediatek.com> Content-Language: en-US From: AngeloGioacchino Del Regno In-Reply-To: <20220912013006.27541-1-jason-jh.lin@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230426_124341_166731_99392260 X-CRM114-Status: GOOD ( 19.98 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Il 12/09/22 03:29, Jason-JH.Lin ha scritto: > Since the gamma_set_common() function for previous SoC, > such as mt8173 and mt8183, is designed for 9bit-to-10bit > conversion. > mt8195 is using 10bit-to-12bit conversion, which is > not compatible with the previous function. > > Thus, need to update the function to fit the need of mt8195. Hello, can you please respin and fix this series on the latest linux-next? Besides, please test it carefully: as far as I can see, GNOME Night Light (or others) are not working on MT8195 (color temperature/ccorr). As for gamma itself, that's not working either; you can test it with a tool that will create a color profile by applying a new VCGT table, please look at [1] if you need tools. We can confirm that color correction works on at least MT8192 (colord), so it's MT8195 at fault. [1]: https://github.com/zb3/gnome-gamma-tool Regards, Angelo > --- > Change in RESEND v3: > Fix build warning >>> drivers/gpu/drm/mediatek/mtk_disp_gamma.c:59:14: warning: no previous prototype for 'mtk_gamma_get_size' [-Wmissing-prototypes] > > Change in v3: > 1. separate 1 dt-binding patch to 2 patches, 1 is for modifying > multiple items list to one and 1 is for moving mt8195 compatible. > 2. redefine variables to reduce memory usage. > 3. delete unused symbols. > 4. separate 1 drm/mediatek patch to 6 patches. > 5. rebase on tag 'next-20220909' > > Jason-JH.Lin (5): > drm/mediatek: Adjust mtk_drm_gamma_set_common parameters > drm/mediatek: Add gamma support different lut_size for other SoC > drm/mediatek: Add gamma support different lut_bits for other SoC > drm/mediatek: Add gamma support different bank_size for other SoC > drm/mediatek: Add clear RELAY_MODE bit to set gamma > > zheng-yan.chen (4): > dt-bindings: mediatek: modify item formatting for gamma > dt-bindings: mediatek: Add gamma compatible for mt8195 > drm/mediatek: Add gamma lut support for mt8195 > arm64: dts: Modify gamma compatible for mt8195 > > .../display/mediatek/mediatek,gamma.yaml | 8 +- > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 2 +- > drivers/gpu/drm/mediatek/mtk_disp_aal.c | 2 +- > drivers/gpu/drm/mediatek/mtk_disp_drv.h | 3 +- > drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 115 ++++++++++++++---- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 4 +- > drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 1 - > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 9 ++ > 8 files changed, 109 insertions(+), 35 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22058C77B60 for ; Wed, 26 Apr 2023 11:44:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EoWMv1PVzGW2Pz/MLicqvwyFsGGIQMorHtW2BnRKSfc=; b=aZuZUKMOb/SUaB /cROszpg9vp2Goy12cuMwwsIMRxzU9d7eG6fsC6+pXqMA5bXilv/waTluw7tNWTnR75O8WtBemU2T cXB52kr6pt0NuUR11EfCI30cnFl/EwuQEfuQvLoCZ3rlixJrmdg//JSsYdgNuOctl+FWziys+Qr7q L1vPo4K7cAbhvpV4PKy4vRhhA7GlcXc1Xzv8WLV9g636cTkb/YHAKT/e31yleIXrEX4QDejXt62lZ mwEiCETyBgODnGwHiCT20mGcr5MLX+ZiMhka+Zc3WNyoTG3bobg8x21Zt+wVEqQ48Xy5fyjYDbxzx tUQ3BkGzBVsrLV6yKf9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1prdYo-003o1D-1o; Wed, 26 Apr 2023 11:43:46 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1prdYn-003o0r-0G; Wed, 26 Apr 2023 11:43:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=cwmFO/uLwZ0pgnZcYGwMuTa5iVQK2VCZ3Z+C1RMEajI=; b=aJ1/P8eo6azJ4LDeWyiQ2s7I+n R9Tk+apcsnswrDxxg86vAgxT2sSvjRZzS6FxsHNKN8sM+WTKlQ7AabuEYOoG+Cy1CzPppX023A/+4 8ooW/2XAglSaifSWLjMYb9QtAhjrxtYlPvMdHXRKwgA/RkkT3zcKgY0tyDowjj3K3EhBcvlIwtN8B O/wXHTIdUi6AhJbtdrWriGMnhXoBA/Gq6xPhJbb2Lf4zXurDMErIVn+wfBBuPgWpuQQjKrOmdkc6z O6PsJByDIXyEJhj0ebcFYC9TcAnADI+ruyd04U/5EJ2QWcM1fmRM7KaKzyO7YpqbNpWMQ1jZ+/eNx qlL3yymg==; Received: from madras.collabora.co.uk ([46.235.227.172]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1prdYi-00AyIz-2e; Wed, 26 Apr 2023 11:43:43 +0000 Received: from [IPV6:2001:b07:2ed:14ed:c5f8:7372:f042:90a2] (unknown [IPv6:2001:b07:2ed:14ed:c5f8:7372:f042:90a2]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 2E77D660324E; Wed, 26 Apr 2023 12:43:27 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1682509407; bh=LHVBsT9EmHiYRsufhxP3C7/xLomL6Pg/ovhoh+Syk1o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Fs4E+VJTXcXu0HIh3Az2PWq4QVtLzeQiYlCCf5uMvRydDn/IOEb9gXaq+SJMNWucM dQ/+vmjEfzlCUXG9ZhQLKhoOe/gnZ+b4RbHRuMzSQqdMX7uI4XCJnnvVpD+1Kfll0P JB/4fLORJx1VzJGtWVb9LMFxlXyJeuBfbdNfEf4GgD6WpKxIhVnkt/2gvFFBUVnyEy d+2aUJzV4l6KgkQT0I2EqNk1tabB/S8i2JXQ3MZ/WxwzMKCYlJTwl9h7OhT98m+FLO gRwPs9QANyW7PoxrW83MG+HUa4leBbV6vQXSp7gDtSEkwJq6FaCDBI/vGXgC32v1AH Sv49JFXKHirSQ== Message-ID: Date: Wed, 26 Apr 2023 13:43:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH RESEND v3 0/9] Add gamma lut support for mt8195 To: "Jason-JH.Lin" , Chun-Kuang Hu , Rob Herring , Krzysztof Kozlowski , Matthias Brugger Cc: CK Hu , Rex-BC Chen , Singo Chang , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220912013006.27541-1-jason-jh.lin@mediatek.com> Content-Language: en-US From: AngeloGioacchino Del Regno In-Reply-To: <20220912013006.27541-1-jason-jh.lin@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230426_124341_166731_99392260 X-CRM114-Status: GOOD ( 19.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 12/09/22 03:29, Jason-JH.Lin ha scritto: > Since the gamma_set_common() function for previous SoC, > such as mt8173 and mt8183, is designed for 9bit-to-10bit > conversion. > mt8195 is using 10bit-to-12bit conversion, which is > not compatible with the previous function. > > Thus, need to update the function to fit the need of mt8195. Hello, can you please respin and fix this series on the latest linux-next? Besides, please test it carefully: as far as I can see, GNOME Night Light (or others) are not working on MT8195 (color temperature/ccorr). As for gamma itself, that's not working either; you can test it with a tool that will create a color profile by applying a new VCGT table, please look at [1] if you need tools. We can confirm that color correction works on at least MT8192 (colord), so it's MT8195 at fault. [1]: https://github.com/zb3/gnome-gamma-tool Regards, Angelo > --- > Change in RESEND v3: > Fix build warning >>> drivers/gpu/drm/mediatek/mtk_disp_gamma.c:59:14: warning: no previous prototype for 'mtk_gamma_get_size' [-Wmissing-prototypes] > > Change in v3: > 1. separate 1 dt-binding patch to 2 patches, 1 is for modifying > multiple items list to one and 1 is for moving mt8195 compatible. > 2. redefine variables to reduce memory usage. > 3. delete unused symbols. > 4. separate 1 drm/mediatek patch to 6 patches. > 5. rebase on tag 'next-20220909' > > Jason-JH.Lin (5): > drm/mediatek: Adjust mtk_drm_gamma_set_common parameters > drm/mediatek: Add gamma support different lut_size for other SoC > drm/mediatek: Add gamma support different lut_bits for other SoC > drm/mediatek: Add gamma support different bank_size for other SoC > drm/mediatek: Add clear RELAY_MODE bit to set gamma > > zheng-yan.chen (4): > dt-bindings: mediatek: modify item formatting for gamma > dt-bindings: mediatek: Add gamma compatible for mt8195 > drm/mediatek: Add gamma lut support for mt8195 > arm64: dts: Modify gamma compatible for mt8195 > > .../display/mediatek/mediatek,gamma.yaml | 8 +- > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 2 +- > drivers/gpu/drm/mediatek/mtk_disp_aal.c | 2 +- > drivers/gpu/drm/mediatek/mtk_disp_drv.h | 3 +- > drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 115 ++++++++++++++---- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 4 +- > drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 1 - > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 9 ++ > 8 files changed, 109 insertions(+), 35 deletions(-) > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B2ECC7618E for ; Wed, 26 Apr 2023 11:43:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3AD8010E952; Wed, 26 Apr 2023 11:43:32 +0000 (UTC) Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8194B10E02A for ; Wed, 26 Apr 2023 11:43:30 +0000 (UTC) Received: from [IPV6:2001:b07:2ed:14ed:c5f8:7372:f042:90a2] (unknown [IPv6:2001:b07:2ed:14ed:c5f8:7372:f042:90a2]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 2E77D660324E; Wed, 26 Apr 2023 12:43:27 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1682509407; bh=LHVBsT9EmHiYRsufhxP3C7/xLomL6Pg/ovhoh+Syk1o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Fs4E+VJTXcXu0HIh3Az2PWq4QVtLzeQiYlCCf5uMvRydDn/IOEb9gXaq+SJMNWucM dQ/+vmjEfzlCUXG9ZhQLKhoOe/gnZ+b4RbHRuMzSQqdMX7uI4XCJnnvVpD+1Kfll0P JB/4fLORJx1VzJGtWVb9LMFxlXyJeuBfbdNfEf4GgD6WpKxIhVnkt/2gvFFBUVnyEy d+2aUJzV4l6KgkQT0I2EqNk1tabB/S8i2JXQ3MZ/WxwzMKCYlJTwl9h7OhT98m+FLO gRwPs9QANyW7PoxrW83MG+HUa4leBbV6vQXSp7gDtSEkwJq6FaCDBI/vGXgC32v1AH Sv49JFXKHirSQ== Message-ID: Date: Wed, 26 Apr 2023 13:43:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH RESEND v3 0/9] Add gamma lut support for mt8195 To: "Jason-JH.Lin" , Chun-Kuang Hu , Rob Herring , Krzysztof Kozlowski , Matthias Brugger References: <20220912013006.27541-1-jason-jh.lin@mediatek.com> Content-Language: en-US From: AngeloGioacchino Del Regno In-Reply-To: <20220912013006.27541-1-jason-jh.lin@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Singo Chang , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Project_Global_Chrome_Upstream_Group@mediatek.com, Rex-BC Chen , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Il 12/09/22 03:29, Jason-JH.Lin ha scritto: > Since the gamma_set_common() function for previous SoC, > such as mt8173 and mt8183, is designed for 9bit-to-10bit > conversion. > mt8195 is using 10bit-to-12bit conversion, which is > not compatible with the previous function. > > Thus, need to update the function to fit the need of mt8195. Hello, can you please respin and fix this series on the latest linux-next? Besides, please test it carefully: as far as I can see, GNOME Night Light (or others) are not working on MT8195 (color temperature/ccorr). As for gamma itself, that's not working either; you can test it with a tool that will create a color profile by applying a new VCGT table, please look at [1] if you need tools. We can confirm that color correction works on at least MT8192 (colord), so it's MT8195 at fault. [1]: https://github.com/zb3/gnome-gamma-tool Regards, Angelo > --- > Change in RESEND v3: > Fix build warning >>> drivers/gpu/drm/mediatek/mtk_disp_gamma.c:59:14: warning: no previous prototype for 'mtk_gamma_get_size' [-Wmissing-prototypes] > > Change in v3: > 1. separate 1 dt-binding patch to 2 patches, 1 is for modifying > multiple items list to one and 1 is for moving mt8195 compatible. > 2. redefine variables to reduce memory usage. > 3. delete unused symbols. > 4. separate 1 drm/mediatek patch to 6 patches. > 5. rebase on tag 'next-20220909' > > Jason-JH.Lin (5): > drm/mediatek: Adjust mtk_drm_gamma_set_common parameters > drm/mediatek: Add gamma support different lut_size for other SoC > drm/mediatek: Add gamma support different lut_bits for other SoC > drm/mediatek: Add gamma support different bank_size for other SoC > drm/mediatek: Add clear RELAY_MODE bit to set gamma > > zheng-yan.chen (4): > dt-bindings: mediatek: modify item formatting for gamma > dt-bindings: mediatek: Add gamma compatible for mt8195 > drm/mediatek: Add gamma lut support for mt8195 > arm64: dts: Modify gamma compatible for mt8195 > > .../display/mediatek/mediatek,gamma.yaml | 8 +- > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 2 +- > drivers/gpu/drm/mediatek/mtk_disp_aal.c | 2 +- > drivers/gpu/drm/mediatek/mtk_disp_drv.h | 3 +- > drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 115 ++++++++++++++---- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 4 +- > drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 1 - > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 9 ++ > 8 files changed, 109 insertions(+), 35 deletions(-) >