From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C1E5298CA3 for ; Thu, 12 Jun 2025 15:36:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749742604; cv=none; b=NzH7LtzM65366Ibv7QJBB/RGDAfhyD4q4jSsvq+afGRiOgAqdahoqQpvsY5vnFCfc1GoxbDC1Sy/jUxJEaNgNt35IClGY7vlL4KyiwY7OFVH6r5RxKhOI9Y/jwLVFvNIx+4tj7qEL8xtcU2BmbEldRTdXziWiPTaHPFGskZCRHE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749742604; c=relaxed/simple; bh=PI5f96cR6hYaypvBXQce4I7+EC/ofNQivIj5NzZKHho=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EgNW2Pg1vE8xpkH4BWTIMqc5jujNXqhD/c7vxA7wTqZV9g3e0aQQMSK07uyKejGgBlUDbuLH/Y21ozT5+qqR4n5VItBKCr/CPf/p1Ezs2paDsfgnAGtjyzOS85eFEcPE6CdgZ2fjYUXKYHRGjKbXmNiVJqljWjQP+ICatTzSGJU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TeH3oKnK; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TeH3oKnK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749742601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=j6FlpRtQvUpUW4eY/0JVT6f8fEwPoGbC3/HdECX0jnY=; b=TeH3oKnKJsC1OEx93uirL4yPttk2hU7rV8xz5XIQ7JQZvhsoPTTRj+84pfRJXRK2NfamL+ nQ2UQYk5i7fizaO1+jDcSaWJlXcA9t7g3q66MM0XfZJ+qK9qkNdqCqzbVs1RUnAxQjS+Rc zWwkL3ugxpZkl5NVeg5cjw1iVmd7uWw= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-357-mMl5B7BCNIidXviM411QJQ-1; Thu, 12 Jun 2025 11:36:39 -0400 X-MC-Unique: mMl5B7BCNIidXviM411QJQ-1 X-Mimecast-MFC-AGG-ID: mMl5B7BCNIidXviM411QJQ_1749742598 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4e9252ba0so707633f8f.0 for ; Thu, 12 Jun 2025 08:36:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749742598; x=1750347398; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=j6FlpRtQvUpUW4eY/0JVT6f8fEwPoGbC3/HdECX0jnY=; b=BhP+V9abe7T7gEELY4/wSb6Ue6wITPhtRzzfu5DPsm1Cy0GyWmNYYzXFs3FZk/vy1C Q6UrcThuWKzTWCDHUISfU0ZjBwTtXF8xkIPA1MvXWSg0CXQBeHptgkDkhezcsPVwqQMd 1uaNFb32BXIKtifdc5DXHd0yuryrS08vFy4CAczrvkVPg2vFNHogawuENhY223cUgKs6 8kxKoKU5WDdEpju6VI4Lw0+ZgGAgVNvI3KGLkNJ2OXVcj0CrjY4mHh/XDh4Anznm+Ql4 Ods69RtH9XCBrOxL56tGSVpOA1SxBiZyM6R1AF5iJQ95OML5+i/PA1SkOHhX42J39dBA s+uA== X-Forwarded-Encrypted: i=1; AJvYcCU5qQUlh2vXmFwSrL6I+t1Xb9MspW5iEcAcyF8y792UnEr40Mt+IWVKDyQ84SpgbAdRQJimxX3u/Oo=@vger.kernel.org X-Gm-Message-State: AOJu0YxqrJ7APgJ1NX1w2r9Cp516oWIqAHqfEbmbU7OxxJ/HXw3DLsnj zc1Zqogrfo40bB87lhAu9Dzn84yg8cK9Y38cItL7qlDqvNXmCRReOFDyf5W98SNntKkFnGAg0kn /+bmilMzqeZYxebsAfUeYymUHRyhe1xLnLxcN3j2A+OvLm1d6O5m8yULqUwy1wg== X-Gm-Gg: ASbGncs5guZL4zYDGvFQ5SpQF/Jh8WVE+/QcOmLiMsc0xhUcmR0ITgPK8ZZKNTTJDeS lJyTtJKXMuTrLRwUncfOgtopfhDwIhWRm7Fvz6zFHECI3SiUyr2UBg6pDk+ebaL9iw+F6KM9JQg a2S4atIe0+KILFNe28JTeplE7LHPa1BS7B/3pl8DIetXxh7mirtXSMgsp4cNjiXVoDIadEDWy0f bt8Rvjc/60AMjMsczHCnsWpNi40fXCEYmSUVFLlnyEGdZR6YDDF/++g3Rm5+df07gLP+st4z23W UOf4RmiE9qB4i2hxmvVVejQ9dhHiEBrg/o4H6G2ktTE2yd4JRlXpgLR2Mm2JaPGgb/HzNk1gOqs h+uvIqvc4Svp2QiGyBsoeQPaj8mGYsDBNXTVvqpxGs+Ks9+ayEQ== X-Received: by 2002:a05:6000:250d:b0:3a4:d8f8:fba7 with SMTP id ffacd0b85a97d-3a560748c21mr3810553f8f.2.1749742597931; Thu, 12 Jun 2025 08:36:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGOfhHJckHdYmyAgxwpqTeZ7FZww/fQGcBhftw9Ckx1CdxgEKuklHbnz03HaXMemBKSqLkt2w== X-Received: by 2002:a05:6000:250d:b0:3a4:d8f8:fba7 with SMTP id ffacd0b85a97d-3a560748c21mr3810526f8f.2.1749742597569; Thu, 12 Jun 2025 08:36:37 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2c:1e00:1e1e:7a32:e798:6457? (p200300d82f2c1e001e1e7a32e7986457.dip0.t-ipconnect.de. [2003:d8:2f2c:1e00:1e1e:7a32:e798:6457]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532e253f64sm23645205e9.27.2025.06.12.08.36.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Jun 2025 08:36:36 -0700 (PDT) Message-ID: Date: Thu, 12 Jun 2025 17:36:35 +0200 Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud() To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Andrew Morton , Alistair Popple , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Dan Williams , Oscar Salvador , stable@vger.kernel.org References: <20250611120654.545963-1-david@redhat.com> <20250611120654.545963-2-david@redhat.com> <02d6a55b-52fd-4dae-ba7a-1cccf72386aa@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <02d6a55b-52fd-4dae-ba7a-1cccf72386aa@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: WgPPNCFNPXqKEk-yjanKMvPJtgEPF7zkUczS9-mx_aA_1749742598 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12.06.25 17:28, Lorenzo Stoakes wrote: > On Wed, Jun 11, 2025 at 02:06:52PM +0200, David Hildenbrand wrote: >> We setup the cache mode but ... don't forward the updated pgprot to >> insert_pfn_pud(). >> >> Only a problem on x86-64 PAT when mapping PFNs using PUDs that >> require a special cachemode. >> >> Fix it by using the proper pgprot where the cachemode was setup. >> >> Identified by code inspection. >> >> Fixes: 7b806d229ef1 ("mm: remove vmf_insert_pfn_xxx_prot() for huge page-table entries") >> Cc: >> Signed-off-by: David Hildenbrand > > Nice catch! > > Reviewed-by: Lorenzo Stoakes Thanks! What's your opinion on stable? Really hard to judge the impact ... -- Cheers, David / dhildenb