From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Add aub debug support for kernel Date: Sun, 07 Nov 2010 14:23:43 +0000 Message-ID: References: <1288689096-23230-1-git-send-email-yuanhan.liu@intel.com> <849307$a7if4n@azsmga001.ch.intel.com> <5b55a1$ij0t3g@fmsmga002.fm.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 1B0E29E782 for ; Sun, 7 Nov 2010 06:23:46 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Liu Aleaxander Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sun, 7 Nov 2010 22:08:00 +0800, Liu Aleaxander wrote: > I wrote a new patch(no post-processing yet). > Chris, is this what you want? Yes, that looks good. The compiler should be able to do its job and reduce that code nicely. I think you want, in addition, a pair of I915_READ_NOTRACE and I915_WRITE_NOTRACE for the GPIO registers. I would suggest converting the calls that you don't want traced as a separate patch to keep the commits clean. -Chris -- Chris Wilson, Intel Open Source Technology Centre