From: "jonathan.albrecht" <jonathan.albrecht@linux.vnet.ibm.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: ruixin.bao@ibm.com, iii@linux.ibm.com, david@redhat.com,
cohuck@redhat.com, laurent@vivier.eu, qemu-devel@nongnu.org,
borntraeger@de.ibm.com, qemu-s390x@nongnu.org,
krebbel@linux.ibm.com
Subject: Re: [PATCH v2 1/2] linux-user/s390x: signal with SIGFPE on compare-and-trap
Date: Fri, 09 Jul 2021 10:48:28 -0400 [thread overview]
Message-ID: <c6e73d5317b218134a1e714890c4bedd@imap.linux.ibm.com> (raw)
In-Reply-To: <40211134-9406-4270-49ff-a6a4f9e1d22a@linaro.org>
On 2021-07-09 10:37 am, Richard Henderson wrote:
> On 7/9/21 7:23 AM, jonathan.albrecht wrote:
>>> As a general comment, I think a single switch over DXC would be
>>> cleaner for both kernel and qemu. It seems like giving different
>>> si_code for e.g. "0x40 IEEE division by zero" and "0x43 Simulated
>>> IEEE
>>> division by zero" is actively incorrect.
>>>
>> I went over the DXC section and I see what you mean about the si_codes
>> for simulated IEEE exceptions. I'll plan on handling those the same as
>> non-simulated IEEE if no objections.
>
> Only if you plan on submitting a similar patch for the kernel.
> Otherwise, qemu would not match the kernel abi.
>
Thanks for clarifying. In that case, I'll handle simulated IEEE the same
as the current kernel.
next prev parent reply other threads:[~2021-07-09 15:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 13:42 [PATCH v2 0/2] linux-user/s390x: signal with SIGFPE on compare-and-trap Jonathan Albrecht
2021-07-07 13:42 ` [PATCH v2 1/2] " Jonathan Albrecht
2021-07-08 17:08 ` Richard Henderson
2021-07-09 14:23 ` jonathan.albrecht
2021-07-09 14:37 ` Richard Henderson
2021-07-09 14:48 ` jonathan.albrecht [this message]
2021-07-07 13:42 ` [PATCH v2 2/2] tests/tcg: Test that compare-and-trap raises SIGFPE Jonathan Albrecht
2021-07-08 17:18 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6e73d5317b218134a1e714890c4bedd@imap.linux.ibm.com \
--to=jonathan.albrecht@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=krebbel@linux.ibm.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=ruixin.bao@ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.