From: nguyenb@codeaurora.org
To: Can Guo <cang@codeaurora.org>
Cc: asutoshd@codeaurora.org, hongwus@codeaurora.org,
ziqichen@codeaurora.org, rnayak@codeaurora.org,
linux-scsi@vger.kernel.org, kernel-team@android.com,
saravanak@google.com, salyzyn@google.com,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Bean Huo <beanhuo@micron.com>,
Bart Van Assche <bvanassche@acm.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] scsi: ufs: Print host regs in IRQ handler when AH8 error happens
Date: Tue, 24 Nov 2020 20:17:59 -0800 [thread overview]
Message-ID: <c6ef8b22f151668037fb31c8163d588e@codeaurora.org> (raw)
In-Reply-To: <1605596660-2987-4-git-send-email-cang@codeaurora.org>
On 2020-11-16 23:04, Can Guo wrote:
> When AH8 error happens, all the regs and states are dumped in err
> handler.
> Sometime we need to look into host regs right after AH8 error happens,
> which is before leaving the IRQ handler.
>
> Signed-off-by: Can Guo <cang@codeaurora.org>
> ---
> drivers/scsi/ufs/ufshcd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index cd7394e..a7857f6 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -6057,7 +6057,8 @@ static irqreturn_t ufshcd_check_errors(struct
> ufs_hba *hba)
> hba->saved_uic_err |= hba->uic_error;
>
> /* dump controller state before resetting */
> - if ((hba->saved_err & (INT_FATAL_ERRORS)) ||
> + if ((hba->saved_err &
> + (INT_FATAL_ERRORS | UFSHCD_UIC_HIBERN8_MASK)) ||
> (hba->saved_uic_err &&
> (hba->saved_uic_err != UFSHCD_UIC_PA_GENERIC_ERROR))) {
> dev_err(hba->dev, "%s: saved_err 0x%x saved_uic_err 0x%x\n",
Reviewed-by: Bao D. Nguyen <nguyenb@codeaurora.org>
prev parent reply other threads:[~2020-11-25 4:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 7:04 [PATCH v3 0/3] Fix some racing problems btw err_handler and paths like system PM ops and the task abort callback Can Guo
2020-11-17 7:04 ` [PATCH v3 1/3] scsi: ufs: Serialize eh_work with system PM events and async scan Can Guo
2020-11-25 2:48 ` hongwus
2020-12-01 2:41 ` Asutosh Das (asd)
2020-11-17 7:04 ` [PATCH v3 2/3] scsi: ufs: Fix a racing problem between ufshcd_abort and eh_work Can Guo
2020-12-01 2:42 ` Asutosh Das (asd)
2020-11-17 7:04 ` [PATCH v3 3/3] scsi: ufs: Print host regs in IRQ handler when AH8 error happens Can Guo
2020-11-17 17:23 ` Asutosh Das (asd)
2020-11-25 2:51 ` hongwus
2020-11-25 4:17 ` nguyenb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6ef8b22f151668037fb31c8163d588e@codeaurora.org \
--to=nguyenb@codeaurora.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=hongwus@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
--cc=stanley.chu@mediatek.com \
--cc=ziqichen@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.