From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 1/2] drm/i915/userptr: Probe existence of backing struct pages upon creation Date: Thu, 9 Nov 2017 16:10:47 +0000 Message-ID: References: <20171108185148.20081-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4CD2A6E918 for ; Thu, 9 Nov 2017 16:10:53 +0000 (UTC) In-Reply-To: <20171108185148.20081-1-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA4LzExLzIwMTcgMTg6NTEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBKYXNvbiBFa3N0cmFu ZCByZXF1ZXN0ZWQgYSBtb3JlIGVmZmljaWVudCBtZXRob2QgdGhhbiB1c2VycHRyK3NldC1kb21h aW4KPiB0byBkZXRlcm1pbmUgaWYgdGhlIHVzZXJwdHIgb2JqZWN0IHdhcyBiYWNrZWQgYnkgYSBj b21wbGV0ZSBzZXQgb2YgcGFnZXMKPiB1cG9uIGNyZWF0aW9uLiBUbyBiZSBtb3JlIGVmZmljaWVu dCB0aGFuIHNpbXBseSBwb3B1bGF0aW5nIHRoZSB1c2VycHRyCj4gdXNpbmcgZ2V0X3VzZXJfcGFn ZXMoKSAoYXMgZG9uZSBieSB0aGUgY2FsbCB0byBzZXQtZG9tYWluIG9yIGV4ZWNidWYpLAo+IHdl IGNhbiB3YWxrIHRoZSB0cmVlIG9mIHZtX2FyZWFfc3RydWN0IGFuZCBjaGVjayBmb3IgZ2FwcyBv ciB2bWEgbm90Cj4gYmFja2VkIGJ5IHN0cnVjdCBwYWdlIChWTV9QRk5NQVApLiBUaGUgcXVlc3Rp b24gaXMgaG93IHRvIGhhbmRsZQo+IFZNX01JWEVETUFQIHdoaWNoIG1heSBiZSBlaXRoZXIgc3Ry dWN0IHBhZ2Ugb3IgcGZuIGJhY2tlZC4uLgoKRmlyc3QgcmVhY3Rpb24gaXMgdGhhdCBpdCBzb3Vu ZHMgbGlrZSBhIGJhZCBpZGVhLiBXZWxsIG1heWJlIG5vdCBiYWQsIApidXQgYSBiaXQgcXVlc3Rp b25hYmxlIHNpbmNlIGlmIHRoZSB1c2Vyc3BhY2UgZG9lc24ndCBrbm93LCB0aGVuIHRoZXJlIAph cmUgbm8gZ3VhcmFudGVlcyB0aGUgcmVzdWx0IG9mIHByb2JlIHdpbGwgcmVtYWluIHZhbGlkIHVu dGlsIHRoZSB0aW1lIAp0byBhY3R1YWxseSBpbnN0YW50aWF0ZSB0aGUgYmFja2luZyBzdG9yZSBj b21lcy4KClRoZSBwb3B1bGF0ZSBpZGVhIGZyb20gdGhlIG5leHQgcGF0Y2ggc291bmRzIG9rYXkg b24gdGhlIG90aGVyIGhhbmQuIFNvIAppcyB0aGVyZSBhbiB1c2UgY2FzZSB3aGVyZSBleHRyZW1l bHkgY29udHJvbGxpbmcgdXNlcnNwYWNlIHdvdWxkIGJlbmVmaXQgCmZyb20gcHJvYmUgcmF0aGVy IHRoYW4ganVzdCB1c2luZyBwb3B1bGF0ZT8KClJlZ2FyZHMsCgpUdnJ0a28KCj4gCj4gVGVzdGNh c2U6IGlndC9nZW1fdXNlcnB0cl9ibGl0cy9wcm9iZQo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdp bHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZy dGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+IENjOiBNaWNoYcWCIFdpbmlhcnNraSA8bWljaGFsLndp bmlhcnNraUBpbnRlbC5jb20+Cj4gQ2M6IEphc29uIEVrc3RyYW5kIDxqYXNvbkBqbGVrc3RyYW5k Lm5ldD4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3VzZXJwdHIuYyB8 IDM4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICAgaW5jbHVkZS91YXBpL2Ry bS9pOTE1X2RybS5oICAgICAgICAgICAgIHwgIDUgKysrLS0KPiAgIDIgZmlsZXMgY2hhbmdlZCwg NDEgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fdXNlcnB0ci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW1fdXNlcnB0ci5jCj4gaW5kZXggZTI2YjIzMTcxYjU2Li5kYmM1ODE4ZGQyOGIgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fdXNlcnB0ci5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fdXNlcnB0ci5jCj4gQEAgLTcxOSw2ICs3 MTksMzMgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0X29wcyBpOTE1 X2dlbV91c2VycHRyX29wcyA9IHsKPiAgIAkucmVsZWFzZSA9IGk5MTVfZ2VtX3VzZXJwdHJfcmVs ZWFzZSwKPiAgIH07Cj4gICAKPiArc3RhdGljIGludAo+ICtwcm9iZV9yYW5nZShzdHJ1Y3QgbW1f c3RydWN0ICptbSwgdW5zaWduZWQgbG9uZyBhZGRyLCB1bnNpZ25lZCBsb25nIGxlbikKPiArewo+ ICsJY29uc3QgdW5zaWduZWQgbG9uZyBlbmQgPSBhZGRyICsgbGVuOwo+ICsJc3RydWN0IHZtX2Fy ZWFfc3RydWN0ICp2bWE7Cj4gKwlpbnQgcmV0ID0gLUVGQVVMVDsKPiArCj4gKwlkb3duX3JlYWQo Jm1tLT5tbWFwX3NlbSk7Cj4gKwlmb3IgKHZtYSA9IGZpbmRfdm1hKG1tLCBhZGRyKTsgdm1hOyB2 bWEgPSB2bWEtPnZtX25leHQpIHsKPiArCQlpZiAodm1hLT52bV9zdGFydCA+IGFkZHIpCj4gKwkJ CWJyZWFrOwo+ICsKPiArCQlpZiAodm1hLT52bV9mbGFncyAmIChWTV9QRk5NQVAgfCBWTV9NSVhF RE1BUCkpCj4gKwkJCWJyZWFrOwo+ICsKPiArCQlpZiAodm1hLT52bV9lbmQgPj0gZW5kKSB7Cj4g KwkJCXJldCA9IDA7Cj4gKwkJCWJyZWFrOwo+ICsJCX0KPiArCj4gKwkJYWRkciA9IHZtYS0+dm1f ZW5kOwo+ICsJfQo+ICsJdXBfcmVhZCgmbW0tPm1tYXBfc2VtKTsKPiArCj4gKwlyZXR1cm4gcmV0 Owo+ICt9Cj4gKwo+ICAgLyoqCj4gICAgKiBDcmVhdGVzIGEgbmV3IG1tIG9iamVjdCB0aGF0IHdy YXBzIHNvbWUgbm9ybWFsIG1lbW9yeSBmcm9tIHRoZSBwcm9jZXNzCj4gICAgKiBjb250ZXh0IC0g dXNlciBtZW1vcnkuCj4gQEAgLTc3MSw2ICs3OTgsNyBAQCBpOTE1X2dlbV91c2VycHRyX2lvY3Rs KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsIHN0cnVjdCBkcm1fZmlsZSAqZmls ZQo+ICAgCX0KPiAgIAo+ICAgCWlmIChhcmdzLT5mbGFncyAmIH4oSTkxNV9VU0VSUFRSX1JFQURf T05MWSB8Cj4gKwkJCSAgICBJOTE1X1VTRVJQVFJfUFJPQkUgfAo+ICAgCQkJICAgIEk5MTVfVVNF UlBUUl9VTlNZTkNIUk9OSVpFRCkpCj4gICAJCXJldHVybiAtRUlOVkFMOwo+ICAgCj4gQEAgLTc4 OCw2ICs4MTYsMTYgQEAgaTkxNV9nZW1fdXNlcnB0cl9pb2N0bChzdHJ1Y3QgZHJtX2RldmljZSAq ZGV2LCB2b2lkICpkYXRhLCBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUKPiAgIAkJcmV0dXJuIC1FTk9E RVY7Cj4gICAJfQo+ICAgCj4gKwlpZiAoYXJncy0+ZmxhZ3MgJiBJOTE1X1VTRVJQVFJfUFJPQkUp IHsKPiArCQkvKgo+ICsJCSAqIENoZWNrIHRoYXQgdGhlIHJhbmdlIHBvaW50ZWQgdG8gcmVwcmVz ZW50cyByZWFsIHN0cnVjdAo+ICsJCSAqIHBhZ2VzIGFuZCBub3QgaW9tYXBwaW5ncyAoYXQgdGhp cyBtb21lbnQgaW4gdGltZSEpCj4gKwkJICovCj4gKwkJcmV0ID0gcHJvYmVfcmFuZ2UoY3VycmVu dC0+bW0sIGFyZ3MtPnVzZXJfcHRyLCBhcmdzLT51c2VyX3NpemUpOwo+ICsJCWlmIChyZXQpCj4g KwkJCXJldHVybiByZXQ7Cj4gKwl9Cj4gKwo+ICAgCW9iaiA9IGk5MTVfZ2VtX29iamVjdF9hbGxv YyhkZXZfcHJpdik7Cj4gICAJaWYgKG9iaiA9PSBOVUxMKQo+ICAgCQlyZXR1cm4gLUVOT01FTTsK PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS91YXBpL2RybS9pOTE1X2RybS5oIGIvaW5jbHVkZS91YXBp L2RybS9pOTE1X2RybS5oCj4gaW5kZXggYWMzYzY1MDNjYTI3Li4zOTJlZGUyY2E2M2UgMTAwNjQ0 Cj4gLS0tIGEvaW5jbHVkZS91YXBpL2RybS9pOTE1X2RybS5oCj4gKysrIGIvaW5jbHVkZS91YXBp L2RybS9pOTE1X2RybS5oCj4gQEAgLTEzNTIsOCArMTM1Miw5IEBAIHN0cnVjdCBkcm1faTkxNV9n ZW1fdXNlcnB0ciB7Cj4gICAJX191NjQgdXNlcl9wdHI7Cj4gICAJX191NjQgdXNlcl9zaXplOwo+ ICAgCV9fdTMyIGZsYWdzOwo+IC0jZGVmaW5lIEk5MTVfVVNFUlBUUl9SRUFEX09OTFkgMHgxCj4g LSNkZWZpbmUgSTkxNV9VU0VSUFRSX1VOU1lOQ0hST05JWkVEIDB4ODAwMDAwMDAKPiArI2RlZmlu ZSBJOTE1X1VTRVJQVFJfUkVBRF9PTkxZCQkweDEKPiArI2RlZmluZSBJOTE1X1VTRVJQVFJfUFJP QkUJCTB4Mgo+ICsjZGVmaW5lIEk5MTVfVVNFUlBUUl9VTlNZTkNIUk9OSVpFRAkweDgwMDAwMDAw Cj4gICAJLyoqCj4gICAJICogUmV0dXJuZWQgaGFuZGxlIGZvciB0aGUgb2JqZWN0Lgo+ICAgCSAq Cj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=