From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75418CA1005 for ; Tue, 2 Sep 2025 10:34:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 2148060034; Tue, 2 Sep 2025 10:34:11 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 84kep4RW0lV1; Tue, 2 Sep 2025 10:34:10 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org A0EE860BC8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1756809250; bh=B5dadqOPXnawLXbOXYYjUzwsybHxfQkh6+VqxS9pnBQ=; h=Date:To:Cc:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=i7cwh6QbeGtR+A+OQP79LENkjCJ18L9kZHpNUOJgvfbN0UHmtYNjkNLTF7DwccNy+ VHluhIPsVBvpl+JWPtBiA3ewKj3blQ/zwTKYeWLzOHiO7SdExZjkNNPW+Zoid7619h FiGGjvEgoTdUK/aTRe8vBfzb280dYVJQXt4cfLbvMF3R5dD5X9/42GhQq3GHV8YG+V WeN+jocKmeo6Uow9I4DfQ26cbVwRb9ydVrjFSmDiQpX5ebRK4t+XjbZsgzRVRUYPyX M/xW20iXNpKSpq8NFVXj+Gd9K8DBcRfDTM3BOjAuh+XukOXgNRI6RO1WlVB3qej5qw /2WIAcc5cTUsg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id A0EE860BC8; Tue, 2 Sep 2025 10:34:10 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists1.osuosl.org (Postfix) with ESMTP id D9A76439 for ; Tue, 2 Sep 2025 10:34:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id C410660DA2 for ; Tue, 2 Sep 2025 10:34:08 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id pCaEjPsXVJu9 for ; Tue, 2 Sep 2025 10:34:08 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2001:41d0:1004:224b::b3; helo=out-179.mta0.migadu.com; envelope-from=vadim.fedorenko@linux.dev; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org BDF4C60BEC DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org BDF4C60BEC Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [IPv6:2001:41d0:1004:224b::b3]) by smtp3.osuosl.org (Postfix) with ESMTPS id BDF4C60BEC for ; Tue, 2 Sep 2025 10:34:07 +0000 (UTC) Message-ID: Date: Tue, 2 Sep 2025 11:34:00 +0100 MIME-Version: 1.0 To: Brahmajit Das Cc: andrew+netdev@lunn.ch, anthony.l.nguyen@intel.com, davem@davemloft.net, intel-wired-lan@lists.osuosl.org, kuba@kernel.org, netdev@vger.kernel.org, przemyslaw.kitszel@intel.com References: <20250902072422.603237-1-listout@listout.xyz> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20250902072422.603237-1-listout@listout.xyz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1756809243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B5dadqOPXnawLXbOXYYjUzwsybHxfQkh6+VqxS9pnBQ=; b=TEhXgNd/20zf4/RnqZqmSxfPjz8bsRHnAEQXdruje2qZhpH25fL0rRpMc/fFHJYhqTyWIo 9HJxvGQrJrOQxv+BkJlIUGpwCI09VVa5t/RgAIH1Uyon/zcxRe0zChuBIroTerhE6o2WZx OEB05JZua5lQdVYhOdImktPN5ljIBlU= X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=none dis=none) header.from=linux.dev X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=TEhXgNd/ Subject: Re: [Intel-wired-lan] [PATCH v2] net: intel: fm10k: Fix parameter idx set but not used X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 02/09/2025 08:24, Brahmajit Das wrote: > Variable idx is set in the loop, but is never used resulting in dead > code. Building with GCC 16, which enables > -Werror=unused-but-set-parameter= by default results in build error. > This patch removes the idx parameter, since all the callers of the > fm10k_unbind_hw_stats_q as 0 as idx anyways. > > Suggested-by: Vadim Fedorenko > Signed-off-by: Brahmajit Das > --- > changes in v2: > - Removed the idx parameter, since all callers of > fm10k_unbind_hw_stats_q passes idx as 0 anyways. Just a reminder that you shouldn't send another version of the patch as a reply to the previous version. And you have to wait for at least 24h before sending next version to let other reviewers look at the code. Current submission looks OK in patchwork, so no action is needed from you right now. Thanks, Vadim From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 492836FC5 for ; Tue, 2 Sep 2025 10:34:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756809248; cv=none; b=Ky3mBablpBSd/Ay5qMUM8x4BP14RfgXBpIV74yYauLPmnwIgSjYSFXCDjHwGpvwgU3d76Ca/ygf+hBA8dKGbFphGPIcyf3hpDyMZbGR1eAJg5dUBTJmRh0sIqBuQVmjx1WIlGoj+gwYBr1cpqlUQVhXkB7IHlBTHGor6KOMTFr0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756809248; c=relaxed/simple; bh=RiIQMyTtZtlLSv652vXkmVhDFhCvj54CnNuvyOi4keU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hlwvzNOd/3F55k6WeoyvcWBZospVpG8aZj+5psDEkO4NaaXpMntS59JT/PlyfxmZ7UV/y30LQdmyMXci/KINOjwREaRndxmznni4QIAGLk6yLhhEGfBg8Xa+taC0Mu9A/XjA3WgMvCho+sy8KMZBul07pIsuKiBrpaI+bL4Nnw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=TEhXgNd/; arc=none smtp.client-ip=91.218.175.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="TEhXgNd/" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1756809243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B5dadqOPXnawLXbOXYYjUzwsybHxfQkh6+VqxS9pnBQ=; b=TEhXgNd/20zf4/RnqZqmSxfPjz8bsRHnAEQXdruje2qZhpH25fL0rRpMc/fFHJYhqTyWIo 9HJxvGQrJrOQxv+BkJlIUGpwCI09VVa5t/RgAIH1Uyon/zcxRe0zChuBIroTerhE6o2WZx OEB05JZua5lQdVYhOdImktPN5ljIBlU= Date: Tue, 2 Sep 2025 11:34:00 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v2] net: intel: fm10k: Fix parameter idx set but not used To: Brahmajit Das Cc: andrew+netdev@lunn.ch, anthony.l.nguyen@intel.com, davem@davemloft.net, intel-wired-lan@lists.osuosl.org, kuba@kernel.org, netdev@vger.kernel.org, przemyslaw.kitszel@intel.com References: <20250902072422.603237-1-listout@listout.xyz> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20250902072422.603237-1-listout@listout.xyz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 02/09/2025 08:24, Brahmajit Das wrote: > Variable idx is set in the loop, but is never used resulting in dead > code. Building with GCC 16, which enables > -Werror=unused-but-set-parameter= by default results in build error. > This patch removes the idx parameter, since all the callers of the > fm10k_unbind_hw_stats_q as 0 as idx anyways. > > Suggested-by: Vadim Fedorenko > Signed-off-by: Brahmajit Das > --- > changes in v2: > - Removed the idx parameter, since all callers of > fm10k_unbind_hw_stats_q passes idx as 0 anyways. Just a reminder that you shouldn't send another version of the patch as a reply to the previous version. And you have to wait for at least 24h before sending next version to let other reviewers look at the code. Current submission looks OK in patchwork, so no action is needed from you right now. Thanks, Vadim