All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Linux PM <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Lukas Wunner <lukas@wunner.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] PM / runtime: Fix handling of suppliers with disabled runtime PM
Date: Mon, 4 Dec 2017 13:51:36 +0200	[thread overview]
Message-ID: <c704e4a3-7faf-d2fd-297e-4efcd604bd0f@intel.com> (raw)
In-Reply-To: <1532136.s6buYvDjaS@aspire.rjw.lan>

On 01/12/17 15:58, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Prevent rpm_get_suppliers() from returning an error code if runtime
> PM is disabled for one or more of the supplier devices it wants to
> runtime-resume, so as to make runtime PM work for devices with links
> to suppliers that don't use runtime PM (such links may be created
> during device enumeration even before it is known whether or not
> runtime PM will be enabled for the devices in question, for example).
> 
> Reported-by: Adrian Hunter <adrian.hunter@intel.com>
> Fixes: 21d5c57b3726 (PM / runtime: Use device links)
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Tested-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/base/power/runtime.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Index: linux-pm/drivers/base/power/runtime.c
> ===================================================================
> --- linux-pm.orig/drivers/base/power/runtime.c
> +++ linux-pm/drivers/base/power/runtime.c
> @@ -276,7 +276,8 @@ static int rpm_get_suppliers(struct devi
>  			continue;
>  
>  		retval = pm_runtime_get_sync(link->supplier);
> -		if (retval < 0) {
> +		/* Ignore suppliers with disabled runtime PM. */
> +		if (retval < 0 && retval != -EACCES) {
>  			pm_runtime_put_noidle(link->supplier);
>  			return retval;
>  		}
> 
> 

  parent reply	other threads:[~2017-12-04 11:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01 13:58 [PATCH] PM / runtime: Fix handling of suppliers with disabled runtime PM Rafael J. Wysocki
2017-12-01 14:18 ` Lukas Wunner
2017-12-01 14:29   ` Rafael J. Wysocki
2017-12-01 14:34   ` Rafael J. Wysocki
2017-12-04 11:51 ` Adrian Hunter [this message]
2017-12-07 19:48 ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c704e4a3-7faf-d2fd-297e-4efcd604bd0f@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.