Re: [PATCH 2/5] drm/amdgpu/sdma: Remove unimplemented soft_reset() for SDMA and SI DMA

["Lazar, Lijo" <lijo.lazar@amd.com>]

On 28-Aug-26 5:37 PM, Timur Kristóf wrote:
> These functions are not called from anywhere
> and don't do anything. Let's delete them.
> 
> Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>

Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>

Thanks,
Lijo

> ---
>   drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c   | 8 --------
>   drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 8 --------
>   drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c   | 8 --------
>   drivers/gpu/drm/amd/amdgpu/si_dma.c      | 7 -------
>   4 files changed, 31 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> index a0f19f7b39e6..bf71f99f7307 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> @@ -2046,13 +2046,6 @@ static int sdma_v4_0_wait_for_idle(struct amdgpu_ip_block *ip_block)
>   	return -ETIMEDOUT;
>   }
>   
> -static int sdma_v4_0_soft_reset(struct amdgpu_ip_block *ip_block)
> -{
> -	/* todo */
> -
> -	return 0;
> -}
> -
>   static int sdma_v4_0_set_trap_irq_state(struct amdgpu_device *adev,
>   					struct amdgpu_irq_src *source,
>   					unsigned type,
> @@ -2398,7 +2391,6 @@ const struct amd_ip_funcs sdma_v4_0_ip_funcs = {
>   	.suspend = sdma_v4_0_suspend,
>   	.resume = sdma_v4_0_resume,
>   	.wait_for_idle = sdma_v4_0_wait_for_idle,
> -	.soft_reset = sdma_v4_0_soft_reset,
>   	.set_clockgating_state = sdma_v4_0_set_clockgating_state,
>   	.set_powergating_state = sdma_v4_0_set_powergating_state,
>   	.get_clockgating_state = sdma_v4_0_get_clockgating_state,
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c
> index 1a2810b6f27c..72ea9db939b4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c
> @@ -1646,13 +1646,6 @@ static int sdma_v4_4_2_wait_for_idle(struct amdgpu_ip_block *ip_block)
>   	return -ETIMEDOUT;
>   }
>   
> -static int sdma_v4_4_2_soft_reset(struct amdgpu_ip_block *ip_block)
> -{
> -	/* todo */
> -
> -	return 0;
> -}
> -
>   static bool sdma_v4_4_2_is_queue_selected(struct amdgpu_device *adev, uint32_t instance_id, bool is_page_queue)
>   {
>   	uint32_t reg_offset = is_page_queue ? regSDMA_PAGE_CONTEXT_STATUS : regSDMA_GFX_CONTEXT_STATUS;
> @@ -2104,7 +2097,6 @@ const struct amd_ip_funcs sdma_v4_4_2_ip_funcs = {
>   	.suspend = sdma_v4_4_2_suspend,
>   	.resume = sdma_v4_4_2_resume,
>   	.wait_for_idle = sdma_v4_4_2_wait_for_idle,
> -	.soft_reset = sdma_v4_4_2_soft_reset,
>   	.set_clockgating_state = sdma_v4_4_2_set_clockgating_state,
>   	.set_powergating_state = sdma_v4_4_2_set_powergating_state,
>   	.get_clockgating_state = sdma_v4_4_2_get_clockgating_state,
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c
> index 1a022a251011..0da54c335822 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c
> @@ -1518,13 +1518,6 @@ static int sdma_v5_0_wait_for_idle(struct amdgpu_ip_block *ip_block)
>   	return -ETIMEDOUT;
>   }
>   
> -static int sdma_v5_0_soft_reset(struct amdgpu_ip_block *ip_block)
> -{
> -	/* todo */
> -
> -	return 0;
> -}
> -
>   static int sdma_v5_0_reset_queue(struct amdgpu_ring *ring,
>   				 unsigned int vmid,
>   				 struct amdgpu_fence *timedout_fence)
> @@ -1902,7 +1895,6 @@ static const struct amd_ip_funcs sdma_v5_0_ip_funcs = {
>   	.suspend = sdma_v5_0_suspend,
>   	.resume = sdma_v5_0_resume,
>   	.wait_for_idle = sdma_v5_0_wait_for_idle,
> -	.soft_reset = sdma_v5_0_soft_reset,
>   	.set_clockgating_state = sdma_v5_0_set_clockgating_state,
>   	.set_powergating_state = sdma_v5_0_set_powergating_state,
>   	.get_clockgating_state = sdma_v5_0_get_clockgating_state,
> diff --git a/drivers/gpu/drm/amd/amdgpu/si_dma.c b/drivers/gpu/drm/amd/amdgpu/si_dma.c
> index edebd9109fd4..1df30779dcbe 100644
> --- a/drivers/gpu/drm/amd/amdgpu/si_dma.c
> +++ b/drivers/gpu/drm/amd/amdgpu/si_dma.c
> @@ -594,12 +594,6 @@ static int si_dma_wait_for_idle(struct amdgpu_ip_block *ip_block)
>   	return -ETIMEDOUT;
>   }
>   
> -static int si_dma_soft_reset(struct amdgpu_ip_block *ip_block)
> -{
> -	drm_info(adev_to_drm(ip_block->adev), "si_dma_soft_reset --- not implemented !!!!!!!\n");
> -	return 0;
> -}
> -
>   static int si_dma_set_trap_irq_state(struct amdgpu_device *adev,
>   					struct amdgpu_irq_src *src,
>   					unsigned type,
> @@ -726,7 +720,6 @@ static const struct amd_ip_funcs si_dma_ip_funcs = {
>   	.suspend = si_dma_suspend,
>   	.resume = si_dma_resume,
>   	.wait_for_idle = si_dma_wait_for_idle,
> -	.soft_reset = si_dma_soft_reset,
>   	.set_clockgating_state = si_dma_set_clockgating_state,
>   	.set_powergating_state = si_dma_set_powergating_state,
>   };