From: "Holalu Yogendra, Niranjan" <niranjan.hy@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: "linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ckeepax@opensource.cirrus.com" <ckeepax@opensource.cirrus.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"tiwai@suse.com" <tiwai@suse.com>,
"cezary.rojewski@intel.com" <cezary.rojewski@intel.com>,
"peter.ujfalusi@linux.intel.com" <peter.ujfalusi@linux.intel.com>,
"yung-chuan.liao@linux.intel.com"
<yung-chuan.liao@linux.intel.com>,
"kai.vehmanen@linux.intel.com" <kai.vehmanen@linux.intel.com>,
"pierre-louis.bossart@linux.dev" <pierre-louis.bossart@linux.dev>,
"Xu, Baojun" <baojun.xu@ti.com>,
"Ding, Shenghao" <shenghao-ding@ti.com>,
"Kasargod, Sandeep" <sandeepk@ti.com>,
"Hampiholi, Vallabha" <v-hampiholi@ti.com>
Subject: Re: [PATCH v1 1/2] ASoC: tac5xx2-sdw: update default regmap registers
Date: Thu, 20 Aug 2026 05:06:46 +0000 [thread overview]
Message-ID: <c72295dee2c045d9a230096cac1f0b01@ti.com> (raw)
In-Reply-To: <b714ed66-e722-461b-8cce-8535a14acc75@sirena.org.uk>
> On 19:17-20260819, Mark Brown wrote:
> Subject: Re: [PATCH v1 1/2] ASoC: tac5xx2-sdw: update default regmap registers
>
> > On Wed, Aug 19, 2026 at 11:04:26AM +0530, Niranjan H Y wrote:
>
> > - REG_SEQ0(SDW_SDCA_CTL(TAC_FUNCTION_ID_SA, TAC_SDCA_ENT_FU23,
> > - TAC_SDCA_CHANNEL_GAIN, TAC_CHANNEL_LEFT), 0),
> > - REG_SEQ0(SDW_SDCA_CTL(TAC_FUNCTION_ID_SA, TAC_SDCA_ENT_FU23,
> > - TAC_SDCA_CHANNEL_GAIN, TAC_CHANNEL_RIGHT), 0),
>
> The new macros use _CHANEL_VOLUME and _MASTER_GAIN, there's none using _CHANNEL_GAIN?
This was intentional to drop CHANNEL_GAIN as it is found to be not required for FU23.
I think I will add cleaner fix in next patch. What we need really are
#define TAC_SDCA_MASTER_GAIN 0x0B ( should be probably renamed to *_CHANNEL_GAIN )
#define TAC_SDCA_CHANNEL_VOLUME 0x02
And need to drop the duplicate macro
#define TAC_SDCA_CHANNEL_GAIN 0x02
Regards
Niranjan
prev parent reply other threads:[~2026-08-20 5:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 5:34 [PATCH v1 1/2] ASoC: tac5xx2-sdw: update default regmap registers Niranjan H Y
2026-08-19 5:34 ` [PATCH v1 2/2] ASoC: sdw_utils: add spk component string for tac5xx2 family Niranjan H Y
2026-08-19 13:50 ` Mark Brown
2026-08-19 13:46 ` [PATCH v1 1/2] ASoC: tac5xx2-sdw: update default regmap registers Mark Brown
2026-08-20 5:06 ` Holalu Yogendra, Niranjan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c72295dee2c045d9a230096cac1f0b01@ti.com \
--to=niranjan.hy@ti.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=sandeepk@ti.com \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.com \
--cc=v-hampiholi@ti.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.