From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BEA6408014 for ; Fri, 10 Jul 2026 12:20:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783686041; cv=none; b=VP+2Y/GdTF4GY5JhbThLqxk0seMC/AW+wzjFPuSWeFUeKqhQmFgx2olXCKxOCQWqD0pKLZq7RBZtnD+MEw9IFi2Y127FQsi5N2IOBLaWlIZpqWo+r3urt0ORBvp5u4U87s8jZcXhzWA5cszoqYxeO1i2UnifzTQYM2i5CnFCGBw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783686041; c=relaxed/simple; bh=uQtlFmlEDrsnmnfiKvO/WS+vVaEjJppi7RQvR+UUIdc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cFXJWhF03xdshRnUxVUL/SK7JdsZfcOsI0JSj4FprxP/FrsnH7PEYE68XJZ+GYsN1lnH4ATPFcD8JbVTxZy5p10weMONUXG5OdETBlfpT9ZduEAN+Dcs02r+zJE12lBLyY4MFZAxUXDBwFDTdmYMqXJuPPc5WaKIUJIba1LGcZA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YQiWD8e7; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YQiWD8e7" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-493c52cde9eso7310895e9.3 for ; Fri, 10 Jul 2026 05:20:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783686039; x=1784290839; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=n3zreGUqgwkkgdfOKXxPfkgWWWCEAQ09f5w1+bh6RDY=; b=YQiWD8e7bRBFjwAwYBI3n+zrgtlTDhnQXNSVe0D7toJbhg8muTHHx6Hdhmev7OO7KG AeAfeYpcgjrID5OxcmdqXcIyE3TrdNmegxZK0ThCS5PKfOal2N0PB+w4Fu6f3/jiNBZg baeUDMdsCFsGRS0tghpW9+sLSGirFPXdtkBrfNw6GjApqDNkE1wNpWxl4jKfjXCFpAQ+ peHewx+uuxU6tNK3+D9sY/eNgMpuciOlFfbVQpE8YPaMxD79mJixU0D9k6UF9Nc0+1ra k0SgWKm1GqJbqbNp0IXVwVsk4sAThyGigQvFEMjKUXo9hHkmSPbCOOC9i/RcTPB+gICh f3nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783686039; x=1784290839; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=n3zreGUqgwkkgdfOKXxPfkgWWWCEAQ09f5w1+bh6RDY=; b=PfXoZKKHjdqxGAfIUIICVIsJEzly2pGMYXBC0ivKj+m6upsHwrFlGhXePTAgZA+o5i 0OQyD5TSmPQ3gTiit9Kxx0zvZMhLhr0Ot8AjhvsOHYotZ25PoOG6aGFbA5riHoLxQ4Wp It4SrTZzSBshD2AGUPF4lQ7vWiMzMe/1lBoLbIwD7gCbdfBE+p2jqNDIUvvswzU6rvRB ru3VoybBzXbDWdGjvYQmEWm3d+s13ciGxwSPX3uW7odXkWdHkMFXD3zDjotji2HAqtPH Hrk1ZDO4SHy8A/DFEMI01xbV7wo/L81htk5C6gzyfQGBUQKffGUkTms7ajSWHDUAvpAj V1oA== X-Forwarded-Encrypted: i=1; AHgh+RpuDpkep4hVluebtFhj9asbSvNzROJ4hyMEMBuHBBKq8OfgjltwP3PZun3k4pZo7C828J5xfMWmMpba@vger.kernel.org X-Gm-Message-State: AOJu0YwXUYM8sPmXH0+P9Di24l42UHK1k6P6jaHjJSLK7TVKUAJk1Ar+ 4phmDbaBADikAzdyY+YbKxXsOvOUfDXDFAyuJlkuPqR/SQQoCZHkde4I X-Gm-Gg: AfdE7cksvu/yEJPD1Gwloawkt3aUWQxooxjrLwV1W/JLZThFGn+KWWqV3kxxRsPb2qW mrMr2Ob9pn+nCkCnEo48SRyMJwYqs4Dnt67s0g4n8l7xVRMhhWTxrpg9583EGA7i4ZavoVvzy8k euCVI62wJno6SKRFGqlYyAH4Z0CO/QlSRU36T1hoyjwNIW2wi5DmX0m1laiJuCwgtiYhZw3wYCe CH6LCQTFrL6A0CUQCtJInHjmJGMscVbjxo+167wRsI5pBsuosqbVvk2cMrPgR9r1SM9R8i+3IbP +QDSGxqVLSUN1172lyVfKBs9tlktMN7U8IgaptSHupmF/DrFJY0r/wqoprK4lMNKPSqc6JqRChW k4mRwA0GErIPiUV+wxKa4fi8YOohn4UXyH6IrBxTYWpJQqG7hOlJeBTaLPC7B4vMlUcKBKzsII7 Y62Ix29D0hXdLoY4AbAYzG/Qlzy9Q0vPI5IY9kMrnFHK/XBoryVR4778FeILBqn2/yT+KQpYHgV i4wSu8v X-Received: by 2002:a05:600c:34c1:b0:492:7083:e5a with SMTP id 5b1f17b1804b1-493ee0fe824mr67889685e9.31.1783686038394; Fri, 10 Jul 2026 05:20:38 -0700 (PDT) Received: from [10.128.11.240] (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb6f3dcdsm131002995e9.3.2026.07.10.05.20.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2026 05:20:37 -0700 (PDT) Sender: Julian Braha Message-ID: Date: Fri, 10 Jul 2026 13:20:36 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] ASoC: codecs: wcd9378: add TX/capture codec driver To: Jorijn van der Graaf , Mark Brown Cc: Srinivas Kandagatla , Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Luca Weiss , Conor Dooley , Jaroslav Kysela , Takashi Iwai , Mohammad Rafi Shaik , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260706192229.144137-1-jorijnvdgraaf@catcrafts.net> <20260706192229.144137-4-jorijnvdgraaf@catcrafts.net> Content-Language: en-US From: Julian Braha In-Reply-To: <20260706192229.144137-4-jorijnvdgraaf@catcrafts.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Jorijn, On 7/6/26 20:22, Jorijn van der Graaf wrote: > +config SND_SOC_WCD9378 > + depends on SND_SOC_WCD9378_SDW > + tristate > + depends on SOUNDWIRE || !SOUNDWIRE > + select SND_SOC_WCD_COMMON The preferred style for this is 'depends on SOUNDWIRE if SOUNDWIRE' since 'depends on X if Y' was added recently. Also see the kconfig docs on "Optional dependencies". > +config SND_SOC_WCD9378_SDW > + tristate "WCD9378 Codec - SDW" > + select SND_SOC_WCD9378 > + depends on SOUNDWIRE > + select REGMAP_SOUNDWIRE Another kconfig style nitpick: could you organize the attributes? E.g. keep the selects together, and keep the dependencies together? - Julian Braha