All of lore.kernel.org
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH] linux-user: Add missing /proc/cpuinfo fields for sparc
Date: Thu, 9 Jan 2025 03:33:44 +0100	[thread overview]
Message-ID: <c76fa107-1ed5-4247-9745-65c7ae5d6061@gmx.de> (raw)
In-Reply-To: <787ed640-60eb-4466-ba11-0ac9c9cca3c0@linaro.org>

On 1/9/25 01:40, Richard Henderson wrote:
> On 1/8/25 15:21, Helge Deller wrote:
>> My suggestion:
>> I change my patch to just add:
>>
>> +    dprintf(fd, "ncpus probed\t: %d\n", num_cpus);
>> +    dprintf(fd, "ncpus active\t: %d\n", num_cpus);
>> +    dprintf(fd, "State:\n");
>> +    for (i = 0; i < num_cpus; i++) {
>> +        dprintf(fd, "CPU%d:\t\t: online\n", i);
>> +    }
>>
>> Those were the lines which I was mostly interested in since
>> I found one application which wants to parse /proc/cpuinfo
>> to get number of CPUs in system.
>> Would that be acceptable (for now) ?
>
> Yes, thanks.  If only linux had added a prctl or something to not require parsing...

True, but most people forget about glibc providing sysconf(_SC_NPROCESSORS_ONLN)
as portable function so that people do not need to implement parsing
/proc/cpuinfo for each architecture themselves.

I'll respin the patch.

Helge


      reply	other threads:[~2025-01-09  2:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-08 21:16 [PATCH] linux-user: Add missing /proc/cpuinfo fields for sparc Helge Deller
2025-01-08 22:59 ` Richard Henderson
2025-01-08 23:21   ` Helge Deller
2025-01-09  0:40     ` Richard Henderson
2025-01-09  2:33       ` Helge Deller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c76fa107-1ed5-4247-9745-65c7ae5d6061@gmx.de \
    --to=deller@gmx.de \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.