From: poza@codeaurora.org
To: Sinan Kaya <okaya@codeaurora.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Dongdong Liu <liudongdong3@huawei.com>,
Keith Busch <keith.busch@intel.com>, Wei Zhang <wzhang@fb.com>,
Timur Tabi <timur@codeaurora.org>
Subject: Re: [PATCH v5 3/4] PCI/DPC: Unify and plumb error handling into DPC
Date: Thu, 18 Jan 2018 10:47:32 +0530 [thread overview]
Message-ID: <c77a3302e34d55d557404d7bdc6892fc@codeaurora.org> (raw)
In-Reply-To: <733abfcb-5b31-7394-ab62-19a0888d71c2@codeaurora.org>
On 2018-01-17 22:16, Sinan Kaya wrote:
> On 1/17/2018 5:37 AM, Oza Pawandeep wrote:
>> +++ b/include/linux/dpc.h
>> @@ -0,0 +1,9 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +
>> +#ifndef _DPC_H_
>> +#define _DPC_H_
>> +
>> +#define DPC_FATAL 4
>> +
>> +#endif //_DPC_H_
>> +
>
> can you keep this in drivers/pci.h and get rid of this file?
I thought about this, but if I keep it in drivers/pci.h,
then AER's defines have to be in that as well. (for unification)
and then all the dependent files who are using AER_FATAL such as
drivers/acpi/apei/ghees.c
have to go on including this drivers file which is odd way of doing it.
So I am not very sure about this....since AER_FATAL are in aer.h, I have
made dpc.h
Regards,
Oza.
next prev parent reply other threads:[~2018-01-18 5:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 10:37 [PATCH v5 0/4] Address error and recovery for AER and DPC Oza Pawandeep
2018-01-17 10:37 ` [PATCH v5 1/4] PCI/AER: Rename error recovery to generic pci naming Oza Pawandeep
2018-01-17 10:37 ` [PATCH v5 2/4] PCI/AER: factor out error reporting from AER Oza Pawandeep
2018-01-17 10:37 ` [PATCH v5 3/4] PCI/DPC: Unify and plumb error handling into DPC Oza Pawandeep
2018-01-17 16:45 ` Sinan Kaya
2018-01-18 5:22 ` poza
2018-01-18 6:04 ` poza
2018-01-17 16:46 ` Sinan Kaya
2018-01-18 5:17 ` poza [this message]
2018-01-18 5:57 ` poza
2018-01-18 16:31 ` Sinan Kaya
2018-01-18 18:00 ` poza
2018-01-18 18:03 ` Sinan Kaya
2018-01-19 4:23 ` poza
2018-01-19 4:44 ` Sinan Kaya
2018-01-19 9:03 ` poza
2018-01-17 10:37 ` [PATCH v5 4/4] PCI/DPC: Enumerate the devices after DPC trigger event Oza Pawandeep
2018-01-17 16:27 ` Sinan Kaya
2018-01-18 2:56 ` Keith Busch
2018-01-18 5:32 ` poza
2018-01-18 16:35 ` Sinan Kaya
2018-01-19 1:43 ` Keith Busch
2018-01-19 4:21 ` poza
2018-01-18 5:26 ` poza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c77a3302e34d55d557404d7bdc6892fc@codeaurora.org \
--to=poza@codeaurora.org \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=keith.busch@intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=okaya@codeaurora.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
--cc=timur@codeaurora.org \
--cc=wzhang@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.