From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06E4FC433F5 for ; Fri, 25 Feb 2022 13:35:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 54C674B9EB; Fri, 25 Feb 2022 08:35:42 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9+ohZ5gIRwjn; Fri, 25 Feb 2022 08:35:38 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A319F4BA18; Fri, 25 Feb 2022 08:35:38 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 10E634BA18 for ; Fri, 25 Feb 2022 08:35:37 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SMDBTB-6yoLh for ; Fri, 25 Feb 2022 08:35:35 -0500 (EST) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 6DC7B4BA11 for ; Fri, 25 Feb 2022 08:35:35 -0500 (EST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 80ED8B830C6; Fri, 25 Feb 2022 13:35:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F92BC340E7; Fri, 25 Feb 2022 13:35:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645796132; bh=3ru70PNu1fPmDnbfvhLX0F5rEPgIzqF/E/iw7W1PbzQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aUrsnQPrVv9inRpfjCjXSAiIPH/XQ6VpylpiNO8BxEBCyKHiyPpSxVUXFCE1yD74S Laoyt2Tf3xDNWAuvR54FqzSft1MMmMRe4kOvWh+pdcLfNoLRLqbwQJMi7/ZdsC5920 +H1Dq1pLGlsGZ9TFe2rTJV4ix2Nqn9FFoqpZNtB1F6Y66cBkklp2H3dB0HKQjgSboh JZInjAQt74SNbsIzW3nOR7ugyURlirZ/mJ7bAX7XFfh011o8eX/JGFaWHyAh/Lona1 s0QR+VBQVnbdp4ZC4sBJy3j56M2l4pC4eOeXSWzttLA7ELa1EkIlAbuk8P0vig+H8W PFhnSi31z2HfQ== Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nNakr-00AXGF-JE; Fri, 25 Feb 2022 13:35:29 +0000 MIME-Version: 1.0 Date: Fri, 25 Feb 2022 13:35:29 +0000 From: Marc Zyngier To: cgel.zte@gmail.com Subject: Re: [PATCH] KVM: arm64: Remove unneeded semicolon In-Reply-To: <20220223092750.1934130-1-deng.changcheng@zte.com.cn> References: <20220223092750.1934130-1-deng.changcheng@zte.com.cn> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: cgel.zte@gmail.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, deng.changcheng@zte.com.cn, zealci@zte.com.cn X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: will@kernel.org, catalin.marinas@arm.com, Zeal Robot , linux-kernel@vger.kernel.org, Changcheng Deng , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 2022-02-23 09:27, cgel.zte@gmail.com wrote: > From: Changcheng Deng > > Fix the following coccicheck review: > ./arch/arm64/kvm/psci.c: 379: 3-4: Unneeded semicolon > > Reported-by: Zeal Robot > Signed-off-by: Changcheng Deng > --- > arch/arm64/kvm/psci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/psci.c b/arch/arm64/kvm/psci.c > index 0a00ef250725..3b16dae4ab3d 100644 > --- a/arch/arm64/kvm/psci.c > +++ b/arch/arm64/kvm/psci.c > @@ -376,7 +376,7 @@ static int kvm_psci_1_x_call(struct kvm_vcpu > *vcpu, u32 minor) > ret = 0; > } > break; > - }; > + } > fallthrough; > default: > return kvm_psci_0_2_call(vcpu); Thanks for that. You may want to check why your script didn't pick this particular instance of the same defect: diff --git a/arch/arm64/kvm/psci.c b/arch/arm64/kvm/psci.c index b43adf7dc29f..0d48d1e7291d 100644 --- a/arch/arm64/kvm/psci.c +++ b/arch/arm64/kvm/psci.c @@ -438,7 +438,7 @@ int kvm_psci_call(struct kvm_vcpu *vcpu) return kvm_psci_0_1_call(vcpu); default: return -EINVAL; - }; + } } int kvm_arm_get_fw_num_regs(struct kvm_vcpu *vcpu) I'll squash it into you patch and push it into -next. Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3725C433EF for ; Fri, 25 Feb 2022 13:50:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lIaJuh1y/3sbOd3RDxWpL8WL1d8vGLSGWWo9hx/gRuA=; b=lEULaOhB+smTrn5PB5bUVdvWh/ zs7CjLFbbAb4Ne28etRjGVCrW91hTznj6p1O8w9FkBMrhlL/3EI5LYl0SThQPQSZ8KiHEWQc77pib h/rVVXzeXmAP6f1wbEhcxP+j6JkyJSun1kaU48Fcian4NvfZ+8rNYfIU3ARcnYlc5osT3dZrmG0Oq HWg0DOVJBBpqYnhzS15q7O10+Cod6h64yXmrr6kJTqZ9oy+MRXS8OCLjde9+2TzICkU+clKF4fKe6 Rp6dRM4/ooB5etaCN2hezsADLtcr++K5f+qdq+qBHu82UuLHzaFhC96at63HwsU2aLOfOfNYm63xi dZz9Mn7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNaxQ-005E9f-FY; Fri, 25 Feb 2022 13:48:30 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNakx-0059Dy-5Y for linux-arm-kernel@lists.infradead.org; Fri, 25 Feb 2022 13:35:36 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 80ED8B830C6; Fri, 25 Feb 2022 13:35:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F92BC340E7; Fri, 25 Feb 2022 13:35:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645796132; bh=3ru70PNu1fPmDnbfvhLX0F5rEPgIzqF/E/iw7W1PbzQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aUrsnQPrVv9inRpfjCjXSAiIPH/XQ6VpylpiNO8BxEBCyKHiyPpSxVUXFCE1yD74S Laoyt2Tf3xDNWAuvR54FqzSft1MMmMRe4kOvWh+pdcLfNoLRLqbwQJMi7/ZdsC5920 +H1Dq1pLGlsGZ9TFe2rTJV4ix2Nqn9FFoqpZNtB1F6Y66cBkklp2H3dB0HKQjgSboh JZInjAQt74SNbsIzW3nOR7ugyURlirZ/mJ7bAX7XFfh011o8eX/JGFaWHyAh/Lona1 s0QR+VBQVnbdp4ZC4sBJy3j56M2l4pC4eOeXSWzttLA7ELa1EkIlAbuk8P0vig+H8W PFhnSi31z2HfQ== Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nNakr-00AXGF-JE; Fri, 25 Feb 2022 13:35:29 +0000 MIME-Version: 1.0 Date: Fri, 25 Feb 2022 13:35:29 +0000 From: Marc Zyngier To: cgel.zte@gmail.com Cc: james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, Changcheng Deng , Zeal Robot , will@kernel.org Subject: Re: [PATCH] KVM: arm64: Remove unneeded semicolon In-Reply-To: <20220223092750.1934130-1-deng.changcheng@zte.com.cn> References: <20220223092750.1934130-1-deng.changcheng@zte.com.cn> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: cgel.zte@gmail.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, deng.changcheng@zte.com.cn, zealci@zte.com.cn X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220225_053535_467804_6252742E X-CRM114-Status: GOOD ( 18.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-02-23 09:27, cgel.zte@gmail.com wrote: > From: Changcheng Deng > > Fix the following coccicheck review: > ./arch/arm64/kvm/psci.c: 379: 3-4: Unneeded semicolon > > Reported-by: Zeal Robot > Signed-off-by: Changcheng Deng > --- > arch/arm64/kvm/psci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/psci.c b/arch/arm64/kvm/psci.c > index 0a00ef250725..3b16dae4ab3d 100644 > --- a/arch/arm64/kvm/psci.c > +++ b/arch/arm64/kvm/psci.c > @@ -376,7 +376,7 @@ static int kvm_psci_1_x_call(struct kvm_vcpu > *vcpu, u32 minor) > ret = 0; > } > break; > - }; > + } > fallthrough; > default: > return kvm_psci_0_2_call(vcpu); Thanks for that. You may want to check why your script didn't pick this particular instance of the same defect: diff --git a/arch/arm64/kvm/psci.c b/arch/arm64/kvm/psci.c index b43adf7dc29f..0d48d1e7291d 100644 --- a/arch/arm64/kvm/psci.c +++ b/arch/arm64/kvm/psci.c @@ -438,7 +438,7 @@ int kvm_psci_call(struct kvm_vcpu *vcpu) return kvm_psci_0_1_call(vcpu); default: return -EINVAL; - }; + } } int kvm_arm_get_fw_num_regs(struct kvm_vcpu *vcpu) I'll squash it into you patch and push it into -next. Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8942DC433EF for ; Fri, 25 Feb 2022 13:35:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241487AbiBYNgJ (ORCPT ); Fri, 25 Feb 2022 08:36:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239392AbiBYNgG (ORCPT ); Fri, 25 Feb 2022 08:36:06 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB81F1DB3D3 for ; Fri, 25 Feb 2022 05:35:34 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 75EA1B830B9 for ; Fri, 25 Feb 2022 13:35:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F92BC340E7; Fri, 25 Feb 2022 13:35:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645796132; bh=3ru70PNu1fPmDnbfvhLX0F5rEPgIzqF/E/iw7W1PbzQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aUrsnQPrVv9inRpfjCjXSAiIPH/XQ6VpylpiNO8BxEBCyKHiyPpSxVUXFCE1yD74S Laoyt2Tf3xDNWAuvR54FqzSft1MMmMRe4kOvWh+pdcLfNoLRLqbwQJMi7/ZdsC5920 +H1Dq1pLGlsGZ9TFe2rTJV4ix2Nqn9FFoqpZNtB1F6Y66cBkklp2H3dB0HKQjgSboh JZInjAQt74SNbsIzW3nOR7ugyURlirZ/mJ7bAX7XFfh011o8eX/JGFaWHyAh/Lona1 s0QR+VBQVnbdp4ZC4sBJy3j56M2l4pC4eOeXSWzttLA7ELa1EkIlAbuk8P0vig+H8W PFhnSi31z2HfQ== Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nNakr-00AXGF-JE; Fri, 25 Feb 2022 13:35:29 +0000 MIME-Version: 1.0 Date: Fri, 25 Feb 2022 13:35:29 +0000 From: Marc Zyngier To: cgel.zte@gmail.com Cc: james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, Changcheng Deng , Zeal Robot , will@kernel.org Subject: Re: [PATCH] KVM: arm64: Remove unneeded semicolon In-Reply-To: <20220223092750.1934130-1-deng.changcheng@zte.com.cn> References: <20220223092750.1934130-1-deng.changcheng@zte.com.cn> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: maz@kernel.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: cgel.zte@gmail.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, deng.changcheng@zte.com.cn, zealci@zte.com.cn X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-02-23 09:27, cgel.zte@gmail.com wrote: > From: Changcheng Deng > > Fix the following coccicheck review: > ./arch/arm64/kvm/psci.c: 379: 3-4: Unneeded semicolon > > Reported-by: Zeal Robot > Signed-off-by: Changcheng Deng > --- > arch/arm64/kvm/psci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/psci.c b/arch/arm64/kvm/psci.c > index 0a00ef250725..3b16dae4ab3d 100644 > --- a/arch/arm64/kvm/psci.c > +++ b/arch/arm64/kvm/psci.c > @@ -376,7 +376,7 @@ static int kvm_psci_1_x_call(struct kvm_vcpu > *vcpu, u32 minor) > ret = 0; > } > break; > - }; > + } > fallthrough; > default: > return kvm_psci_0_2_call(vcpu); Thanks for that. You may want to check why your script didn't pick this particular instance of the same defect: diff --git a/arch/arm64/kvm/psci.c b/arch/arm64/kvm/psci.c index b43adf7dc29f..0d48d1e7291d 100644 --- a/arch/arm64/kvm/psci.c +++ b/arch/arm64/kvm/psci.c @@ -438,7 +438,7 @@ int kvm_psci_call(struct kvm_vcpu *vcpu) return kvm_psci_0_1_call(vcpu); default: return -EINVAL; - }; + } } int kvm_arm_get_fw_num_regs(struct kvm_vcpu *vcpu) I'll squash it into you patch and push it into -next. Thanks, M. -- Jazz is not dead. It just smells funny...