All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Tinguely <mark.tinguely@oracle.com>
To: Brian Foster <bfoster@redhat.com>, linux-xfs@vger.kernel.org
Subject: Re: [External] : [PATCH v3 3/4] xfs: calculate AGFL max to support multiple-alloc transactions
Date: Fri, 4 Sep 2026 08:55:05 -0500	[thread overview]
Message-ID: <c7986188-3680-46ad-84ed-ae45bb2cb3bb@oracle.com> (raw)
In-Reply-To: <20260902174025.284387-4-bfoster@redhat.com>

On 9/2/26 12:40 PM, Brian Foster wrote:
> Rework xfs_alloc_min_freelist() to return an (optional) max value
> along with the historical min freelist value. The max value
> includes an extra level in the btree based calculation to account
> for btree splits in the first allocation of a multi-alloc sequence.
> 
> This value reflects the worst case AGFL requirement that can be
> expected across multiple allocations within a single AG and single
> transaction. For example, consider the case of allocating an inode
> chunk and then an inobt block on inode record insertion.
> 
> While here, rename the need variable in xfs_alloc_fix_freelist() for
> clarity with upcoming changes.
> 
> Note that no callers calculate the max AGFL value as of yet. No
> functional changes in this patch.
> 
> Assisted-by: LLM
> Signed-off-by: Brian Foster <bfoster@redhat.com>
> ---
>   fs/xfs/libxfs/xfs_alloc.c  | 35 ++++++++++++++++++++++-------------
>   fs/xfs/libxfs/xfs_alloc.h  |  4 ++--
>   fs/xfs/libxfs/xfs_bmap.c   |  5 +++--
>   fs/xfs/libxfs/xfs_ialloc.c |  4 +++-
>   4 files changed, 30 insertions(+), 18 deletions(-)
> 
looks good

Reviewed-by: Mark Tinguely <mark.tinguely@oracle.com>

  reply	other threads:[~2026-09-04 13:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02 17:40 [PATCH v3 0/4] xfs: fix a couple sparse chunk alloc problems Brian Foster
2026-09-02 17:40 ` [PATCH v3 1/4] xfs: set minleft correctly for sparse chunk errortag allocation Brian Foster
2026-09-02 17:40 ` [PATCH v3 2/4] xfs: support additional levels in the agfl minimum calculation Brian Foster
2026-09-03 16:58   ` [External] : " Mark Tinguely
2026-09-02 17:40 ` [PATCH v3 3/4] xfs: calculate AGFL max to support multiple-alloc transactions Brian Foster
2026-09-04 13:55   ` Mark Tinguely [this message]
2026-09-02 17:40 ` [PATCH v3 4/4] xfs: incorporate increased AGFL min requirement for minleft allocs Brian Foster
2026-09-04 14:00   ` [External] : " Mark Tinguely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7986188-3680-46ad-84ed-ae45bb2cb3bb@oracle.com \
    --to=mark.tinguely@oracle.com \
    --cc=bfoster@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.