From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Anthony Perard <anthony.perard@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wl@xen.org>
Subject: [Xen-devel] [PATCH 4/5] libxl/PCI: pass correct "hotplug" argument to libxl__device_pci_setdefault()
Date: Tue, 18 Feb 2020 16:47:27 +0100 [thread overview]
Message-ID: <c7adfa84-2310-3d1d-a6db-574a10247380@suse.com> (raw)
In-Reply-To: <b5d94bd8-9a39-c88b-4c3c-f89e655f3abf@suse.com>
Uniformly passing "false" can't be right, but has been benign because of
the function not using this parameter.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/tools/libxl/libxl_pci.c
+++ b/tools/libxl/libxl_pci.c
@@ -1567,7 +1567,7 @@ void libxl__device_pci_add(libxl__egc *e
}
}
- rc = libxl__device_pci_setdefault(gc, domid, pcidev, false);
+ rc = libxl__device_pci_setdefault(gc, domid, pcidev, !starting);
if (rc) goto out;
if (pcidev->seize && !pciback_dev_is_assigned(gc, pcidev)) {
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-02-18 15:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 15:44 [Xen-devel] [PATCH 0/5] libxl/PCI: reserved device memory adjustments Jan Beulich
2020-02-18 15:46 ` [Xen-devel] [PATCH 1/5] libxl/PCI: honor multiple per-device reserved memory regions Jan Beulich
2020-02-20 10:35 ` Wei Liu
2020-02-18 15:46 ` [Xen-devel] [PATCH 2/5] libxl/PCI: establish per-device reserved memory policy earlier Jan Beulich
2020-02-20 11:38 ` Wei Liu
2020-02-18 15:47 ` [Xen-devel] [PATCH 3/5] libxl/PCI: make "rdm=" parsing comply with documentation Jan Beulich
2020-02-20 11:44 ` Wei Liu
2020-02-18 15:47 ` Jan Beulich [this message]
2020-02-20 11:41 ` [Xen-devel] [PATCH 4/5] libxl/PCI: pass correct "hotplug" argument to libxl__device_pci_setdefault() Wei Liu
2020-02-18 15:47 ` [Xen-devel] [PATCH 5/5] libxl/PCI: align reserved device memory boundary for HAP guests Jan Beulich
2020-02-20 11:43 ` Wei Liu
2020-02-20 11:45 ` Jan Beulich
2020-02-20 11:48 ` Wei Liu
2020-02-20 11:45 ` [Xen-devel] [PATCH 0/5] libxl/PCI: reserved device memory adjustments Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7adfa84-2310-3d1d-a6db-574a10247380@suse.com \
--to=jbeulich@suse.com \
--cc=anthony.perard@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.