From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7DD8CD1284 for ; Tue, 9 Apr 2024 12:56:35 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.702430.1097420 (Exim 4.92) (envelope-from ) id 1ruB1S-0002Sw-9w; Tue, 09 Apr 2024 12:56:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 702430.1097420; Tue, 09 Apr 2024 12:56:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ruB1S-0002Sp-6L; Tue, 09 Apr 2024 12:56:22 +0000 Received: by outflank-mailman (input) for mailman id 702430; Tue, 09 Apr 2024 12:56:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ruB1R-0002Sh-NI for xen-devel@lists.xenproject.org; Tue, 09 Apr 2024 12:56:21 +0000 Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [2607:f8b0:4864:20::72d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8ef2a5df-f670-11ee-94a3-07e782e9044d; Tue, 09 Apr 2024 14:56:19 +0200 (CEST) Received: by mail-qk1-x72d.google.com with SMTP id af79cd13be357-78d683c469dso136609985a.1 for ; Tue, 09 Apr 2024 05:56:19 -0700 (PDT) Received: from [10.80.67.139] (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id u14-20020a05620a0c4e00b0078d4732d92fsm4088189qki.115.2024.04.09.05.56.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Apr 2024 05:56:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ef2a5df-f670-11ee-94a3-07e782e9044d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1712667378; x=1713272178; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=HwogDxAhx9l+csggl/rwifRkAk67XvwgPWc+crWwtqQ=; b=TYSJUw3hJl4ekVYkrmXjj2p9ju0gRkb3wF5QQuWSjI07Qvaeez6dOnLYr3VOUZ8qqp BiKCla6j+AUIhYvpkJz4qIakxcHABpPQY0xgH2T98e0wizfBLwtDxENofqC7WLbUG956 cE70hbNO2QRRDiyvIknBeI0UOowYztz6/NGmY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712667378; x=1713272178; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HwogDxAhx9l+csggl/rwifRkAk67XvwgPWc+crWwtqQ=; b=iOBcKhNtMI+dGNFLZiVxZqoJ6cfts0IStec7UUHO1ayKu4oEBBXPAeHBlZMDapxZ+2 6GWwPgSnV/Nalds6CjOtIoXa3FM3/ymX9thqcl87dPH28UxloApbVYYse8rf5Yur0t2k k6onxo1A4I3e83awMYffj7N5a76eT+zz8wJg/2rVOqUvEhe5AM1PvtRuHEbI5hejCFLU K+TWJQPxh8WaCERTGs2TzxSdbsbsrxJ5gmS9SCrcDBplXSveKonAgV4lg2kUltKURrox nK0W0GpkB/SjpjB5b4hJbho+GJKfqvtvp1Mtpe3WT2YQxs/WsS9Xgi3YAYqm5wh//Qig FttA== X-Forwarded-Encrypted: i=1; AJvYcCXrsOmyZuu3DwqFGZT6EyZjITinw5oX3jxjVRaliOfTlPXQyH+fB9e8C/9ybA5gPLffeoeNViZU7tIdyDFNoXZPYMZJe6zQPmZyITxgRds= X-Gm-Message-State: AOJu0YytMjx0Iw47sa7I9AcPHKSZzpiIcVhZesK8TAZy3RGf2I3CbF+/ iht2GoTbI/PhMkrlg+TAZobsTzvic5DTi5JwzXb7V/lBL18m1NpL+EHwmeLzZAc= X-Google-Smtp-Source: AGHT+IFA2FmL1zKMeRVFM6zIR17pQl8pUIXqBuo14zsD9gI12PxoXoJIUogEOyua6ObghirZqPIqFQ== X-Received: by 2002:a05:620a:5207:b0:78b:c3a2:26c6 with SMTP id dc7-20020a05620a520700b0078bc3a226c6mr11137546qkb.21.1712667378525; Tue, 09 Apr 2024 05:56:18 -0700 (PDT) Message-ID: Date: Tue, 9 Apr 2024 13:56:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/alternatives: fix .init section reference in _apply_alternatives() To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Jan Beulich References: <20240409125046.60382-1-roger.pau@citrix.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <20240409125046.60382-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 09/04/2024 1:50 pm, Roger Pau Monne wrote: > The code in _apply_alternatives() will unconditionally attempt to read > __initdata_cf_clobber_{start,end} when called as part of applying alternatives > to a livepatch payload. When CET-IBT is active. In practice this narrows the impact to ADL/RPL and SPR/EMR. > That leads to a page-fault as > __initdata_cf_clobber_{start,end} living in .init section will have been > unmapped by the time a livepatch gets loaded. > > Fix by adding a check that limits the clobbering of endbr64 instructions to > boot time only. > > Fixes: 37ed5da851b8 ('x86/altcall: Optimise away endbr64 instruction where possible') > Signed-off-by: Roger Pau Monné Reviewed-by: Andrew Cooper In hindsight I really should have tried livepatching when I was doing the IBT work, but that was also done under an embargo deadline. I'm happy to tweak the commit message on commit.