From: Damien Le Moal <dlemoal@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Niklas Cassel <niklas.cassel@wdc.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the scsi-mkp tree
Date: Tue, 23 May 2023 15:38:16 +0900 [thread overview]
Message-ID: <c7e0574e-bfb2-fee7-2467-5f9cd8d335f5@kernel.org> (raw)
In-Reply-To: <20230523133833.64560bf3@canb.auug.org.au>
On 5/23/23 12:38, Stephen Rothwell wrote:
> Hi all,
>
> After merging the scsi-mkp tree, today's linux-next build (htmldocs)
> produced this warning:
>
> drivers/ata/libata-scsi.c:3864: warning: Function parameter or member 'spg' not described in 'ata_mselect_control'
>
> Introduced by commit
>
> df60f9c64576 ("scsi: ata: libata: Add ATA feature control sub-page translation")
>
Martin,
This is missing:
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 69fc0d2c2123..c676b1e9b6c9 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -3850,6 +3850,7 @@ static unsigned int ata_mselect_control_ata_feature(struct
ata_queued_cmd *qc,
/**
* ata_mselect_control - Simulate MODE SELECT for control page
* @qc: Storage for translated ATA taskfile
+ * @spg: sub-page of the control page
* @buf: input buffer
* @len: number of valid bytes in the input buffer
* @fp: out parameter for the failed field on error
Do you want me to send a fix patch or can you fold this in ?
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2023-05-23 6:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 3:38 linux-next: build warning after merge of the scsi-mkp tree Stephen Rothwell
2023-05-23 6:38 ` Damien Le Moal [this message]
2023-05-23 7:49 ` Damien Le Moal
-- strict thread matches above, loose matches on Subject: below --
2023-08-28 3:13 Stephen Rothwell
2023-07-24 4:04 Stephen Rothwell
2023-07-26 2:13 ` Martin K. Petersen
2021-10-18 20:41 Stephen Rothwell
2021-11-08 0:06 ` Stephen Rothwell
2021-11-08 14:36 ` James Bottomley
2020-03-02 2:35 Stephen Rothwell
2020-03-02 14:36 ` Brian King
2020-03-06 4:52 ` Stephen Rothwell
2020-03-06 15:30 ` Brian King
2018-12-20 6:34 Stephen Rothwell
2018-10-12 5:10 Stephen Rothwell
2018-07-11 4:17 Stephen Rothwell
2018-07-12 4:30 ` Stephen Rothwell
2018-07-12 6:10 ` Hannes Reinecke
2017-09-26 4:09 Stephen Rothwell
2017-09-27 3:27 ` Stephen Rothwell
2017-08-24 5:57 Stephen Rothwell
2017-08-24 5:59 ` Stephen Rothwell
2016-11-14 5:16 Stephen Rothwell
2016-11-14 12:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7e0574e-bfb2-fee7-2467-5f9cd8d335f5@kernel.org \
--to=dlemoal@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=niklas.cassel@wdc.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.