From: Chengming Zhou <chengming.zhou@linux.dev>
To: Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Yosry Ahmed <yosry.ahmed@linux.dev>,
Nhat Pham <nphamcs@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: zswap: delete unused acomp->is_sleepable
Date: Thu, 11 Dec 2025 16:13:47 +0800 [thread overview]
Message-ID: <c7eddfa9-9c43-4e17-aa5f-82cb82118cbf@linux.dev> (raw)
In-Reply-To: <20251211025645.820517-1-hannes@cmpxchg.org>
On 2025/12/11 10:56, Johannes Weiner wrote:
> This hasn't been used since 7d4c9629b74f ("mm: zswap: use object
> read/write APIs instead of object mapping APIs"). Drop it.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Reviewed-by: Chengming Zhou <chengming.zhou@linux.dev>
Thanks.
> ---
> mm/zswap.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/zswap.c b/mm/zswap.c
> index 5d0f8b13a958..84797ed4d3f5 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -141,7 +141,6 @@ struct crypto_acomp_ctx {
> struct crypto_wait wait;
> u8 *buffer;
> struct mutex mutex;
> - bool is_sleepable;
> };
>
> /*
> @@ -781,7 +780,6 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, struct hlist_node *node)
>
> acomp_ctx->buffer = buffer;
> acomp_ctx->acomp = acomp;
> - acomp_ctx->is_sleepable = acomp_is_async(acomp);
> acomp_ctx->req = req;
> mutex_unlock(&acomp_ctx->mutex);
> return 0;
next prev parent reply other threads:[~2025-12-11 8:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-11 2:56 [PATCH] mm: zswap: delete unused acomp->is_sleepable Johannes Weiner
2025-12-11 8:13 ` Chengming Zhou [this message]
2025-12-11 8:32 ` Anshuman Khandual
2025-12-11 17:11 ` Yosry Ahmed
2025-12-11 19:21 ` Yosry Ahmed
2025-12-11 22:37 ` Nhat Pham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7eddfa9-9c43-4e17-aa5f-82cb82118cbf@linux.dev \
--to=chengming.zhou@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=yosry.ahmed@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.