All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: Dibin Moolakadan Subrahmanian
	<dibin.moolakadan.subrahmanian@intel.com>,
	<intel-gfx@lists.freedesktop.org>,
	<intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH 1/2] drm/i915/display: Fix get_ana_cp_int_prop() argument type
Date: Tue, 27 May 2025 10:20:40 +0530	[thread overview]
Message-ID: <c808b60f-9517-4003-9d9a-8e092d474ebb@intel.com> (raw)
In-Reply-To: <20250513083803.2596286-2-dibin.moolakadan.subrahmanian@intel.com>


On 5/13/2025 2:08 PM, Dibin Moolakadan Subrahmanian wrote:
> Change get_ana_cp_int_prop() vco_clk argument type from u32 to u64.
> vco_clk is decalared as u64 in the caller and there are scearios in
> which vco_clk will exceed max u32.

Agree with the change, lets have this meld with the next patch.


Regards,

Ankit

>
> Signed-off-by: Dibin Moolakadan Subrahmanian <dibin.moolakadan.subrahmanian@intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.c b/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.c
> index c6321dafef4f..41c6c111af1d 100644
> --- a/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.c
> +++ b/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.c
> @@ -46,7 +46,7 @@ static s64 interp(s64 x, s64 x1, s64 x2, s64 y1, s64 y2)
>   	return (y1 + DIV_ROUND_UP_ULL(dydx * (x - x1), 100000));
>   }
>   
> -static void get_ana_cp_int_prop(u32 vco_clk,
> +static void get_ana_cp_int_prop(u64 vco_clk,
>   				u32 refclk_postscalar,
>   				int mpll_ana_v2i,
>   				int c, int a,

  reply	other threads:[~2025-05-27  4:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-13  8:38 [PATCH 0/2] Fix u32 overflow issues for SNPS PHY HDMI PLL Dibin Moolakadan Subrahmanian
2025-05-13  8:38 ` [PATCH 1/2] drm/i915/display: Fix get_ana_cp_int_prop() argument type Dibin Moolakadan Subrahmanian
2025-05-27  4:50   ` Nautiyal, Ankit K [this message]
2025-05-13  8:38 ` [PATCH 2/2] drm/i915/display: Fix intel_snps_hdmi_pll.c overflow issues Dibin Moolakadan Subrahmanian
2025-05-27  4:48   ` Nautiyal, Ankit K
2025-05-13 11:14 ` ✓ i915.CI.BAT: success for Fix u32 overflow issues for SNPS PHY HDMI PLL Patchwork
2025-05-13 13:03 ` ✗ i915.CI.Full: failure " Patchwork
2025-05-14  7:08 ` ✓ CI.Patch_applied: success " Patchwork
2025-05-14  7:09 ` ✓ CI.checkpatch: " Patchwork
2025-05-14  7:10 ` ✓ CI.KUnit: " Patchwork
2025-05-14  7:20 ` ✓ CI.Build: " Patchwork
2025-05-14  7:23 ` ✓ CI.Hooks: " Patchwork
2025-05-14  7:24 ` ✓ CI.checksparse: " Patchwork
2025-05-14  8:06 ` ✓ Xe.CI.BAT: " Patchwork
2025-05-14 10:10 ` ✗ Xe.CI.Full: failure " Patchwork
2025-05-26 22:37 ` ✓ CI.Patch_applied: success " Patchwork
2025-05-26 22:37 ` ✓ CI.checkpatch: " Patchwork
2025-05-26 22:38 ` ✓ CI.KUnit: " Patchwork
2025-05-26 22:49 ` ✓ CI.Build: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c808b60f-9517-4003-9d9a-8e092d474ebb@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=dibin.moolakadan.subrahmanian@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.