From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [RFC][PATCH 5/5 v2] drm/bridge: adv7511: Reuse __adv7511_power_on/off() when probing EDID Date: Wed, 30 Nov 2016 10:12:20 +0530 Message-ID: References: <1480395884-5471-1-git-send-email-john.stultz@linaro.org> <1480395884-5471-6-git-send-email-john.stultz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by gabe.freedesktop.org (Postfix) with ESMTPS id D2F046E021 for ; Wed, 30 Nov 2016 04:42:26 +0000 (UTC) In-Reply-To: <1480395884-5471-6-git-send-email-john.stultz@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Stultz , lkml Cc: Wolfram Sang , Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org CgpPbiAxMS8yOS8yMDE2IDEwOjM0IEFNLCBKb2huIFN0dWx0eiB3cm90ZToKPiBJJ3ZlIGZvdW5k IHRoYXQgYnkganVzdCB0dXJuaW5nIHRoZSBjaGlwIG9uIGFuZCBvZmYgdmlhIHRoZQo+IFBPV0VS X0RPV04gcmVnaXN0ZXIsIEkgZW5kIHVwIGdldHRpbmcgaTJjX3RyYW5zZmVyIGVycm9ycwo+IG9u IEhpS2V5Lgo+Cj4gSW52ZXN0aWdhdGluZyBmdXJ0aGVyLCBpdCBzZWVtcyBzb21lIG9mIHRoZSBy ZWdpc3RlciBzdGF0ZQo+IGluIHRoZSByZWdtYXAgY2FjaGUgaXMgc29tZWhvdyBnZXR0aW5nIGxv c3QuIFVzaW5nIHRoZSBsb2dpYwo+IGluIF9fYWR2NzUxMV9wb3dlcl9vbi9vZmYoKSB3aGljaCBz eW5jcyBhbmQgZGlydHlzIHRoZSBjYWNoZQo+IGF2b2lkcyB0aGlzIGlzc3VlLgo+Cj4gVGh1cyB0 aGlzIHBhdGNoIGNoYW5nZXMgdGhlIEVESUQgcHJvYmluZyBsb2dpYyBzbyB0aGF0IHdlCj4gcmUt dXNlIHRoZSBfX2Fkdjc1MTFfcG93ZXJfb24vb2ZmKCkgY2FsbHMuCj4KPiBDYzogRGF2aWQgQWly bGllIDxhaXJsaWVkQGxpbnV4LmllPgo+IENjOiBBcmNoaXQgVGFuZWphIDxhcmNoaXR0QGNvZGVh dXJvcmEub3JnPgo+IENjOiBXb2xmcmFtIFNhbmcgPHdzYStyZW5lc2FzQHNhbmctZW5naW5lZXJp bmcuY29tPgo+IENjOiBMYXJzLVBldGVyIENsYXVzZW4gPGxhcnNAbWV0YWZvby5kZT4KPiBDYzog TGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgo+IENj OiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gU2lnbmVkLW9mZi1ieTogSm9obiBT dHVsdHogPGpvaG4uc3R1bHR6QGxpbmFyby5vcmc+Cj4gLS0tCj4gdjI6IFNwbGl0IGludG8gdHdv IHBhdGNoZXMgdG8gbWFrZSB0aGUgY2hhbmdlIG1vcmUgY2xlYXIuCj4gICAgIEFsc28gcHJvdmlk ZWQgbW9yZSByYXRpb25hbCBhcyB0byB3aHkgdGhlIGNoYW5nZSBpcwo+ICAgICBpbXBvcnRhbnQu Cj4KPiAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hZHY3NTExL2Fkdjc1MTFfZHJ2LmMgfCAxNyAr KystLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAxNCBk ZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2Fkdjc1 MTEvYWR2NzUxMV9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTEx X2Rydi5jCj4gaW5kZXggMTk0ODk2OC4uNDg3YjMzZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vYnJpZGdlL2Fkdjc1MTEvYWR2NzUxMV9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9icmlkZ2UvYWR2NzUxMS9hZHY3NTExX2Rydi5jCj4gQEAgLTU1OSwyNCArNTU5LDEzIEBAIHN0 YXRpYyBpbnQgYWR2NzUxMV9nZXRfbW9kZXMoc3RydWN0IGFkdjc1MTEgKmFkdjc1MTEsCj4gIAl1 bnNpZ25lZCBpbnQgY291bnQ7Cj4KPiAgCS8qIFJlYWRpbmcgdGhlIEVESUQgb25seSB3b3JrcyBp ZiB0aGUgZGV2aWNlIGlzIHBvd2VyZWQgKi8KPiAtCWlmICghYWR2NzUxMS0+cG93ZXJlZCkgewo+ IC0JCXJlZ21hcF91cGRhdGVfYml0cyhhZHY3NTExLT5yZWdtYXAsIEFEVjc1MTFfUkVHX1BPV0VS LAo+IC0JCQkJICAgQURWNzUxMV9QT1dFUl9QT1dFUl9ET1dOLCAwKTsKPiAtCQlpZiAoYWR2NzUx MS0+aTJjX21haW4tPmlycSkgewo+IC0JCQlyZWdtYXBfd3JpdGUoYWR2NzUxMS0+cmVnbWFwLCBB RFY3NTExX1JFR19JTlRfRU5BQkxFKDApLAo+IC0JCQkJICAgICBBRFY3NTExX0lOVDBfRURJRF9S RUFEWSk7Cj4gLQkJCXJlZ21hcF93cml0ZShhZHY3NTExLT5yZWdtYXAsIEFEVjc1MTFfUkVHX0lO VF9FTkFCTEUoMSksCj4gLQkJCQkgICAgIEFEVjc1MTFfSU5UMV9ERENfRVJST1IpOwo+IC0JCX0K PiAtCQlhZHY3NTExLT5jdXJyZW50X2VkaWRfc2VnbWVudCA9IC0xOwo+IC0JfQo+ICsJaWYgKCFh ZHY3NTExLT5wb3dlcmVkKQo+ICsJCV9fYWR2NzUxMV9wb3dlcl9vbihhZHY3NTExKTsKCkluIHRl cm1zIG9mIGNoYW5nZXMgaW4gdGVybXMgb2YgcmVnaXN0ZXIgY29uZmlndXJhdGlvbnMsIHJlcGxh Y2luZyB3aXRoCl9fYWR2NzUxMV9wb3dlcl9vbigpIGhlcmUgd291bGQgYWRkIGEgcmVnaXN0ZXIg d3JpdGUgdG8gQURWNzUxMV9SRUdfUE9XRVIyCmFzIGRpc2N1c3NlZCBiZWZvcmUuCgpBbHNvLCBh ZnRlciB0aGUgcGF0Y2ggdGhhdCBlbmFibGVzIEhQRCwgd2UnZCBhbHNvIGJlIGFkZGluZyB0aGUg QURWNzUxMV9JTlQwX0hQRApiaXQgaW4gQURWNzUxMV9SRUdfSU5UX0VOQUJMRSgwKS4KCkkgYW0g bm90IGVudGlyZWx5IHN1cmUgYWJvdXQgd2hhdCBlZmZlY3QgYWRkaW5nIFBPV0VSMiB3b3VsZCBo YXZlLiBJZiB3ZSBkb24ndApzZWUgYW55IG5lZ2F0aXZlIGVmZmVjdHMgYmVjYXVzZSBvZiBpdCwg SSB0aGluayB3ZSBzaG91bGQgYmUgZmluZS4KClRoZSBleHRyYSBIUEQgYml0IGluIElOVF9FTkFC TEUoMCkgc2hvdWxkbid0IGJlIGEgcHJvYmxlbSwgdGhvdWdoLiBJbiBmYWN0LCBpdApwcmV2ZW50 cyB0aGUgSFBEIG1hc2sgZnJvbSBiZWluZyBjbGVhcmVkIGFmdGVyIHdlIGdldF9tb2RlcyBpcyBj YWxsZWQsIHdoaWNoIG1heQpoYXZlIHJlc3VsdGVkIGluIHVzIG1pc3Npbmcgb3V0IG9uIEhQRCBp bnRlcnJ1cHRzLgoKVGhhbmtzLApBcmNoaXQKCj4KPiAgCWVkaWQgPSBkcm1fZG9fZ2V0X2VkaWQo Y29ubmVjdG9yLCBhZHY3NTExX2dldF9lZGlkX2Jsb2NrLCBhZHY3NTExKTsKPgo+ICAJaWYgKCFh ZHY3NTExLT5wb3dlcmVkKQo+IC0JCXJlZ21hcF91cGRhdGVfYml0cyhhZHY3NTExLT5yZWdtYXAs IEFEVjc1MTFfUkVHX1BPV0VSLAo+IC0JCQkJICAgQURWNzUxMV9QT1dFUl9QT1dFUl9ET1dOLAo+ IC0JCQkJICAgQURWNzUxMV9QT1dFUl9QT1dFUl9ET1dOKTsKPiArCQlfX2Fkdjc1MTFfcG93ZXJf b2ZmKGFkdjc1MTEpOwo+Cj4gIAlrZnJlZShhZHY3NTExLT5lZGlkKTsKPiAgCWFkdjc1MTEtPmVk aWQgPSBlZGlkOwo+CgotLSAKUXVhbGNvbW0gSW5ub3ZhdGlvbiBDZW50ZXIsIEluYy4gaXMgYSBt ZW1iZXIgb2YgQ29kZSBBdXJvcmEgRm9ydW0sCmEgTGludXggRm91bmRhdGlvbiBDb2xsYWJvcmF0 aXZlIFByb2plY3QKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754678AbcK3Emh (ORCPT ); Tue, 29 Nov 2016 23:42:37 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:35166 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751952AbcK3Em1 (ORCPT ); Tue, 29 Nov 2016 23:42:27 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org C2CBD61406 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=architt@codeaurora.org Subject: Re: [RFC][PATCH 5/5 v2] drm/bridge: adv7511: Reuse __adv7511_power_on/off() when probing EDID To: John Stultz , lkml References: <1480395884-5471-1-git-send-email-john.stultz@linaro.org> <1480395884-5471-6-git-send-email-john.stultz@linaro.org> Cc: David Airlie , Wolfram Sang , Lars-Peter Clausen , Laurent Pinchart , dri-devel@lists.freedesktop.org From: Archit Taneja Message-ID: Date: Wed, 30 Nov 2016 10:12:20 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1480395884-5471-6-git-send-email-john.stultz@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/29/2016 10:34 AM, John Stultz wrote: > I've found that by just turning the chip on and off via the > POWER_DOWN register, I end up getting i2c_transfer errors > on HiKey. > > Investigating further, it seems some of the register state > in the regmap cache is somehow getting lost. Using the logic > in __adv7511_power_on/off() which syncs and dirtys the cache > avoids this issue. > > Thus this patch changes the EDID probing logic so that we > re-use the __adv7511_power_on/off() calls. > > Cc: David Airlie > Cc: Archit Taneja > Cc: Wolfram Sang > Cc: Lars-Peter Clausen > Cc: Laurent Pinchart > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: John Stultz > --- > v2: Split into two patches to make the change more clear. > Also provided more rational as to why the change is > important. > > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 17 +++-------------- > 1 file changed, 3 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > index 1948968..487b33d 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > @@ -559,24 +559,13 @@ static int adv7511_get_modes(struct adv7511 *adv7511, > unsigned int count; > > /* Reading the EDID only works if the device is powered */ > - if (!adv7511->powered) { > - regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER, > - ADV7511_POWER_POWER_DOWN, 0); > - if (adv7511->i2c_main->irq) { > - regmap_write(adv7511->regmap, ADV7511_REG_INT_ENABLE(0), > - ADV7511_INT0_EDID_READY); > - regmap_write(adv7511->regmap, ADV7511_REG_INT_ENABLE(1), > - ADV7511_INT1_DDC_ERROR); > - } > - adv7511->current_edid_segment = -1; > - } > + if (!adv7511->powered) > + __adv7511_power_on(adv7511); In terms of changes in terms of register configurations, replacing with __adv7511_power_on() here would add a register write to ADV7511_REG_POWER2 as discussed before. Also, after the patch that enables HPD, we'd also be adding the ADV7511_INT0_HPD bit in ADV7511_REG_INT_ENABLE(0). I am not entirely sure about what effect adding POWER2 would have. If we don't see any negative effects because of it, I think we should be fine. The extra HPD bit in INT_ENABLE(0) shouldn't be a problem, though. In fact, it prevents the HPD mask from being cleared after we get_modes is called, which may have resulted in us missing out on HPD interrupts. Thanks, Archit > > edid = drm_do_get_edid(connector, adv7511_get_edid_block, adv7511); > > if (!adv7511->powered) > - regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER, > - ADV7511_POWER_POWER_DOWN, > - ADV7511_POWER_POWER_DOWN); > + __adv7511_power_off(adv7511); > > kfree(adv7511->edid); > adv7511->edid = edid; > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project