From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E97A727E049 for ; Wed, 4 Mar 2026 19:29:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772652570; cv=none; b=eVm5KijAkUIX6u9L7KHI66r11M4n4roapUhHkLBYjTidC8BJ6VTzulQl6myUSZ+L5TlDasUJjBMNZvxuLc9f+PC9LK28zp9iJk/holzreN0Nc4JUqnaZmvH0sw3/XlwTlMhNjhCx+ScyO12abWFLdgZT93tnJuxdCwcu1pRwt8Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772652570; c=relaxed/simple; bh=x+0a22cHFKVC7NrvpWlmeT7TYuEH3j/mSLjSZtuZIPM=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=DLaAjRnXG/+DhdsdqKo0GhdcUzKUMAZxq/t6NSHBeStIXqQjviTukWGUMjGH/TkPE41W3UDOaUYv2PfzEAulpY2wbfiHvde6PyGjmP6YKrEO7t+eVum2aQparRcPCJRE8kjsiWgOYBvLfwhIi8vb0ekDeVPycAnctJ5766JfFOw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tw3McEQ9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tw3McEQ9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F17AC4CEF7; Wed, 4 Mar 2026 19:29:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772652569; bh=x+0a22cHFKVC7NrvpWlmeT7TYuEH3j/mSLjSZtuZIPM=; h=Date:Subject:To:References:From:In-Reply-To:From; b=tw3McEQ9LfwrHgyZpZ962duQPT0OpEY77xXNUVak6u8B8WoE2qQWuCuPjV5ed1nCk lhOaJ57pmciMkEYmR5XJwG5SqUgAlbrhp0giw6fNRm4QfrcShmhsZIzS5vtwyQpfgT 6MN+ITOpt7+18s4qeHI+9WJjc3Uv8Rhmr162DmwupDx5YXy5T6IregVM5EkMLLVg3V UABcXC4qCK7/fz7QH8Jswv+2T/WFNMkw7QVQtX+Ih+naIsh9PGijc9humFmeBQXXKu xTbExnJ87qAYGGHRPtEW8hpcTk2Xv/nh5+R8MvrKY4mMxUxYWgM+mXbbYJ6gnBk3l2 Fp23YZjLwxLGw== Message-ID: Date: Wed, 4 Mar 2026 12:29:28 -0700 Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv2 1/1] RDMA/rxe: Add the support that rxe can work in net namespace Content-Language: en-US To: Zhu Yanjun , jgg@ziepe.ca, leon@kernel.org, zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org References: <20260304041607.11685-1-yanjun.zhu@linux.dev> <28be84a9-ad21-4a29-8199-a155e63e4cd8@linux.dev> From: David Ahern In-Reply-To: <28be84a9-ad21-4a29-8199-a155e63e4cd8@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/3/26 9:44 PM, Zhu Yanjun wrote: > The script in the link > https://github.com/zhuyj/linux/blob/6.19-net-namespace/net_ns_rxe.sh can > make tests in linux distributions. I have not read the patch, but I did look at the test script referenced here. Comments 1. drop the sleeps. They should never be needed. If you need to wait for some resource, then wait for that resource explicitly with a timeout. 2. tests should cover the range of features in the patch meaning IPv6, and if you keep the attempts to delete the socket after the rxe devices are deleted, then tests should include variations of this theme. e.g., per network namespace: a. no devices = no socket b. 1 device, sockets work, delete device, no socket c. 2 devices, sockets work, delete 1 device, socket still works, delete second device, no socket. 3. the script can be added to tools/testing/selftests/{infiniband,rdma} -- whatever directory seems most appropriate. Adding it here and fitting within kernel selftests means it can be run by CI as commits are done. > > BTW, please disable firewall before making tests. That should not be needed. The test script should be internal to a host using only namespaces you control and configure.