From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2 2/4] net/i40e: add new functions to manipulate with pctype mapping table Date: Fri, 8 Sep 2017 18:01:20 +0100 Message-ID: References: <1503569908-104074-1-git-send-email-kirill.rybalchenko@intel.com> <1504278166-32769-1-git-send-email-kirill.rybalchenko@intel.com> <1504278166-32769-3-git-send-email-kirill.rybalchenko@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: andrey.chilikin@intel.com, beilei.xing@intel.com, jingjing.wu@intel.com To: Kirill Rybalchenko , dev@dpdk.org Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id B61C51AD79 for ; Fri, 8 Sep 2017 19:02:42 +0200 (CEST) In-Reply-To: <1504278166-32769-3-git-send-email-kirill.rybalchenko@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/1/2017 4:02 PM, Kirill Rybalchenko wrote: > Add new functions which allow modify, return or reset to default > the contents of flow type to pctype dynamic mapping table. > > Signed-off-by: Kirill Rybalchenko > --- > drivers/net/i40e/rte_pmd_i40e.c | 98 +++++++++++++++++++++++++++++++++++++++++ > drivers/net/i40e/rte_pmd_i40e.h | 61 +++++++++++++++++++++++++ .map file needs to be updated for shared build. <...> > +int rte_pmd_i40e_flow_type_mapping_get( > + uint8_t port, > + struct rte_pmd_i40e_flow_type_mapping *mapping_items, > + uint16_t size, > + uint16_t *count, > + uint8_t valid_only)> +{ > + struct rte_eth_dev *dev; > + struct i40e_adapter *ad; > + int n = 0; > + uint16_t i; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV); > + > + dev = &rte_eth_devices[port]; > + > + if (!is_i40e_supported(dev)) > + return -ENOTSUP; > + > + ad = I40E_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private); > + > + for (i = 0; i < I40E_FLOW_TYPE_MAX; i++) { > + if (n >= size) > + break; This returns partial table and success, how caller can know if it get full table or not? Is returning partial table required, specially when custom offset is not supported.. > + if (valid_only && ad->pcypes_tbl[i] == 0ULL) > + continue; > + mapping_items[n].flow_type = i; > + mapping_items[n].pctype = ad->pcypes_tbl[i]; > + n++; > + } > + > + *count = n; > + return 0; > +} <...> > @@ -657,4 +657,65 @@ int rte_pmd_i40e_ptype_mapping_replace(uint8_t port, > int rte_pmd_i40e_add_vf_mac_addr(uint8_t port, uint16_t vf_id, > struct ether_addr *mac_addr); > > + > +struct rte_pmd_i40e_flow_type_mapping { > + uint8_t flow_type; /**< software defined flow type*/ flow_type are RTE_ETH_FLOW_* values defined in rte_eth_ctrl.h which is public header. > + uint64_t pctype; /**< hardware defined pctype */ But how user can get pctype values, since this is part of public API, and if application would like to use these values, is there any public header list them? > +}; > + > +/** > + * Update hardware defined pctype to software defined flow type > + * mapping table. > + * > + * @param port > + * pointer to port identifier of the device. > + * @param mapping_items > + * the base address of the mapping items array. > + * @param count > + * number of mapping items. > + * @param exclusive > + * the flag indicate different ptype mapping update method. > + * -(0) only overwrite referred PTYPE mapping, > + * keep other PTYPEs mapping unchanged. > + * -(!0) overwrite referred PTYPE mapping, > + * set other PTYPEs maps to PTYPE_UNKNOWN. > + */ > +int rte_pmd_i40e_flow_type_mapping_update( > + uint8_t port, > + struct rte_pmd_i40e_flow_type_mapping *mapping_items, > + uint16_t count, > + uint8_t exclusive); May prefer boolean here. > + > +/** > + * Get software defined flow type to hardware defined pctype > + * mapping items. > + * > + * @param port > + * pointer to port identifier of the device. > + * @param mapping_items > + * the base address of the array to store returned items. > + * @param size > + * the size of the input array. > + * @param count > + * the place to store the number of returned items. > + * @param valid_only > + * -(0) return full mapping table. > + * -(!0) only return mapping items which flow_type != RTE_ETH_FLOW_UNKNOWN. > + */ > +int rte_pmd_i40e_flow_type_mapping_get( > + uint8_t port, > + struct rte_pmd_i40e_flow_type_mapping *mapping_items, > + uint16_t size, > + uint16_t *count, > + uint8_t valid_only); May prefer boolean here. <...>