From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26F1CC352BE for ; Thu, 16 Apr 2020 17:44:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2E7D206F9 for ; Thu, 16 Apr 2020 17:44:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="H5jxEXFl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388426AbgDPRoE (ORCPT ); Thu, 16 Apr 2020 13:44:04 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:63723 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391025AbgDPRoC (ORCPT ); Thu, 16 Apr 2020 13:44:02 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1587059041; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=JC4ZwghNo+JEiak2hmqi7d8kddFUllqOr9vrtZr5HYE=; b=H5jxEXFlqxPvUrEIyhaO+/yTpgOTtcxdzXaiJg8qb1fmCKmBL7KR1ObOBtmfWxDYSWJ1vuq2 /KTPsevHr39OqGveMe8RAPfpOvJR6ZttUtmfbV2y3/N9QzUFInb1haWspbtR0MXLZeAHCunt cisxlfiQ28EEL3T++f3tOw6zV3g= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e989958.7f80986531b8-smtp-out-n03; Thu, 16 Apr 2020 17:43:52 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 65AEEC44795; Thu, 16 Apr 2020 17:43:52 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7D284C4478C; Thu, 16 Apr 2020 17:43:50 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 16 Apr 2020 23:13:50 +0530 From: Sai Prakash Ranjan To: Robin Murphy Cc: Will Deacon , Joerg Roedel , Jordan Crouse , Rob Clark , Tomasz Figa , Rajendra Nayak , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Boyd , iommu@lists.linux-foundation.org, Matthias Kaehlcke , Bjorn Andersson , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] iommu/arm-smmu: Allow client devices to select direct mapping In-Reply-To: References: <813cc5b2da10c27db982254b274bf26008a9e6da.1579692800.git.saiprakash.ranjan@codeaurora.org> <3f12cefb-3887-859c-ddf5-c7a0fc755152@arm.com> <540fc55811d0a60a929ff1f694d6d271@codeaurora.org> Message-ID: X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Robin, On 2020-04-16 22:47, Robin Murphy wrote: > On 2020-04-16 5:23 pm, Sai Prakash Ranjan wrote: >> Hi Robin, >> >> On 2020-04-16 19:28, Robin Murphy wrote: >>> On 2020-01-22 11:48 am, Sai Prakash Ranjan wrote: >>>> From: Jordan Crouse >>>> >>>> Some client devices want to directly map the IOMMU themselves >>>> instead >>>> of using the DMA domain. Allow those devices to opt in to direct >>>> mapping by way of a list of compatible strings. >>>> >>>> Signed-off-by: Jordan Crouse >>>> Co-developed-by: Sai Prakash Ranjan >>>> >>>> Signed-off-by: Sai Prakash Ranjan >>>> --- >>>>   drivers/iommu/arm-smmu-qcom.c | 39 >>>> +++++++++++++++++++++++++++++++++++ >>>>   drivers/iommu/arm-smmu.c      |  3 +++ >>>>   drivers/iommu/arm-smmu.h      |  5 +++++ >>>>   3 files changed, 47 insertions(+) >>>> >>>> diff --git a/drivers/iommu/arm-smmu-qcom.c >>>> b/drivers/iommu/arm-smmu-qcom.c >>>> index 64a4ab270ab7..ff746acd1c81 100644 >>>> --- a/drivers/iommu/arm-smmu-qcom.c >>>> +++ b/drivers/iommu/arm-smmu-qcom.c >>>> @@ -3,6 +3,7 @@ >>>>    * Copyright (c) 2019, The Linux Foundation. All rights reserved. >>>>    */ >>>>   +#include >>>>   #include >>>>     #include "arm-smmu.h" >>>> @@ -11,6 +12,43 @@ struct qcom_smmu { >>>>       struct arm_smmu_device smmu; >>>>   }; >>>>   +static const struct arm_smmu_client_match_data qcom_adreno = { >>>> +    .direct_mapping = true, >>>> +}; >>>> + >>>> +static const struct arm_smmu_client_match_data qcom_mdss = { >>>> +    .direct_mapping = true, >>>> +}; >>> >>> Might it make sense to group these by the desired SMMU behaviour >>> rather than (apparently) what kind of device the client happens to >>> be, >>> which seems like a completely arbitrary distinction from the SMMU >>> driver's PoV? >>> >> >> Sorry, I did not get the "grouping by the desired SMMU behaviour" >> thing. >> Could you please give some more details? > > I mean this pattern: > > device_a_data { > .thing = this; > } > > device_b_data { > .thing = this; > } > > device_c_data { > .thing = that; > } > > match[] = { > { .compatible = "A", .data = &device_a_data }, > { .compatible = "B", .data = &device_b_data }, > { .compatible = "C", .data = &device_c_data }, > }; > > ...vs. this pattern: > > do_this { > .thing = this; > } > > do_that { > .thing = that; > } > > match[] = { > { .compatible = "A", .data = &do_this }, > { .compatible = "B", .data = &do_this }, > { .compatible = "C", .data = &do_that }, > }; > > From the perspective of the thing doing the thing, grouping the data > by device is meaningless if all that matters is whether to do this or > that. The second pattern expresses that more naturally. > > Of course if every device turns out to need a unique combination of > several behaviours, then there ends up being no practical difference > except that it's probably easier to come up with nice names under the > first pattern. I guess it's up to how you see this developing in > future; whether you're likely to need fine-grained per-device control, > or don't expect it to go much beyond domain type. > Thanks for explaining *this thing* :) I will update the patch to follow the 2nd pattern as it makes more sense to do_this or do_that directly. I'm not expecting anything other than domain type atleast for now but hey we can always add the functionality if the need arises. Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 371F4C352BE for ; Thu, 16 Apr 2020 17:44:12 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E962C2078B for ; Thu, 16 Apr 2020 17:44:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="HtfFFiu/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E962C2078B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 803C287DB1; Thu, 16 Apr 2020 17:44:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id btfvcAwJn71F; Thu, 16 Apr 2020 17:44:10 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id A2D718749A; Thu, 16 Apr 2020 17:44:10 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 95369C089E; Thu, 16 Apr 2020 17:44:10 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 699F1C0172 for ; Thu, 16 Apr 2020 17:44:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 54AFE86096 for ; Thu, 16 Apr 2020 17:44:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IbAELne8XCdN for ; Thu, 16 Apr 2020 17:44:08 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail26.static.mailgun.info (mail26.static.mailgun.info [104.130.122.26]) by whitealder.osuosl.org (Postfix) with ESMTPS id 4FEA885C3B for ; Thu, 16 Apr 2020 17:44:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1587059048; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=JC4ZwghNo+JEiak2hmqi7d8kddFUllqOr9vrtZr5HYE=; b=HtfFFiu/hExld+CefooChbbDpqi/ujJRZ/G3ZBmDODdaxKw3E7ajwun2kNfndZ4fPdITiFPs FTkRHUe0DigQUAF8Gx+SRJYfdzwbVUxXh/EDfYmHrP12Ckfv/aMKP/fg4WTo2cle7QENboH7 hLRKutxnbnoFXRHkzXMbm7NxZJ4= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3NDkwMCIsICJpb21tdUBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e989958.7efd1aae9260-smtp-out-n04; Thu, 16 Apr 2020 17:43:52 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 7FDBBC4478C; Thu, 16 Apr 2020 17:43:52 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7D284C4478C; Thu, 16 Apr 2020 17:43:50 +0000 (UTC) MIME-Version: 1.0 Date: Thu, 16 Apr 2020 23:13:50 +0530 From: Sai Prakash Ranjan To: Robin Murphy Subject: Re: [PATCH 2/2] iommu/arm-smmu: Allow client devices to select direct mapping In-Reply-To: References: <813cc5b2da10c27db982254b274bf26008a9e6da.1579692800.git.saiprakash.ranjan@codeaurora.org> <3f12cefb-3887-859c-ddf5-c7a0fc755152@arm.com> <540fc55811d0a60a929ff1f694d6d271@codeaurora.org> Message-ID: X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Cc: Rajendra Nayak , linux-arm-msm@vger.kernel.org, iommu@lists.linux-foundation.org, Matthias Kaehlcke , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, Stephen Boyd , Will Deacon , linux-kernel@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" SGkgUm9iaW4sCgpPbiAyMDIwLTA0LTE2IDIyOjQ3LCBSb2JpbiBNdXJwaHkgd3JvdGU6Cj4gT24g MjAyMC0wNC0xNiA1OjIzIHBtLCBTYWkgUHJha2FzaCBSYW5qYW4gd3JvdGU6Cj4+IEhpIFJvYmlu LAo+PiAKPj4gT24gMjAyMC0wNC0xNiAxOToyOCwgUm9iaW4gTXVycGh5IHdyb3RlOgo+Pj4gT24g MjAyMC0wMS0yMiAxMTo0OCBhbSwgU2FpIFByYWthc2ggUmFuamFuIHdyb3RlOgo+Pj4+IEZyb206 IEpvcmRhbiBDcm91c2UgPGpjcm91c2VAY29kZWF1cm9yYS5vcmc+Cj4+Pj4gCj4+Pj4gU29tZSBj bGllbnQgZGV2aWNlcyB3YW50IHRvIGRpcmVjdGx5IG1hcCB0aGUgSU9NTVUgdGhlbXNlbHZlcyAK Pj4+PiBpbnN0ZWFkCj4+Pj4gb2YgdXNpbmcgdGhlIERNQSBkb21haW4uIEFsbG93IHRob3NlIGRl dmljZXMgdG8gb3B0IGluIHRvIGRpcmVjdAo+Pj4+IG1hcHBpbmcgYnkgd2F5IG9mIGEgbGlzdCBv ZiBjb21wYXRpYmxlIHN0cmluZ3MuCj4+Pj4gCj4+Pj4gU2lnbmVkLW9mZi1ieTogSm9yZGFuIENy b3VzZSA8amNyb3VzZUBjb2RlYXVyb3JhLm9yZz4KPj4+PiBDby1kZXZlbG9wZWQtYnk6IFNhaSBQ cmFrYXNoIFJhbmphbiAKPj4+PiA8c2FpcHJha2FzaC5yYW5qYW5AY29kZWF1cm9yYS5vcmc+Cj4+ Pj4gU2lnbmVkLW9mZi1ieTogU2FpIFByYWthc2ggUmFuamFuIDxzYWlwcmFrYXNoLnJhbmphbkBj b2RlYXVyb3JhLm9yZz4KPj4+PiAtLS0KPj4+PiDCoCBkcml2ZXJzL2lvbW11L2FybS1zbW11LXFj b20uYyB8IDM5IAo+Pj4+ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4+Pj4g wqAgZHJpdmVycy9pb21tdS9hcm0tc21tdS5jwqDCoMKgwqDCoCB8wqAgMyArKysKPj4+PiDCoCBk cml2ZXJzL2lvbW11L2FybS1zbW11LmjCoMKgwqDCoMKgIHzCoCA1ICsrKysrCj4+Pj4gwqAgMyBm aWxlcyBjaGFuZ2VkLCA0NyBpbnNlcnRpb25zKCspCj4+Pj4gCj4+Pj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvaW9tbXUvYXJtLXNtbXUtcWNvbS5jIAo+Pj4+IGIvZHJpdmVycy9pb21tdS9hcm0tc21t dS1xY29tLmMKPj4+PiBpbmRleCA2NGE0YWIyNzBhYjcuLmZmNzQ2YWNkMWM4MSAxMDA2NDQKPj4+ PiAtLS0gYS9kcml2ZXJzL2lvbW11L2FybS1zbW11LXFjb20uYwo+Pj4+ICsrKyBiL2RyaXZlcnMv aW9tbXUvYXJtLXNtbXUtcWNvbS5jCj4+Pj4gQEAgLTMsNiArMyw3IEBACj4+Pj4gwqDCoCAqIENv cHlyaWdodCAoYykgMjAxOSwgVGhlIExpbnV4IEZvdW5kYXRpb24uIEFsbCByaWdodHMgcmVzZXJ2 ZWQuCj4+Pj4gwqDCoCAqLwo+Pj4+IMKgICsjaW5jbHVkZSA8bGludXgvb2ZfZGV2aWNlLmg+Cj4+ Pj4gwqAgI2luY2x1ZGUgPGxpbnV4L3Fjb21fc2NtLmg+Cj4+Pj4gwqDCoMKgICNpbmNsdWRlICJh cm0tc21tdS5oIgo+Pj4+IEBAIC0xMSw2ICsxMiw0MyBAQCBzdHJ1Y3QgcWNvbV9zbW11IHsKPj4+ PiDCoMKgwqDCoMKgIHN0cnVjdCBhcm1fc21tdV9kZXZpY2Ugc21tdTsKPj4+PiDCoCB9Owo+Pj4+ IMKgICtzdGF0aWMgY29uc3Qgc3RydWN0IGFybV9zbW11X2NsaWVudF9tYXRjaF9kYXRhIHFjb21f YWRyZW5vID0gewo+Pj4+ICvCoMKgwqAgLmRpcmVjdF9tYXBwaW5nID0gdHJ1ZSwKPj4+PiArfTsK Pj4+PiArCj4+Pj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgYXJtX3NtbXVfY2xpZW50X21hdGNoX2Rh dGEgcWNvbV9tZHNzID0gewo+Pj4+ICvCoMKgwqAgLmRpcmVjdF9tYXBwaW5nID0gdHJ1ZSwKPj4+ PiArfTsKPj4+IAo+Pj4gTWlnaHQgaXQgbWFrZSBzZW5zZSB0byBncm91cCB0aGVzZSBieSB0aGUg ZGVzaXJlZCBTTU1VIGJlaGF2aW91cgo+Pj4gcmF0aGVyIHRoYW4gKGFwcGFyZW50bHkpIHdoYXQg a2luZCBvZiBkZXZpY2UgdGhlIGNsaWVudCBoYXBwZW5zIHRvIAo+Pj4gYmUsCj4+PiB3aGljaCBz ZWVtcyBsaWtlIGEgY29tcGxldGVseSBhcmJpdHJhcnkgZGlzdGluY3Rpb24gZnJvbSB0aGUgU01N VQo+Pj4gZHJpdmVyJ3MgUG9WPwo+Pj4gCj4+IAo+PiBTb3JyeSwgSSBkaWQgbm90IGdldCB0aGUg Imdyb3VwaW5nIGJ5IHRoZSBkZXNpcmVkIFNNTVUgYmVoYXZpb3VyIiAKPj4gdGhpbmcuCj4+IENv dWxkIHlvdSBwbGVhc2UgZ2l2ZSBzb21lIG1vcmUgZGV0YWlscz8KPiAKPiBJIG1lYW4gdGhpcyBw YXR0ZXJuOgo+IAo+IGRldmljZV9hX2RhdGEgewo+IAkudGhpbmcgPSB0aGlzOwo+IH0KPiAKPiBk ZXZpY2VfYl9kYXRhIHsKPiAJLnRoaW5nID0gdGhpczsKPiB9Cj4gCj4gZGV2aWNlX2NfZGF0YSB7 Cj4gCS50aGluZyA9IHRoYXQ7Cj4gfQo+IAo+IG1hdGNoW10gPSB7Cj4gCXsgLmNvbXBhdGlibGUg PSAiQSIsIC5kYXRhID0gJmRldmljZV9hX2RhdGEgfSwKPiAJeyAuY29tcGF0aWJsZSA9ICJCIiwg LmRhdGEgPSAmZGV2aWNlX2JfZGF0YSB9LAo+IAl7IC5jb21wYXRpYmxlID0gIkMiLCAuZGF0YSA9 ICZkZXZpY2VfY19kYXRhIH0sCj4gfTsKPiAKPiAuLi52cy4gdGhpcyBwYXR0ZXJuOgo+IAo+IGRv X3RoaXMgewo+IAkudGhpbmcgPSB0aGlzOwo+IH0KPiAKPiBkb190aGF0IHsKPiAJLnRoaW5nID0g dGhhdDsKPiB9Cj4gCj4gbWF0Y2hbXSA9IHsKPiAJeyAuY29tcGF0aWJsZSA9ICJBIiwgLmRhdGEg PSAmZG9fdGhpcyB9LAo+IAl7IC5jb21wYXRpYmxlID0gIkIiLCAuZGF0YSA9ICZkb190aGlzIH0s Cj4gCXsgLmNvbXBhdGlibGUgPSAiQyIsIC5kYXRhID0gJmRvX3RoYXQgfSwKPiB9Owo+IAo+IEZy b20gdGhlIHBlcnNwZWN0aXZlIG9mIHRoZSB0aGluZyBkb2luZyB0aGUgdGhpbmcsIGdyb3VwaW5n IHRoZSBkYXRhCj4gYnkgZGV2aWNlIGlzIG1lYW5pbmdsZXNzIGlmIGFsbCB0aGF0IG1hdHRlcnMg aXMgd2hldGhlciB0byBkbyB0aGlzIG9yCj4gdGhhdC4gVGhlIHNlY29uZCBwYXR0ZXJuIGV4cHJl c3NlcyB0aGF0IG1vcmUgbmF0dXJhbGx5Lgo+IAo+IE9mIGNvdXJzZSBpZiBldmVyeSBkZXZpY2Ug dHVybnMgb3V0IHRvIG5lZWQgYSB1bmlxdWUgY29tYmluYXRpb24gb2YKPiBzZXZlcmFsIGJlaGF2 aW91cnMsIHRoZW4gdGhlcmUgZW5kcyB1cCBiZWluZyBubyBwcmFjdGljYWwgZGlmZmVyZW5jZQo+ IGV4Y2VwdCB0aGF0IGl0J3MgcHJvYmFibHkgZWFzaWVyIHRvIGNvbWUgdXAgd2l0aCBuaWNlIG5h bWVzIHVuZGVyIHRoZQo+IGZpcnN0IHBhdHRlcm4uIEkgZ3Vlc3MgaXQncyB1cCB0byBob3cgeW91 IHNlZSB0aGlzIGRldmVsb3BpbmcgaW4KPiBmdXR1cmU7IHdoZXRoZXIgeW91J3JlIGxpa2VseSB0 byBuZWVkIGZpbmUtZ3JhaW5lZCBwZXItZGV2aWNlIGNvbnRyb2wsCj4gb3IgZG9uJ3QgZXhwZWN0 IGl0IHRvIGdvIG11Y2ggYmV5b25kIGRvbWFpbiB0eXBlLgo+IAoKVGhhbmtzIGZvciBleHBsYWlu aW5nICp0aGlzIHRoaW5nKiA6KQpJIHdpbGwgdXBkYXRlIHRoZSBwYXRjaCB0byBmb2xsb3cgdGhl IDJuZCBwYXR0ZXJuIGFzIGl0IG1ha2VzIG1vcmUgc2Vuc2UKdG8gZG9fdGhpcyBvciBkb190aGF0 IGRpcmVjdGx5LiBJJ20gbm90IGV4cGVjdGluZyBhbnl0aGluZyBvdGhlciB0aGFuCmRvbWFpbiB0 eXBlIGF0bGVhc3QgZm9yIG5vdyBidXQgaGV5IHdlIGNhbiBhbHdheXMgYWRkIHRoZSBmdW5jdGlv bmFsaXR5CmlmIHRoZSBuZWVkIGFyaXNlcy4KClRoYW5rcywKU2FpCgotLSAKUVVBTENPTU0gSU5E SUEsIG9uIGJlaGFsZiBvZiBRdWFsY29tbSBJbm5vdmF0aW9uIENlbnRlciwgSW5jLiBpcyBhIApt ZW1iZXIKb2YgQ29kZSBBdXJvcmEgRm9ydW0sIGhvc3RlZCBieSBUaGUgTGludXggRm91bmRhdGlv bgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppb21tdSBt YWlsaW5nIGxpc3QKaW9tbXVAbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0 cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vaW9tbXU= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E653C352BE for ; Thu, 16 Apr 2020 17:44:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1454E2223D for ; Thu, 16 Apr 2020 17:44:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rDAAR728"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="PUHWviB3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1454E2223D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+yfaw9qZDb81CwLdnLbTrD2nmeeybLEP1lIr2JK4mOw=; b=rDAAR728HLrF/UShcgmWW4/Pz gAPtgsC+8op5qjYpoI2DM5cIhsZtOc899e/mVSy1QJxBBqkgflT58OCQqmUrK+Fcy7F7RU87jWSaS vQpKzSyt7dDfwHiRacrp6RVD48tJf1XGcPj3dR3mmXXI53vNTrcw88KV2kjfNbO5CxgZGzhjH1dy8 JkOpCPOw/BuDIo11L1UuRVFIoFtpKLfqsAdmNgaPdpfa4CFHFInBlZQHbw9V4yOXLUa69zMqkunTz CyiVWgSUgcgyDN8fCmmdyQW5y+ZC5wQSSJ1Ms7Uj2ZhPQaH7BdCMuD5AVsSv/UUOpxxz17M4JaPAn LgPLhjQWQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP8YW-0004Ib-Fb; Thu, 16 Apr 2020 17:44:04 +0000 Received: from mail27.static.mailgun.info ([104.130.122.27]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP8YR-0004H7-Rj for linux-arm-kernel@lists.infradead.org; Thu, 16 Apr 2020 17:44:01 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1587059034; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=JC4ZwghNo+JEiak2hmqi7d8kddFUllqOr9vrtZr5HYE=; b=PUHWviB301gHpl5zEDltRzN5rFB5W7Z9YMtUlsR4WOfQ2ArYBhxyfoO3ob++yN/tXgmjOZ/v tpwHTMievEp8QQHvxcXF+/2kjY+sS4ZD0P6hGAdyP/tpUq+Dnqs7cXH+t6HwqVlE2WXrNUR2 IZt4FgIwwYwG+zkfTFSRjCi/9HI= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e989958.7fbdf8c54dc0-smtp-out-n04; Thu, 16 Apr 2020 17:43:52 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 71DDEC44793; Thu, 16 Apr 2020 17:43:52 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7D284C4478C; Thu, 16 Apr 2020 17:43:50 +0000 (UTC) MIME-Version: 1.0 Date: Thu, 16 Apr 2020 23:13:50 +0530 From: Sai Prakash Ranjan To: Robin Murphy Subject: Re: [PATCH 2/2] iommu/arm-smmu: Allow client devices to select direct mapping In-Reply-To: References: <813cc5b2da10c27db982254b274bf26008a9e6da.1579692800.git.saiprakash.ranjan@codeaurora.org> <3f12cefb-3887-859c-ddf5-c7a0fc755152@arm.com> <540fc55811d0a60a929ff1f694d6d271@codeaurora.org> Message-ID: X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200416_104359_959012_3436BB4D X-CRM114-Status: GOOD ( 24.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rajendra Nayak , linux-arm-msm@vger.kernel.org, Joerg Roedel , Jordan Crouse , iommu@lists.linux-foundation.org, Tomasz Figa , Rob Clark , Matthias Kaehlcke , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, Stephen Boyd , Will Deacon , linux-kernel@vger.kernel.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUm9iaW4sCgpPbiAyMDIwLTA0LTE2IDIyOjQ3LCBSb2JpbiBNdXJwaHkgd3JvdGU6Cj4gT24g MjAyMC0wNC0xNiA1OjIzIHBtLCBTYWkgUHJha2FzaCBSYW5qYW4gd3JvdGU6Cj4+IEhpIFJvYmlu LAo+PiAKPj4gT24gMjAyMC0wNC0xNiAxOToyOCwgUm9iaW4gTXVycGh5IHdyb3RlOgo+Pj4gT24g MjAyMC0wMS0yMiAxMTo0OCBhbSwgU2FpIFByYWthc2ggUmFuamFuIHdyb3RlOgo+Pj4+IEZyb206 IEpvcmRhbiBDcm91c2UgPGpjcm91c2VAY29kZWF1cm9yYS5vcmc+Cj4+Pj4gCj4+Pj4gU29tZSBj bGllbnQgZGV2aWNlcyB3YW50IHRvIGRpcmVjdGx5IG1hcCB0aGUgSU9NTVUgdGhlbXNlbHZlcyAK Pj4+PiBpbnN0ZWFkCj4+Pj4gb2YgdXNpbmcgdGhlIERNQSBkb21haW4uIEFsbG93IHRob3NlIGRl dmljZXMgdG8gb3B0IGluIHRvIGRpcmVjdAo+Pj4+IG1hcHBpbmcgYnkgd2F5IG9mIGEgbGlzdCBv ZiBjb21wYXRpYmxlIHN0cmluZ3MuCj4+Pj4gCj4+Pj4gU2lnbmVkLW9mZi1ieTogSm9yZGFuIENy b3VzZSA8amNyb3VzZUBjb2RlYXVyb3JhLm9yZz4KPj4+PiBDby1kZXZlbG9wZWQtYnk6IFNhaSBQ cmFrYXNoIFJhbmphbiAKPj4+PiA8c2FpcHJha2FzaC5yYW5qYW5AY29kZWF1cm9yYS5vcmc+Cj4+ Pj4gU2lnbmVkLW9mZi1ieTogU2FpIFByYWthc2ggUmFuamFuIDxzYWlwcmFrYXNoLnJhbmphbkBj b2RlYXVyb3JhLm9yZz4KPj4+PiAtLS0KPj4+PiDCoCBkcml2ZXJzL2lvbW11L2FybS1zbW11LXFj b20uYyB8IDM5IAo+Pj4+ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4+Pj4g wqAgZHJpdmVycy9pb21tdS9hcm0tc21tdS5jwqDCoMKgwqDCoCB8wqAgMyArKysKPj4+PiDCoCBk cml2ZXJzL2lvbW11L2FybS1zbW11LmjCoMKgwqDCoMKgIHzCoCA1ICsrKysrCj4+Pj4gwqAgMyBm aWxlcyBjaGFuZ2VkLCA0NyBpbnNlcnRpb25zKCspCj4+Pj4gCj4+Pj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvaW9tbXUvYXJtLXNtbXUtcWNvbS5jIAo+Pj4+IGIvZHJpdmVycy9pb21tdS9hcm0tc21t dS1xY29tLmMKPj4+PiBpbmRleCA2NGE0YWIyNzBhYjcuLmZmNzQ2YWNkMWM4MSAxMDA2NDQKPj4+ PiAtLS0gYS9kcml2ZXJzL2lvbW11L2FybS1zbW11LXFjb20uYwo+Pj4+ICsrKyBiL2RyaXZlcnMv aW9tbXUvYXJtLXNtbXUtcWNvbS5jCj4+Pj4gQEAgLTMsNiArMyw3IEBACj4+Pj4gwqDCoCAqIENv cHlyaWdodCAoYykgMjAxOSwgVGhlIExpbnV4IEZvdW5kYXRpb24uIEFsbCByaWdodHMgcmVzZXJ2 ZWQuCj4+Pj4gwqDCoCAqLwo+Pj4+IMKgICsjaW5jbHVkZSA8bGludXgvb2ZfZGV2aWNlLmg+Cj4+ Pj4gwqAgI2luY2x1ZGUgPGxpbnV4L3Fjb21fc2NtLmg+Cj4+Pj4gwqDCoMKgICNpbmNsdWRlICJh cm0tc21tdS5oIgo+Pj4+IEBAIC0xMSw2ICsxMiw0MyBAQCBzdHJ1Y3QgcWNvbV9zbW11IHsKPj4+ PiDCoMKgwqDCoMKgIHN0cnVjdCBhcm1fc21tdV9kZXZpY2Ugc21tdTsKPj4+PiDCoCB9Owo+Pj4+ IMKgICtzdGF0aWMgY29uc3Qgc3RydWN0IGFybV9zbW11X2NsaWVudF9tYXRjaF9kYXRhIHFjb21f YWRyZW5vID0gewo+Pj4+ICvCoMKgwqAgLmRpcmVjdF9tYXBwaW5nID0gdHJ1ZSwKPj4+PiArfTsK Pj4+PiArCj4+Pj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgYXJtX3NtbXVfY2xpZW50X21hdGNoX2Rh dGEgcWNvbV9tZHNzID0gewo+Pj4+ICvCoMKgwqAgLmRpcmVjdF9tYXBwaW5nID0gdHJ1ZSwKPj4+ PiArfTsKPj4+IAo+Pj4gTWlnaHQgaXQgbWFrZSBzZW5zZSB0byBncm91cCB0aGVzZSBieSB0aGUg ZGVzaXJlZCBTTU1VIGJlaGF2aW91cgo+Pj4gcmF0aGVyIHRoYW4gKGFwcGFyZW50bHkpIHdoYXQg a2luZCBvZiBkZXZpY2UgdGhlIGNsaWVudCBoYXBwZW5zIHRvIAo+Pj4gYmUsCj4+PiB3aGljaCBz ZWVtcyBsaWtlIGEgY29tcGxldGVseSBhcmJpdHJhcnkgZGlzdGluY3Rpb24gZnJvbSB0aGUgU01N VQo+Pj4gZHJpdmVyJ3MgUG9WPwo+Pj4gCj4+IAo+PiBTb3JyeSwgSSBkaWQgbm90IGdldCB0aGUg Imdyb3VwaW5nIGJ5IHRoZSBkZXNpcmVkIFNNTVUgYmVoYXZpb3VyIiAKPj4gdGhpbmcuCj4+IENv dWxkIHlvdSBwbGVhc2UgZ2l2ZSBzb21lIG1vcmUgZGV0YWlscz8KPiAKPiBJIG1lYW4gdGhpcyBw YXR0ZXJuOgo+IAo+IGRldmljZV9hX2RhdGEgewo+IAkudGhpbmcgPSB0aGlzOwo+IH0KPiAKPiBk ZXZpY2VfYl9kYXRhIHsKPiAJLnRoaW5nID0gdGhpczsKPiB9Cj4gCj4gZGV2aWNlX2NfZGF0YSB7 Cj4gCS50aGluZyA9IHRoYXQ7Cj4gfQo+IAo+IG1hdGNoW10gPSB7Cj4gCXsgLmNvbXBhdGlibGUg PSAiQSIsIC5kYXRhID0gJmRldmljZV9hX2RhdGEgfSwKPiAJeyAuY29tcGF0aWJsZSA9ICJCIiwg LmRhdGEgPSAmZGV2aWNlX2JfZGF0YSB9LAo+IAl7IC5jb21wYXRpYmxlID0gIkMiLCAuZGF0YSA9 ICZkZXZpY2VfY19kYXRhIH0sCj4gfTsKPiAKPiAuLi52cy4gdGhpcyBwYXR0ZXJuOgo+IAo+IGRv X3RoaXMgewo+IAkudGhpbmcgPSB0aGlzOwo+IH0KPiAKPiBkb190aGF0IHsKPiAJLnRoaW5nID0g dGhhdDsKPiB9Cj4gCj4gbWF0Y2hbXSA9IHsKPiAJeyAuY29tcGF0aWJsZSA9ICJBIiwgLmRhdGEg PSAmZG9fdGhpcyB9LAo+IAl7IC5jb21wYXRpYmxlID0gIkIiLCAuZGF0YSA9ICZkb190aGlzIH0s Cj4gCXsgLmNvbXBhdGlibGUgPSAiQyIsIC5kYXRhID0gJmRvX3RoYXQgfSwKPiB9Owo+IAo+IEZy b20gdGhlIHBlcnNwZWN0aXZlIG9mIHRoZSB0aGluZyBkb2luZyB0aGUgdGhpbmcsIGdyb3VwaW5n IHRoZSBkYXRhCj4gYnkgZGV2aWNlIGlzIG1lYW5pbmdsZXNzIGlmIGFsbCB0aGF0IG1hdHRlcnMg aXMgd2hldGhlciB0byBkbyB0aGlzIG9yCj4gdGhhdC4gVGhlIHNlY29uZCBwYXR0ZXJuIGV4cHJl c3NlcyB0aGF0IG1vcmUgbmF0dXJhbGx5Lgo+IAo+IE9mIGNvdXJzZSBpZiBldmVyeSBkZXZpY2Ug dHVybnMgb3V0IHRvIG5lZWQgYSB1bmlxdWUgY29tYmluYXRpb24gb2YKPiBzZXZlcmFsIGJlaGF2 aW91cnMsIHRoZW4gdGhlcmUgZW5kcyB1cCBiZWluZyBubyBwcmFjdGljYWwgZGlmZmVyZW5jZQo+ IGV4Y2VwdCB0aGF0IGl0J3MgcHJvYmFibHkgZWFzaWVyIHRvIGNvbWUgdXAgd2l0aCBuaWNlIG5h bWVzIHVuZGVyIHRoZQo+IGZpcnN0IHBhdHRlcm4uIEkgZ3Vlc3MgaXQncyB1cCB0byBob3cgeW91 IHNlZSB0aGlzIGRldmVsb3BpbmcgaW4KPiBmdXR1cmU7IHdoZXRoZXIgeW91J3JlIGxpa2VseSB0 byBuZWVkIGZpbmUtZ3JhaW5lZCBwZXItZGV2aWNlIGNvbnRyb2wsCj4gb3IgZG9uJ3QgZXhwZWN0 IGl0IHRvIGdvIG11Y2ggYmV5b25kIGRvbWFpbiB0eXBlLgo+IAoKVGhhbmtzIGZvciBleHBsYWlu aW5nICp0aGlzIHRoaW5nKiA6KQpJIHdpbGwgdXBkYXRlIHRoZSBwYXRjaCB0byBmb2xsb3cgdGhl IDJuZCBwYXR0ZXJuIGFzIGl0IG1ha2VzIG1vcmUgc2Vuc2UKdG8gZG9fdGhpcyBvciBkb190aGF0 IGRpcmVjdGx5LiBJJ20gbm90IGV4cGVjdGluZyBhbnl0aGluZyBvdGhlciB0aGFuCmRvbWFpbiB0 eXBlIGF0bGVhc3QgZm9yIG5vdyBidXQgaGV5IHdlIGNhbiBhbHdheXMgYWRkIHRoZSBmdW5jdGlv bmFsaXR5CmlmIHRoZSBuZWVkIGFyaXNlcy4KClRoYW5rcywKU2FpCgotLSAKUVVBTENPTU0gSU5E SUEsIG9uIGJlaGFsZiBvZiBRdWFsY29tbSBJbm5vdmF0aW9uIENlbnRlciwgSW5jLiBpcyBhIApt ZW1iZXIKb2YgQ29kZSBBdXJvcmEgRm9ydW0sIGhvc3RlZCBieSBUaGUgTGludXggRm91bmRhdGlv bgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo=