From: "Ron Rindjunsky" <ron.rindjunsky@intel.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: "Winkler, Tomas" <tomas.winkler@intel.com>,
"Chatre, Reinette" <reinette.chatre@intel.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net
Subject: Re: [PATCH 05/11] mac80211: adding mac80211_tx_control_flags andHT flags
Date: Wed, 5 Mar 2008 13:59:19 +0200 [thread overview]
Message-ID: <c85cb4470803050359x398a685ekb1b94de6cf65ad62@mail.gmail.com> (raw)
In-Reply-To: <1204715685.25502.66.camel@johannes.berg>
> > > It seems to me that these flags aren't entirely orthogonal to the
> > > bitrates?
> >
> > no, they are all orthogonal to each other. the example you gave will
> > give us 108MBit. all flags can be used, as long they match the spec,
> > and that's the algorithm responsibility to check and determine.
> > I guess that the flag that is more confusing is OFDM_HT. since 11n
> > supports (theoretically...) n streams of data, using flags like SISO /
> > MIMO / MIMO_3_ANT / MIMO_... seemed the wrong way. in stead, once you
> > know OFDM_HT is up, a check to antenna_sel_tx will determine the Tx
> > expected method.
>
> Ahh! Ok, thanks for the explanation. Is antenna_sel_tx really the right
> thing though? Tomas mentioned that you can have three antennas and only
> two chains so should that rather be a chain selection?
>
yes, this is correct from low level driver's perspective, but i think
that from rate scaling perspective keeping the antenna term is clearer
then a chain.
> > It may be good to add this to the file's documentation.
>
> Indeed. Or to a DOC: section somewhere so it can be added to an 11n
> chapter of the mac80211 book (since the patch is merged I'm
> automatically generating it nightly at
> http://linuxwireless.org/mac80211book/)
>
I'll make a patch with the explanation
next prev parent reply other threads:[~2008-03-05 11:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-05 2:09 [PATCH 0/11] iwlwifi driver updates Reinette Chatre
2008-03-05 2:09 ` [PATCH 01/11] iwlwifi: removing unused priv->config Reinette Chatre
2008-03-05 2:09 ` [PATCH 02/11] iwlwifi: refactor init geos function Reinette Chatre
2008-03-05 2:09 ` [PATCH 03/11] iwlwifi: Fix 52 rate report in rx status Reinette Chatre
2008-03-05 2:09 ` [PATCH 04/11] iwlwifi: 802.11n spec removes AUTO offset for FAT channel Reinette Chatre
2008-03-05 2:09 ` [PATCH 05/11] mac80211: adding mac80211_tx_control_flags and HT flags Reinette Chatre
2008-03-05 2:09 ` [PATCH 06/11] iwlwifi: use mac80211_tx_control_flags Reinette Chatre
2008-03-05 2:09 ` [PATCH 07/11] iwlwifi: extract iwl-csr.h Reinette Chatre
2008-03-05 2:09 ` [PATCH 08/11] iwlwifi: Move HBUS address to iwl-csr.h Reinette Chatre
2008-03-05 2:09 ` [PATCH 09/11] iwlwifi: add struct iwl_cfg Reinette Chatre
2008-03-05 2:09 ` [PATCH 10/11] iwlwifi: Take the fw file name from the iwl_cfg Reinette Chatre
2008-03-05 2:09 ` [PATCH 11/11] iwlwifi: Cancel scanning upon association Reinette Chatre
2008-03-05 9:41 ` [PATCH 05/11] mac80211: adding mac80211_tx_control_flags and HT flags Johannes Berg
2008-03-05 10:00 ` Ron Rindjunsky
2008-03-05 10:03 ` Johannes Berg
2008-03-05 10:29 ` [PATCH 05/11] mac80211: adding mac80211_tx_control_flags andHT flags Winkler, Tomas
2008-03-05 10:42 ` Johannes Berg
2008-03-05 11:01 ` Ron Rindjunsky
2008-03-05 11:14 ` Johannes Berg
2008-03-05 11:59 ` Ron Rindjunsky [this message]
2008-03-05 12:27 ` Johannes Berg
2008-03-05 4:22 ` [PATCH 0/11] iwlwifi driver updates Chatre, Reinette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c85cb4470803050359x398a685ekb1b94de6cf65ad62@mail.gmail.com \
--to=ron.rindjunsky@intel.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.