From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f179.google.com (mail-dy1-f179.google.com [74.125.82.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4312036308F for ; Fri, 15 May 2026 01:42:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778809326; cv=none; b=mb6nduVBxf8TEWLwITRV6YZihX18J+HpiFUAGNVR39Mt6SBfMnZZ4ITKTzaJlURJg5lkenT0SF5gL7lIucCVnvBN5+nTrVmGr8NBciPSGLz1e8YZOPLuLWxGLQ/GGzDazgeRLzfvzK9KmzuFlTiZmjxDo9K71B8IEEq/eVtjFMw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778809326; c=relaxed/simple; bh=ps5vk+VM+L+FYx4u5/RRqT+x6dzgOu/6OyG21fXaQSQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OfQWG9c6M/ioxU2aVw6ayp7/CxfewTno1B4NL9G8gZMbrD3+0d0nHOPdHm7bzF+lUaZfG0bP1nBFz82LjI+752OwdKW9AbVcVsj/GeO9afWQsRxf/fFJZaWc0Q51dI05HMum6UgwHtH7rOgApkIbhQHHCy21e5tdIWD4MwbtyxA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BMMO4HrI; arc=none smtp.client-ip=74.125.82.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BMMO4HrI" Received: by mail-dy1-f179.google.com with SMTP id 5a478bee46e88-2f7020a928eso12224606eec.1 for ; Thu, 14 May 2026 18:42:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778809324; x=1779414124; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=c/M7qvOw5n8r3Pyepd0iOKMjChQQQyNXJWeh8BJrPZk=; b=BMMO4HrIwtd5O9atgkUIEMXa4aGNXdFBUrrGUD1m527X3/vlJLf2yj2HjDWBhJH1td laNW/ww8g7lu3lkOVuTI/l1zYVkHSfkSZqYpFcenhlqgI0xxzPr1+KzHfROD2vzz3zBw ZPT14Ss3ZPynP9z7Ged66gIA5EM9CVmmGpLB5Y3jz503yP07Gon1OQUgWVkHpdjouyKG yFPE8kroO3f8eqsGhCHjhk6mAQTL1Cy10WLM4hNdRvDbEXQBaO+fWNd21uesj3lWGLPb DgT/Y5EcSXIZZLOdxhVPelqQKUX6pRdwOP9KszL7QdD1dQEVQvGvqJ4dyHtJNJUjClgR xXaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778809324; x=1779414124; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=c/M7qvOw5n8r3Pyepd0iOKMjChQQQyNXJWeh8BJrPZk=; b=JDx11ni3IvL8upe0VaUhBd2do1XCWSIhCqIyOXzoDQN3Ry/C65PTA93j1uGz1eYAp+ La1TOqviZj3N7TIAiSS61j194EZkj3bOgd4sxRRxRNpZWu2sXpY9Wx1NKynCURZ/bWKe WVpz3DwkSsFCnGg5qYbkiXmSQJUAhw6flHLTesXEOdEOtJ2CSW2hVpgPx45BexTQSUOj J0cYtAINr/8RRWLHgd92GeJQgbawxXyzpamIXZxvbPpyyvB+Jb+9chkkncL46W1XmlVI MrVGHQKAYy0KxBFHRp8Bk4gI2GNLfOGJhk8Q3scgPcMD1SZ8zhezEE9yzsnA4gkM0Ucg 9plQ== X-Forwarded-Encrypted: i=1; AFNElJ+XrZALGl1E17wOLjtGg6s/KRrHBFM9kX+kel2+rb/8tYjWI4baQxkDlz9oMF8nAVWPnx0DKj9LBBl1TZM=@vger.kernel.org X-Gm-Message-State: AOJu0YxvymZNRhxITX6EySCR0j2qwiFDIFtVZ3OQZh31cs15KAx06cvm XFiHrQ8U5RG9O8eat+c4huPNRyCiGNWINetzmp+RqCl3TcKzRzec8XO2 X-Gm-Gg: Acq92OF4/uGPfnE18yAQLxP01BpF+oIyaHvfib1mR9xYgKZ8JQBQ05xPo/x4bZfAjxf Yznetx7xtAiTAZZeU0NA23e8mUiM7hbIrSSdfbcqXYxjwuNmAIitKVXOqXJwQQMb7b84tO7Ivk+ d9UEpuxERuFHr/uwH3MOV88vOnwlwsy5Gae/IZq6prH3g3iXgGjongHAgoiRqi5YI1YXDIDW/9v 6j4wsBOWc3J5VYXNrELhe//Q01zz1IlNEFj9lNLXVAU5iY4xVWFkvTsUY2RgXXc9CpiviSc2S89 aESOPtNAdhshy88u8MyACVpuCsF+QHsVQXBqPa6EWfgsiwH20Oj0ujw17qYf6pY42R59aSWz6CA vS1pTaUoWdd1xbODpNH68I9lPSzeTecHtDmL1EpmOS9WxSUt+aD/hSRIEUDq8M9+vSCIlEPZP7e n74U+e/6WaqX1/eZgfB8eJklXogd3EOalg0/o3 X-Received: by 2002:a05:7022:7a2:b0:134:ff2e:a71c with SMTP id a92af1059eb24-1350430e5acmr764440c88.9.1778809324186; Thu, 14 May 2026 18:42:04 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-134cc2352f2sm7253756c88.10.2026.05.14.18.42.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 18:42:03 -0700 (PDT) Sender: Guenter Roeck Date: Thu, 14 May 2026 18:42:02 -0700 From: Guenter Roeck To: Abdurrahman Hussain Cc: Alexandru Tachici , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/5] hwmon: (pmbus/adm1266) add firmware_revision debugfs entry Message-ID: References: <20260512-adm1266-v3-0-a81a479b0bb0@nexthop.ai> <20260512-adm1266-v3-1-a81a479b0bb0@nexthop.ai> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260512-adm1266-v3-1-a81a479b0bb0@nexthop.ai> On Tue, May 12, 2026 at 11:56:24AM -0700, Abdurrahman Hussain wrote: > The ADM1266 reports its firmware revision via the IC_DEVICE_REV > manufacturer-specific block-read command (0xAE, datasheet Rev. D > Table 80). The first three returned bytes are the firmware > major.minor.patch fields. This is useful when correlating field > behaviour against ADI release notes; expose it through debugfs > alongside the existing sequencer_state entry. > > The standard PMBus MFR_REVISION (0x9B) register is already exposed > by pmbus_core's debugfs auto-create path and reports the > manufacturer revision, which is a separate thing from the firmware > running on the device. > > Signed-off-by: Abdurrahman Hussain Applied to hwmon-next. Thanks, Guenter