From: Finn Thain <fthain@linux-m68k.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nubus: Don't list card resources by default
Date: Fri, 24 Mar 2023 11:08:21 +1100 (AEDT) [thread overview]
Message-ID: <c882ca59-e75d-7ca2-d63f-70aab1b46ade@linux-m68k.org> (raw)
In-Reply-To: <CAMuHMdUQ3+OUKZ-6DqcJfMgq8_90Cejzc=onhUmbaYTWJkZHRw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 985 bytes --]
On Thu, 23 Mar 2023, Geert Uytterhoeven wrote:
> On Thu, Mar 23, 2023 at 9:39 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
> > On Mär 23 2023, Finn Thain wrote:
> >
> > > Checkpatch says "externs should be avoided in .c files" and if this one
> > > appeared twice I would agree. But as it only appears once, I can't see
> > > any advantage to putting it in a new .h file instead of the .c file...
> >
> > Anything wrong with declaring it in <linux/nubus.h>?
>
> It's not meant for NuBus device drivers (at least in its current form).
> So a drivers/nubus/nubus.h would be the most logical place.
>
I think Andreas is right inasmuchas the existing prototypes shared between
drivers/nubus/nubus.c and drivers/nubus/proc.c are found there, and this
extern is another one of those.
But I take Geert's point that much of include/linux/nubus.h could be moved
to drivers/nubus/something.h. But is there anything to be gained from
splitting it up that way?
next prev parent reply other threads:[~2023-03-24 0:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 6:03 [PATCH v2] nubus: Don't list card resources by default Finn Thain
2023-03-23 8:19 ` Geert Uytterhoeven
2023-03-23 23:13 ` Finn Thain
2023-03-24 8:59 ` Brad Boyer
2023-03-24 23:35 ` Finn Thain
2023-03-25 12:44 ` Geert Uytterhoeven
2023-03-26 0:03 ` Brad Boyer
2023-03-26 8:23 ` Geert Uytterhoeven
2023-03-26 0:00 ` Brad Boyer
2023-03-26 3:22 ` Finn Thain
2023-03-23 8:39 ` Andreas Schwab
2023-03-23 8:41 ` Geert Uytterhoeven
2023-03-24 0:08 ` Finn Thain [this message]
2023-03-24 8:26 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c882ca59-e75d-7ca2-d63f-70aab1b46ade@linux-m68k.org \
--to=fthain@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.