From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2 2/2] devtools: improve kernel script execution check Date: Thu, 19 Apr 2018 14:24:46 +0100 Message-ID: References: <1524139203-92094-1-git-send-email-juhamatti.kuusisaari@coriant.com> <1524139203-92094-2-git-send-email-juhamatti.kuusisaari@coriant.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Juhamatti Kuusisaari , thomas@monjalon.net Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 98B6E7F58 for ; Thu, 19 Apr 2018 15:24:49 +0200 (CEST) In-Reply-To: <1524139203-92094-2-git-send-email-juhamatti.kuusisaari@coriant.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/19/2018 1:00 PM, Juhamatti Kuusisaari wrote: > Handle properly a case where DPDK_MAINTAINER_PATH is set > to point to a directory. > > Signed-off-by: Juhamatti Kuusisaari > --- > devtools/get-maintainer.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/devtools/get-maintainer.sh b/devtools/get-maintainer.sh > index 1e9eabd..b916048 100755 > --- a/devtools/get-maintainer.sh > +++ b/devtools/get-maintainer.sh > @@ -23,7 +23,8 @@ print_usage () { > } > > # Requires DPDK_GETMAINTAINER_PATH devel config option set > -if [ ! -x "$DPDK_GETMAINTAINER_PATH" ] ; then > +if [ ! -f "$DPDK_GETMAINTAINER_PATH" ] || > + [ ! -x "$DPDK_GETMAINTAINER_PATH" ] ; then This isn't an issue but is there a reason that for exact same check you go with single line check in checkpatches.sh and multi line check in this file? > print_usage >&2 > echo > echo 'Cannot execute DPDK_GETMAINTAINER_PATH' >&2 >