From: Jan Beulich <jbeulich@suse.com>
To: Sergiy Kibrik <sergiy_kibrik@epam.com>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org
Subject: Re: [XEN PATCH v2 5/5] x86/MCE: optional build of AMD/Intel MCE code
Date: Tue, 14 May 2024 09:05:40 +0200 [thread overview]
Message-ID: <c8a4ab8e-786a-4e85-80d4-4da0ea5d9129@suse.com> (raw)
In-Reply-To: <63dc5c56-19e4-405d-a016-03175dd704bf@epam.com>
On 13.05.2024 11:11, Sergiy Kibrik wrote:
> 06.05.24 14:32, Jan Beulich:
>> On 02.05.2024 11:21, Sergiy Kibrik wrote:
>>> Also global Intel-specific variables lmce_support & cmci_support have to be
>>> redefined if !INTEL, as they get checked in common code.
>>
>> Them being checked in common code may have different resolution strategies.
>> The justification here imo is that, right now, both variables are only ever
>> written by mce_intel.c. As mentioned for vmce_has_lmce(), there's nothing
>> fundamentally preventing MCG_CAP from having respective bits set on a non-
>> Intel CPU.
>>
>
> so could these global variables just be moved to common code then? Like
> arch/x86/cpu/mcheck/mce.c ?
That would likely be a better approach, yes.
Jan
prev parent reply other threads:[~2024-05-14 7:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 9:10 [XEN PATCH v2 0/5] x86: make Intel/AMD vPMU & MCE support configurable Sergiy Kibrik
2024-05-02 9:12 ` [XEN PATCH v2 1/5] x86/vpmu: separate amd/intel vPMU code Sergiy Kibrik
2024-05-06 11:09 ` Jan Beulich
2024-05-02 9:14 ` [XEN PATCH v2 2/5] x86/intel: move vmce_has_lmce() routine to header Sergiy Kibrik
2024-05-06 11:18 ` Jan Beulich
2024-05-13 8:23 ` Sergiy Kibrik
2024-05-02 9:16 ` [XEN PATCH v2 3/5] x86/MCE: guard access to Intel/AMD-specific MCA MSRs Sergiy Kibrik
2024-05-06 11:20 ` Jan Beulich
2024-05-02 9:18 ` [XEN PATCH v2 4/5] x86/MCE: guard {intel/amd}_mcheck_init() calls Sergiy Kibrik
2024-05-06 11:22 ` Jan Beulich
2024-05-02 9:21 ` [XEN PATCH v2 5/5] x86/MCE: optional build of AMD/Intel MCE code Sergiy Kibrik
2024-05-06 11:32 ` Jan Beulich
2024-05-13 9:11 ` Sergiy Kibrik
2024-05-14 7:05 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8a4ab8e-786a-4e85-80d4-4da0ea5d9129@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=sergiy_kibrik@epam.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.