All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luka Gejak" <luka.gejak@linux.dev>
To: "Mehmet Fide" <mehmet.fide@gmail.com>,
	"Johannes Berg" <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	mehmet.fide@screeningeagle.com
Subject: Re: [PATCH wireless] wifi: mac80211: abort chanswitch when leaving an IBSS
Date: Mon, 26 Oct 2026 12:43:34 +0000	[thread overview]
Message-ID: <c8bc5affa75d7519b424ea98c07c1d6b65942347@linux.dev> (raw)
In-Reply-To: <20261025193615.1123718-1-mehmet.fide@gmail.com>

Hi Mehmet,

Thanks for picking this up. One comment below.

October 25, 2026 at 8:36 PM, "Mehmet Fide" <mehmet.fide@gmail.com> wrote:

> diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c
> index d74b66426349..b9ab4ceb0332 100644
> --- a/net/mac80211/ibss.c
> +++ b/net/mac80211/ibss.c
> @@ -669,6 +669,10 @@ static void ieee80211_ibss_disconnect(struct ieee80211_sub_if_data *sdata)
>       ifibss->state = IEEE80211_IBSS_MLME_SEARCH;
>
>       netif_carrier_off(sdata->dev);
> +
> +     sdata->vif.bss_conf.csa_active = false;
> +     ieee80211_vif_unblock_queues_csa(sdata);
> +

As far as I can see, the driver never finds out that the switch was
dropped here. ath9k_htc only clears priv->csa_vif once the countdown
completes with csa_active still set, or when the interface goes away.

So if I read it right, after leaving mid countdown and joining again, the
next switch with a countdown now gets past mac80211 and runs into this in
ath9k_htc_channel_switch_beacon():

        if (WARN_ON(priv->csa_vif))
                return;

Before this patch mac80211 stopped it earlier, so this couldn't happen in
IBSS. AP mode seems to have the same problem already after
ieee80211_stop_ap(), so I think it is better fixed in ath9k_htc, maybe by
dropping csa_vif when beaconing stops.

Since you have worked on ath9k already, would you be willing to send a
fix for that too?

Best regards,
Luka Gejak

  reply	other threads:[~2026-10-26 12:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-25 19:36 [PATCH wireless] wifi: mac80211: abort chanswitch when leaving an IBSS Mehmet Fide
2026-10-26 12:43 ` Luka Gejak [this message]
2026-10-26 15:25   ` Mehmet Fide
2026-10-27 10:01     ` Luka Gejak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8bc5affa75d7519b424ea98c07c1d6b65942347@linux.dev \
    --to=luka.gejak@linux.dev \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mehmet.fide@gmail.com \
    --cc=mehmet.fide@screeningeagle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.