From: Krzysztof Kozlowski <krzk@kernel.org>
To: "U, Pavithra" <Pavithra.U@analog.com>
Cc: "Miclaus, Antoniu" <Antoniu.Miclaus@analog.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: rtc: max31335: Add max31331 support
Date: Wed, 15 Jan 2025 17:07:11 +0100 [thread overview]
Message-ID: <c8d6117a-d48f-440e-a6b1-9770bf5fbc9f@kernel.org> (raw)
In-Reply-To: <LV8PR03MB73752CF2725AF0CB79A5A8EBE5192@LV8PR03MB7375.namprd03.prod.outlook.com>
On 15/01/2025 11:21, U, Pavithra wrote:
>>>
>>> interrupts:
>>> maxItems: 1
>>> @@ -57,9 +60,9 @@ examples:
>>> #address-cells = <1>;
>>> #size-cells = <0>;
>>>
>>> - rtc@68 {
>>> + rtc@69 {
>>> compatible = "adi,max31335";
>>> - reg = <0x68>;
>>> + reg = <0x69>;
>>
>> Why? I already asked about this - the same question "Why"
>
> While testing, it was identified that the i2c address for max31335 is 0x69. Sorry, I will revert and send the fix in a separate patch.
Yes, please.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-15 16:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 10:29 [PATCH v3 0/2] Add support for MAX31331 RTC PavithraUdayakumar-adi
2025-01-09 10:29 ` PavithraUdayakumar-adi via B4 Relay
2025-01-09 10:29 ` [PATCH v3 1/2] dt-bindings: rtc: max31335: Add max31331 support PavithraUdayakumar-adi
2025-01-09 10:29 ` PavithraUdayakumar-adi via B4 Relay
2025-01-10 8:35 ` Krzysztof Kozlowski
2025-01-15 10:21 ` U, Pavithra
2025-01-15 16:07 ` Krzysztof Kozlowski [this message]
2025-01-09 10:29 ` [PATCH v3 2/2] rtc: max31335: Add driver support for max31331 PavithraUdayakumar-adi
2025-01-09 10:29 ` PavithraUdayakumar-adi via B4 Relay
2025-01-16 8:16 ` Nuno Sá
2025-01-10 8:32 ` [PATCH v3 0/2] Add support for MAX31331 RTC Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8d6117a-d48f-440e-a6b1-9770bf5fbc9f@kernel.org \
--to=krzk@kernel.org \
--cc=Antoniu.Miclaus@analog.com \
--cc=Pavithra.U@analog.com \
--cc=alexandre.belloni@bootlin.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.