From: Jan Beulich <jbeulich@suse.com>
To: "Petr Beneš" <w1benny@gmail.com>
Cc: Wei Liu <wl@xen.org>, Anthony PERARD <anthony.perard@citrix.com>,
Juergen Gross <jgross@suse.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2] libxl: Fix comment for LIBXL_HAVE_VMTRACE_BUF_KB
Date: Tue, 13 Feb 2024 16:27:06 +0100 [thread overview]
Message-ID: <c8d747a9-e164-460a-9e50-e976580d10ef@suse.com> (raw)
In-Reply-To: <CAKBKdXiZ1wcz7_GnUHUmuboTHHVEE03QPSeWhdRKMoV=o7nf3w@mail.gmail.com>
On 13.02.2024 16:08, Petr Beneš wrote:
>> On Tue, Feb 13, 2024 at 4:02 PM Jan Beulich <jbeulich@suse.com> wrote:
>>
>> On 13.02.2024 15:56, Petr Beneš wrote:
>>> From: Petr Beneš <w1benny@gmail.com>
>>>
>>> It's located in libxl_domain_build_info, not libxl_domain_create_info.
>>>
>>> Signed-off-by: Petr Beneš <w1benny@gmail.com>
>>> Acked-by: Anthony PERARD <anthony.perard@citrix.com>
>>
>> Any reason you didn't also add the Fixes: tag that Anthony suggested
>> to put there (for me to recognize that this may need backporting;
>> didn't check yet when that earlier commit went in)?
>
> Apologies. No other reason that it's my first experience with creating
> v2 patch and I honestly didn't know that the "Fixes: tag" suggestion
> was directed at me. How should I proceed from here?
I'll try to remember to insert it while committing.
Jan
next prev parent reply other threads:[~2024-02-13 15:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 14:56 [PATCH v2] libxl: Fix comment for LIBXL_HAVE_VMTRACE_BUF_KB Petr Beneš
2024-02-13 15:02 ` Jan Beulich
2024-02-13 15:08 ` Petr Beneš
2024-02-13 15:27 ` Jan Beulich [this message]
2024-02-13 15:36 ` Luca Fancellu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8d747a9-e164-460a-9e50-e976580d10ef@suse.com \
--to=jbeulich@suse.com \
--cc=anthony.perard@citrix.com \
--cc=jgross@suse.com \
--cc=w1benny@gmail.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.