From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shawn Guo <shengchao.guo@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh@kernel.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Stephan Gerhold <stephan@gerhold.net>,
Sibi Sankar <sibi.sankar@oss.qualcomm.com>,
Bartosz Golaszewski <brgl@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: remoteproc: qcom: Drop types for firmware-name
Date: Fri, 6 Mar 2026 15:12:54 +0100 [thread overview]
Message-ID: <c8d9258a-04d8-4841-be4e-7751acac2dae@kernel.org> (raw)
In-Reply-To: <20260306140306.1328719-1-shengchao.guo@oss.qualcomm.com>
On 06/03/2026 15:03, Shawn Guo wrote:
> The type of firmware-name is already defined by core schemas. Some of
> qcom remoteproc bindings define it redundantly, while others do not.
> Drop it to be consistent and avoid it being copied over to new files.
>
> Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
> ---
> .../devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml | 1 -
> .../devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml | 1 -
> .../devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml | 1 -
> .../devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml | 1 -
> .../devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml | 1 -
> .../devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml | 1 -
> Documentation/devicetree/bindings/remoteproc/qcom,sdx55-pas.yaml | 1 -
> .../devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml | 1 -
I was fixing all remoteprocs here:
https://lore.kernel.org/all/20240115182031.1610088-1-krzysztof.kozlowski@linaro.org/#r
so I am a bit confused how I missed these. Maybe at that time the
dtschema did not have definition and I postponed fixing these for later?
And then more wrong addons like sa8775p appeared...
> - $ref: /schemas/types.yaml#/definitions/string-array
> items:
> - description: Name of MBA firmware
> - description: Name of modem firmware
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
> index 5dbda3a55047..63ae3a30f626 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
> @@ -42,7 +42,6 @@ properties:
> description: Reference to the reserved-memory for the Hexagon core
>
> firmware-name:
> - $ref: /schemas/types.yaml#/definitions/string
> description: Firmware name for the Hexagon core
This and other needs fixes, look at my commit.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-03-06 14:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 14:03 [PATCH] dt-bindings: remoteproc: qcom: Drop types for firmware-name Shawn Guo
2026-03-06 14:12 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8d9258a-04d8-4841-be4e-7751acac2dae@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=robh@kernel.org \
--cc=shengchao.guo@oss.qualcomm.com \
--cc=sibi.sankar@oss.qualcomm.com \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.