From mboxrd@z Thu Jan 1 00:00:00 1970 From: Segher Boessenkool Subject: Re: [PATCH v2] [2.6.22] pasemi: cpufreq driver Date: Thu, 26 Apr 2007 21:05:59 +0200 Message-ID: References: <20070425204633.GC19781@lixom.net> <200704261055.33739.arnd@arndb.de> <20070426164835.GA14149@lixom.net> <200704261911.22553.arnd@arndb.de> Mime-Version: 1.0 (Apple Message framework v623) Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200704261911.22553.arnd@arndb.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org To: Arnd Bergmann Cc: Olof Johansson , linuxppc-dev@ozlabs.org, egor@pasemi.com, paulus@samba.org, cpufreq@lists.linux.org.uk >> Unfortunately the setting of the current active state is done to an >> SDC >> register, while information of the states is in the PMU, so access to >> both is needed in the driver. > > One thing that you could do is to list only this one register of the > SDC in the reg property, not all of the SDC. The system-controller node should really describe all of the system controller. If the Linux driver needs to access two separate devices, it should really just do that. Don't try to make things "simpler" in the device tree. You probably should map the SDC registers in the platform startop code, and then have the various platform drivers use that. Maybe even do an abstraction ;-) Segher