From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CD7C37DAAD for ; Mon, 10 Aug 2026 16:42:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786380182; cv=none; b=Zqr/J0aN5+RShby9A+xtxZsqpDg8JrQs/FG7UDDEQfrpQxuYDzDsUPf2eyeipMERgB6Mo6HK2bT1hbC6UxWljdK/EbFbGksf39tIoamcVsVI1w4XjcuRukePCBW8TN2w36lgh41IP6GV7LEY0Ai635gI5U8NyrmRJBWghwleqjY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786380182; c=relaxed/simple; bh=qswzUvLeWzD1ypEyusL4JpuvZviHdsdZlDLSs8pxD1Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=W2o+gr1BPS1qJN8ByZxAqz0mtTe9zpHQjdsK56PfEDppXXGVmdsZCEW/ehEZwjJY6aVMSnnIexdifzv1gQkKc0p/G278+frvuV+9a5rzg2+/NvKx9+v0WXgMI/XM3ooNylv+Dfy/TEJhlOc8sIfMPOwD9/yiQKuANpRa7tmu7rQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=aeA02L7E; arc=none smtp.client-ip=209.85.210.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="aeA02L7E" Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-7eb61bbeb25so1382776a34.1 for ; Mon, 10 Aug 2026 09:42:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1786380176; x=1786984976; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=SF0UuKcYo2PEY9aDv0M4yYRYVyTu0AJ1rxJHPH4mQVc=; b=aeA02L7EvQN2bdibNcN4KqlRuYCVq3wgwHOuuGnrz3J88LwnPay54FF6zkDqA8eYh0 vbdOWfTmIz1bdwNJZIcobwTZL6Ql+ZUHtualTsqAn8+xogfK7TGHz3M1us6GxZHj1QFZ nVBE56zEGKRnbmSBmKV/995cThNOVPc/bdBr0iA+FhYJsVGyAXVldam5GqXwSNrkLoHz IFVDnqo1riis/fMhbkNF2u2Oq9ibNtCow9yaCBwB02+jlKLVxgiFUHBhBaojwl8KwyhS LakjXkjLSPLxmS1pEN9nJwIaFm+x/M/gjoOSFB4MeMyJK4KZ7KcPwdkdskKGQW0I4SlI Ju8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786380176; x=1786984976; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SF0UuKcYo2PEY9aDv0M4yYRYVyTu0AJ1rxJHPH4mQVc=; b=CUKXL69PDyo7b5wYOLU7qWmC5iBtHaDS7Ht61dEeBVgtQs+nDBSvjutV2FeQe3eqHn PgE4BY65aGAJcNRe1pbUJIpTGolIpGjR98wpL5uM2i1tzCiL1L3qaxIK62m9njdq9LXJ JToRARS2j0n4CKyuBH4aKY7RzltP3hLVRCDqXmfldB3kaIfSTuK/ci8piuGFNg5XuKAD ro7hfLm7JZIZnqbSkEiTl1wJyt8umqlDDeqjv4DfTK1cGqIw89fkFPRp68p4mrMF7Q9q i6HNro3+m/RKe4ucHuQy7BRk2oLtsStEdLBuszplhnnnZibqRItBPoGyIZxmg1cl1vlw JA4Q== X-Forwarded-Encrypted: i=1; AHgh+RowmVSuEHyNAMsbfrjadeCCi6zdnYMHiuaG6thKnP0smCkDOXt7FVp87n4ZeBY+90F28TQcAGaZv0zs@vger.kernel.org X-Gm-Message-State: AOJu0YzqhPgnkdVSs+l/eMkkAeo59CofD130QdL4WgIwY4z2vJw8pD0C WkqozT8h7mh47gr3QWvFotTRAqklkhP1/KkSigHPmLD5Fa42/F42joOXeeXRWV20g+s= X-Gm-Gg: AR+sD13pluPhL0zqqOMTLHtfiAnmI5D0D4vK+kfriwu1ueNnPF3Ds6jwQzoAMbtrw1r /ivWMm/GFf6zYnSrmCYXsb1Ms74gmrdlZ4w1oO3z+m7o8Cf8ybJZjm5yakMfb8WJwS1Ctybsjs6 Ck81nhmzzxwAmXheRW0sTaexz3u8lJgqQOwgG2NlRMl4E34wntnMn4EAKq+PUTox9U1D0tk5R0v Qkh7F8rXaya3ZZ+UJFQW+E7lhL5QEfL7FDxC5kEel5llZmvYfT0Eh9QOq5tM9r3XF2CK2NYstkb mjcs/5zuD1yowcgr2DpKODn2l6fozmBKZOOXct40Bo5A9pxi1yGPNB0SyCOcwy8tUQqVBYCzkQG WdRgfqr0vodWjk3D9pUz7ZqSdgRPeQSZQf4VGX7Z2gsOUnZlXI7vepjlZ2PbMqyrKxflWKwweEr TVkifc/9htRoaIZZdX93LHulp+yrcyB6PuwNP58vPhUQPjP2H4X6fpb/gP9faYpeOeZ6LkHj3Xg naZiH7TZ+RFPGYsGcx+lKVc8mTj3eBv4aEXkE0= X-Received: by 2002:a05:6830:6605:b0:7e9:d634:77b8 with SMTP id 46e09a7af769-7f34dcf165fmr18922818a34.2.1786380176296; Mon, 10 Aug 2026 09:42:56 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:e05b:7923:cf50:e4cf? ([2600:8803:e7e4:500:e05b:7923:cf50:e4cf]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7f35b5a836dsm7575949a34.12.2026.08.10.09.42.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Aug 2026 09:42:55 -0700 (PDT) Message-ID: Date: Mon, 10 Aug 2026 11:42:54 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/9] dt-bindings: iio: adc: support the TI ADS126x ADC family To: Kurt Borja , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski Cc: =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org References: <20260807-ads126x-v3-0-f89925d72792@gmail.com> <20260807-ads126x-v3-1-f89925d72792@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/9/26 3:26 AM, Kurt Borja wrote: > On Sat Aug 8, 2026 at 1:38 PM -05, David Lechner wrote: >> On 8/7/26 10:58 PM, Kurt Borja wrote: >>> The ADS1262 and ADS1263 are 32-bit, 38.4-kSPS delta-sigma ADCs with an >>> integrated PGA, internal reference, excitation and burn-out current >>> sources for sensor biasing and diagnostics. The ADS1263 adds a second, >>> 24-bit delta-sigma ADC (ADC2) for background measurements. >>> >> >> ... >> >>> +patternProperties: >>> + "^ain([0-9]|com)-supply$": >>> + description: >>> + Common-mode voltage supply connected to AIN or AINCOM. >>> + >>> + "^refp[1-3]-supply$": >>> + description: >>> + Positive voltage reference connected to REFP1 (AIN0), REFP2 (AIN2) or >>> + REFP3 (AIN4). If not described, its assumed to be connected to ground >>> + (0V). >> >> Would we really have a case with a negative only reference? I would say if not >> described, assume the pin is free for other use. > > In bipolar supply configurations, I believe it would make sense to wire > the negative reference to -2.5V and ground the positive. Also we have > the ti,reference-reversal case, where you may wire the "negative" > reference to say 2.5V and the positive to ground. > OK. I guess the better wording for both of these would be that if any channel references one of these in reference-sources and it is not present assume it is connected to ground (0V). >> >>> + >>> + "^refn[1-3]-supply$": >>> + description: >>> + Negative voltage reference connected to REFN1 (AIN1), REFN2 (AIN3) or >>> + REFN3 (AIN5). If not described, its assumed to be connected to ground >>> + (0V). >> >> Assumption is only true when corresponding refp supply is described. Otherwise >> we should assume the pin is free for other uses. > > I'll clarify it. > >> >>> + >>> + "^ti,refp[1-3]-refn[1-3]-resistor-ohms$": >>> + description: >>> + Magnitude of the external reference resistor connected between REFP >>> + and REFN. In ratiometric configurations, such as RTD measurements, the >>> + IDAC excitation current returns through this resistor, generating the >>> + reference voltage for the conversion. >>> + >>> + "^channel@[0-9]+$": >>> + $ref: /schemas/iio/adc/adc.yaml# >>> + unevaluatedProperties: false >>> + >>> + properties: >>> + reg: >>> + maxItems: 1 >>> + >>> + single-channel: >>> + minimum: 0 >>> + maximum: 10 >>> + >>> + common-mode-channel: >>> + minimum: 0 >>> + maximum: 10 >>> + default: 10 >>> + >>> + diff-channels: >>> + description: | >>> + In addition to the analog input pins 0 (AIN0) - 10 (AINCOM), there are >>> + special inputs that can be selected from the following values: >>> + 11: Temperature sensor monitor >>> + 12: Analog power supply monitor >>> + 13: Digital power supply monitor >>> + 14: TDAC test signal >> >> For reasons mentioned in the reply to the cover letter, I'm not a fan of the >> monitor channels here. >> >>> + items: >>> + minimum: 0 >>> + maximum: 14 >>> + >> >> ... >> >>> + input-chopping: true >>> + >>> + ti,idac-rotation: >> >> Should we make this one a standard property like input-chopping? > > Maybe excitation-current-chopping or excitation-channel-chopping? I suppose. All of the TI literature seems to call it "rotation" rather than "chopping", but I did find a few other sources that call it "chopping" and that would be consistent with input-chopping. I would go with excitation-channel-chopping since we are swapping the current generators, not just the current magnitude. > >> >>> + $ref: /schemas/types.yaml#/definitions/flag >>> + description: >>> + Automatically swap the IDAC1 and IDAC2 connections of alternate >>> + conversions. The ADC averages the alternate conversions to eliminate >>> + IDAC mismatch. >>> + >> >> ... >> >>> +examples: >>> + - | >>> + #include >>> + #include >>> + >>> + spi { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + adc@0 { >>> + compatible = "ti,ads1262"; >>> + reg = <0>; >>> + spi-max-frequency = <8000000>; >>> + spi-cpha; >>> + avdd-supply = <&avdd>; >>> + dvdd-supply = <&dvdd>; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + interrupts-extended = <&gpio 0 IRQ_TYPE_EDGE_FALLING>; >>> + interrupt-names = "drdy"; >>> + >>> + /* Typical common mode voltage configuration */ >>> + aincom-supply = <&ads1262_vbias>; >>> + >>> + regulators { >>> + ads1262_vbias: vbias { >>> + regulator-name = "vbias"; >> >> The node name is already "vbias" so giving regulator-name is redundant. > > Is it okay to leave it empty? > > ads1262_vbias: vbias { }; > Yes. (Unless make dt_binding_check says otherwise.) >> >>> + }; >>> + }; >>> + >>> + channel@0 { >>> + reg = <0>; >>> + single-channel = <0>; >>> + /* The VBIAS is enabled on pin 10 (AINCOM) */ >>> + common-mode-channel = <10>; >>> + }; >>> + }; >>> + }; >>> + >