From: Dave Hansen <dave.hansen@linux.intel.com>
To: Nadav Amit <namit@vmware.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
Andrea Arcangeli <aarcange@redhat.com>,
"luto@kernel.org" <luto@kernel.org>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"keescook@google.com" <keescook@google.com>,
"hughd@google.com" <hughd@google.com>,
"jgross@suse.com" <jgross@suse.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH 05/11] x86/mm: do not auto-massage page protections
Date: Fri, 23 Mar 2018 12:38:07 -0700 [thread overview]
Message-ID: <c911e7f5-32ba-fed7-c464-7e91584b0e55@linux.intel.com> (raw)
In-Reply-To: <D608FB5E-5254-4233-98DC-605EDEF24E9E@vmware.com>
On 03/23/2018 12:34 PM, Nadav Amit wrote:
>>>> + /* mmdebug.h can not be included here because of dependencies */
>>>> +#ifdef CONFIG_DEBUG_VM
>>>> + WARN_ONCE(pgprot_val(pgprot) != massaged_val,
>>>> + "attempted to set unsupported pgprot: %016lx "
>>>> + "bits: %016lx supported: %016lx\n",
>>>> + pgprot_val(pgprot),
>>>> + pgprot_val(pgprot) ^ massaged_val,
>>>> + __supported_pte_mask);
>>>> +#endif
>>> Why not to use VM_WARN_ON_ONCE() and avoid the ifdef?
>> I wanted a message. VM_WARN_ON_ONCE() doesn't let you give a message.
> Right (my bad). But VM_WARN_ONCE() lets you.
I put a comment in up there about this ^^. #including mmdebug.h caused
dependency problems, so I basically just reimplemented it using
WARN_ONCE() and an #ifdef.
next prev parent reply other threads:[~2018-03-23 19:38 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 17:44 [PATCH 00/11] Use global pages with PTI Dave Hansen
2018-03-23 17:44 ` [PATCH 01/11] x86/mm: factor out pageattr _PAGE_GLOBAL setting Dave Hansen
2018-03-23 17:44 ` [PATCH 02/11] x86/mm: undo double _PAGE_PSE clearing Dave Hansen
2018-03-23 17:44 ` [PATCH 03/11] x86/mm: introduce "default" kernel PTE mask Dave Hansen
2018-03-23 17:44 ` [PATCH 04/11] x86/espfix: document use of _PAGE_GLOBAL Dave Hansen
2018-03-23 17:44 ` [PATCH 05/11] x86/mm: do not auto-massage page protections Dave Hansen
2018-03-23 19:15 ` Nadav Amit
2018-03-23 19:26 ` Dave Hansen
2018-03-23 19:26 ` Dave Hansen
2018-03-23 19:34 ` Nadav Amit
2018-03-23 19:38 ` Dave Hansen [this message]
2018-03-24 15:10 ` kbuild test robot
2018-03-24 15:10 ` kbuild test robot
2018-03-24 15:21 ` kbuild test robot
2018-03-24 15:21 ` kbuild test robot
2018-03-23 17:44 ` [PATCH 06/11] x86/mm: remove extra filtering in pageattr code Dave Hansen
2018-03-23 17:44 ` [PATCH 07/11] x86/mm: comment _PAGE_GLOBAL mystery Dave Hansen
2018-03-23 17:44 ` [PATCH 08/11] x86/mm: do not forbid _PAGE_RW before init for __ro_after_init Dave Hansen
2018-03-23 17:45 ` [PATCH 09/11] x86/pti: enable global pages for shared areas Dave Hansen
2018-03-23 19:12 ` Nadav Amit
2018-03-23 19:36 ` Dave Hansen
2018-03-23 17:45 ` [PATCH 10/11] x86/pti: clear _PAGE_GLOBAL for kernel image Dave Hansen
2018-03-23 17:45 ` [PATCH 11/11] x86/pti: leave kernel text global for !PCID Dave Hansen
2018-03-23 18:26 ` [PATCH 00/11] Use global pages with PTI Linus Torvalds
2018-03-24 0:40 ` Dave Hansen
2018-03-24 0:46 ` Linus Torvalds
2018-03-24 0:54 ` Linus Torvalds
2018-03-24 11:05 ` Ingo Molnar
2018-03-27 13:36 ` Thomas Gleixner
2018-03-27 16:32 ` Dave Hansen
2018-03-27 17:51 ` Thomas Gleixner
2018-03-27 20:07 ` Ingo Molnar
2018-03-27 20:19 ` Dave Hansen
2018-03-29 0:17 ` Dave Hansen
2018-03-30 12:09 ` Ingo Molnar
2018-03-30 12:17 ` Ingo Molnar
2018-03-30 20:26 ` Dave Hansen
2018-03-30 20:32 ` Thomas Gleixner
2018-03-30 21:40 ` Dave Hansen
2018-03-31 5:39 ` Ingo Molnar
2018-03-31 18:19 ` Dave Hansen
-- strict thread matches above, loose matches on Subject: below --
2018-04-02 17:27 [PATCH 00/11] [v3] " Dave Hansen
2018-04-02 17:27 ` [PATCH 05/11] x86/mm: do not auto-massage page protections Dave Hansen
2018-04-04 1:09 [PATCH 00/11] [v4] Use global pages with PTI Dave Hansen
2018-04-04 1:09 ` [PATCH 05/11] x86/mm: do not auto-massage page protections Dave Hansen
2018-04-05 19:49 ` Tom Lendacky
2018-04-06 20:55 [PATCH 00/11] [v5] Use global pages with PTI Dave Hansen
2018-04-06 20:55 ` [PATCH 05/11] x86/mm: do not auto-massage page protections Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c911e7f5-32ba-fed7-c464-7e91584b0e55@linux.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=aarcange@redhat.com \
--cc=hughd@google.com \
--cc=jgross@suse.com \
--cc=keescook@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=namit@vmware.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.