Re: [PATCH net-next 2/2] dt-bindings: net: mxl: Add MxL LGM Network Processor SoC

[Krzysztof Kozlowski <krzk@kernel.org>]

On 22/08/2025 11:08, Jack Ping CHNG wrote:
> Introduce device-tree binding documentation for
> MaxLinear LGM Network Processor

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

Bindings go before the user (see submitting bindings in DT dir).

> 
> Signed-off-by: Jack Ping CHNG <jchng@maxlinear.com>
> ---
>  .../devicetree/bindings/net/mxl,lgm-eth.yaml  | 59 +++++++++++++++++++
>  1 file changed, 59 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/mxl,lgm-eth.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/mxl,lgm-eth.yaml b/Documentation/devicetree/bindings/net/mxl,lgm-eth.yaml
> new file mode 100644
> index 000000000000..3d5b32b5b650
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/mxl,lgm-eth.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/net/mxl,lgm-eth.yaml#"

You never tested it, did you?

> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"

Nope. Please point me to any example if such syntax.

I will finish the review here. I am sorry, but I think you really did
not put enough of effort into this. There are so many basic mistakes
here. Please watch my OSSE session explaining basics of bindings (or
read the slides - they are already published).


Best regards,
Krzysztof