From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F78021FF5D for ; Fri, 15 Aug 2025 10:39:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755254399; cv=none; b=Jj0+57lgd2XIlIa1I8jrHoHM2bLa4sEpDfnaWK3HeYgvCLCaI9NJSQxQBfvgEvIOSSCclKkntk0cyjOl8emsDNVM2A2n+TH0t/RqsAb+0iQ0kHqDpH1Tg927Mb2spWfmLtsYtIAlGnVYNKd6cQRamx8Y0F9HtGuOQeR7Fm68fuI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755254399; c=relaxed/simple; bh=o0qy4hIYEUwnQ5tOAtQG6KodJsJjY/1AFrWA8nZR51E=; h=Message-ID:Date:MIME-Version:Subject:To:References:From:Cc: In-Reply-To:Content-Type; b=LYTNqSPmHkvCLSTeXB/7v0Xk1nOHbYNlbHwTxx4LtpHqXvxUVTtvB2ovvhmONdMjawyFSh5jigh2+YwZNLT+QIDiwhMdqzmB9USP7gwaFifwP3Cm0DsRHWUOajm9FwdAKSWNZgtm4R9YiYxQNQjUbjGa+xdPE1QHFg68o60N1/E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HHO8FfEr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HHO8FfEr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 357EAC4CEEB; Fri, 15 Aug 2025 10:39:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755254398; bh=o0qy4hIYEUwnQ5tOAtQG6KodJsJjY/1AFrWA8nZR51E=; h=Date:Subject:To:References:From:Cc:In-Reply-To:From; b=HHO8FfErchxsjv6CiH9E+64CiHsWQKpYtQ9CP0SXYVM41xXxPQ3iStFJFH1WyX8M5 Dbh8EiV1/AZYzlM1pVolt32QEaDUycOmIVEN2EdFsBlYnja0JMFyr0rTopF4gHN7QA FjHlBHENToZPCQ7UYDIxmSO7GXttKsGS2XkLas9uI7A9Tr6mgjLPiPiea0XyFPzkT9 1VIRXuvQjqg832865dSiN+UOD8Ti/T918xV/uOdboPmULzZVXzPyc9wGQU5qZMWO0h lWbGgYPgrOjBF2vnRADoRzPPpAz5Gp3PjWmCmmly4kQwIrcIfaDGJv5WXr47Q3Y2EB JFdDmQENmukog== Message-ID: Date: Fri, 15 Aug 2025 12:39:55 +0200 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH mptcp-next v3] selftests: net: mptcp: add checks for fallback counters Content-Language: en-GB, fr-BE To: GangYan References: <20250815073140.29077-1-yangang@kylinos.cn> <62e44bb3-957d-4676-95ec-2ceedba2e9c1@kernel.org> From: Matthieu Baerts Cc: MPTCP Linux Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Gang, On 15/08/2025 11:13, GangYan wrote: >> On Fri, Aug 15, 2025 at 10:24:18AM +0200, Matthieu Baerts wrote: >> 15 Aug 2025 09:32:11 Gang Yan : >> >>> Recently, some mib counters about fallback has been added, this patch >>> provides a method to check the expected behavior of these mib counters >>> during the test execution. >>> >>> Link: https://github.com/multipath-tcp/mptcp_net-next/issues/571 >>> Signed-off-by: Gang Yan (...) >>> diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh >>> index b8af65373b3a..898779a9af58 100755 >>> --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh >>> +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh (...) >>> +chk_fallback_nr_all() >>> +{ >>> +   local netns=("ns1" "ns2") >>> +   local fb_ns=("fb_ns1" "fb_ns2") >>> +   local rc=${KSFT_PASS} >>> + >>> +   for i in 0 1; do I forgot to add: 'i' should be declared as 'local' as well. >>> +       if [ -n "${!fb_ns[i]}" ]; then >>> +           eval "${!fb_ns[i]}" \ >>> +               chk_fallback_nr ${netns[i]} || rc={?} >>> +       else >>> +           chk_fallback_nr ${netns[i]} || rc={?} > CI has reported some errors in 'rc={?}' I guess the issue is with ${netns[i]}: is it not enough to add double quotes around it? chk_fallback_nr "${netns[i]}" || rc={?} or explicitly use the variable $i? chk_fallback_nr "${netns[$i]}" || rc={?} (same above) > I'll fix this in the next version OK, I will wait for the next version. Cheers, Matt -- Sponsored by the NGI0 Core fund.