From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Gang Ba <gaba-5C7GfCeVMHo@public.gmane.org>,
"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Cc: "Ba, Gang" <Gang.Ba-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH] drm/amd/amdgpu: Modify sdma instance number
Date: Wed, 21 Aug 2019 16:35:35 +0200 [thread overview]
Message-ID: <c96fd6ee-eafa-95ab-bdbe-16bbf807f93c@gmail.com> (raw)
In-Reply-To: <1566397966-4357-1-git-send-email-gaba-5C7GfCeVMHo@public.gmane.org>
Am 21.08.19 um 16:32 schrieb Gang Ba:
> To upgrade performance in small bar mode, set sdma buffer function
> ring and pte function ring to use different instance.
NAK, we intentionally reserved the first paging queue here.
I wanted to revert that as well, but in this case you would need to
revert the whole patch and not just this change.
Just look for the patch adding that line and completely revert it instead.
Regards,
Christian.
>
> Change-Id: Ida6377914eb68a188f745e63409f344f0ce1a8c4
> Signed-off-by: Gang Ba <gaba@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> index 071d6c9..5aca9bb4a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> @@ -2500,7 +2500,7 @@ static void sdma_v4_0_set_buffer_funcs(struct amdgpu_device *adev)
> {
> adev->mman.buffer_funcs = &sdma_v4_0_buffer_funcs;
> if (adev->sdma.has_page_queue && adev->sdma.num_instances > 1)
> - adev->mman.buffer_funcs_ring = &adev->sdma.instance[1].page;
> + adev->mman.buffer_funcs_ring = &adev->sdma.instance[0].page;
> else
> adev->mman.buffer_funcs_ring = &adev->sdma.instance[0].ring;
> }
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2019-08-21 14:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 14:32 [PATCH] drm/amd/amdgpu: Modify sdma instance number Gang Ba
[not found] ` <1566397966-4357-1-git-send-email-gaba-5C7GfCeVMHo@public.gmane.org>
2019-08-21 14:35 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c96fd6ee-eafa-95ab-bdbe-16bbf807f93c@gmail.com \
--to=ckoenig.leichtzumerken-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=Gang.Ba-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
--cc=gaba-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.