From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0527BCDB474 for ; Thu, 12 Oct 2023 23:34:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id C4650C433CA; Thu, 12 Oct 2023 23:34:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92540C433C7; Thu, 12 Oct 2023 23:34:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697153656; bh=2hOV/A99q7Vw2ihfrRngmpOQSr3R2rMB6q/KtChtdlQ=; h=In-Reply-To:References:Subject:From:List-Id:Cc:To:Date:From; b=larpwYHwnfF14OohEdapHA//IHTxle4bwtbkVzm+Uv9W89nmUV9cZxDKb/k1gKxqW yfiRMP0zowW2HUFKSiqvLmqDd1QNyNBrnmvOmuy7QHonQDeOutX6zydQ7z1OxEd+Ko fYflCwCix/Bu/hX3PVdnByDzmL2HMRqCMLvlVj65elPs6HqPFWjePx9tNGVPzptPoi w+FCeSFtlkGYmEZJv3fMiZ+CLHh+J8fUTnfwlan9R2TfBMDc0F/HzDdZ0+k7OB6xoH rceaN+CLTEt0avfItppsYaLzdoGwOCs1TlWwJS+OCg6EATRRJ/yBSjcSRlt4th6Vtp Is0hG1yVLiP0w== Message-ID: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20231011184823.443959-3-peter.griffin@linaro.org> References: <20231011184823.443959-1-peter.griffin@linaro.org> <20231011184823.443959-3-peter.griffin@linaro.org> Subject: Re: [PATCH v3 02/20] dt-bindings: clock: Add Google gs101 clock management unit bindings From: Stephen Boyd List-Id: Cc: peter.griffin@linaro.org, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, saravanak@google.com, willmcvicker@google.com, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org To: Peter Griffin , arnd@arndb.de, catalin.marinas@arm.com, conor+dt@kernel.org, cw00.choi@samsung.com, gregkh@linuxfoundation.org, krzysztof.kozlowski+dt@linaro.org, linus.walleij@linaro.org, linux@roeck-us.net, mturquette@baylibre.com, olof@lixom.net, robh+dt@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com, will@kernel.org, wim@linux-watchdog.org Date: Thu, 12 Oct 2023 16:34:14 -0700 User-Agent: alot/0.10 Quoting Peter Griffin (2023-10-11 11:48:05) > diff --git a/Documentation/devicetree/bindings/clock/google,gs101-clock.y= aml b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml > new file mode 100644 > index 000000000000..f74494594b3b > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml > @@ -0,0 +1,125 @@ [...] > +properties: > + compatible: > + enum: > + - google,gs101-cmu-top > + - google,gs101-cmu-apm > + - google,gs101-cmu-misc > + > + clocks: > + minItems: 1 > + maxItems: 2 > + > + clock-names: > + minItems: 1 > + maxItems: 2 Can you remove clock-names from the binding and simply use the index of the clocks property? That means less string comparisons in the kernel. I'm not sure if other samsung clk drivers are doing this though so maybe clock-names is preferred for historical reasons. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1754CDB47E for ; Thu, 12 Oct 2023 23:34:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9T0El7imqVWhqAI3i082N+doYzGu2Av1B6tlvSyzR48=; b=pJsAKqvA4FpsG9 sU6jrCfyB013aBJOK5D6ruuVG5mhS5CQj9QpZlNI0JmfTFa8+juC0CkllvMHSSh1B3l0sz6UHIdqC Q12lE3xTFrkKiJy7G1Pu79q1GXGpGZB+NWsMD82dCE//pSb6ajcbs8Chbsqu226bKRTv+epTrw0I/ pSzXrGhl2NC9eACQkHmF70dKpFzWzGysFzPqaQCsexaTVgPg4ZzvBTEnfXqnwHhQRCOxQK25h/CXd UTY8jpx1qAJvQ11Xj5FRl6HPhPr8XEn9sUTc3ResQTtY1b58zBNJUOLs+4jfPRsmxn5WR/dxOTlw7 XG3CT0IvZJ/VtjNWJBPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qr5CA-0027R3-1o; Thu, 12 Oct 2023 23:34:22 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qr5C8-0027Q7-1V for linux-arm-kernel@lists.infradead.org; Thu, 12 Oct 2023 23:34:21 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0ABDA61F64; Thu, 12 Oct 2023 23:34:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92540C433C7; Thu, 12 Oct 2023 23:34:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697153656; bh=2hOV/A99q7Vw2ihfrRngmpOQSr3R2rMB6q/KtChtdlQ=; h=In-Reply-To:References:Subject:From:List-Id:Cc:To:Date:From; b=larpwYHwnfF14OohEdapHA//IHTxle4bwtbkVzm+Uv9W89nmUV9cZxDKb/k1gKxqW yfiRMP0zowW2HUFKSiqvLmqDd1QNyNBrnmvOmuy7QHonQDeOutX6zydQ7z1OxEd+Ko fYflCwCix/Bu/hX3PVdnByDzmL2HMRqCMLvlVj65elPs6HqPFWjePx9tNGVPzptPoi w+FCeSFtlkGYmEZJv3fMiZ+CLHh+J8fUTnfwlan9R2TfBMDc0F/HzDdZ0+k7OB6xoH rceaN+CLTEt0avfItppsYaLzdoGwOCs1TlWwJS+OCg6EATRRJ/yBSjcSRlt4th6Vtp Is0hG1yVLiP0w== Message-ID: MIME-Version: 1.0 In-Reply-To: <20231011184823.443959-3-peter.griffin@linaro.org> References: <20231011184823.443959-1-peter.griffin@linaro.org> <20231011184823.443959-3-peter.griffin@linaro.org> Subject: Re: [PATCH v3 02/20] dt-bindings: clock: Add Google gs101 clock management unit bindings From: Stephen Boyd Cc: peter.griffin@linaro.org, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, saravanak@google.com, willmcvicker@google.com, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org To: Peter Griffin , arnd@arndb.de, catalin.marinas@arm.com, conor+dt@kernel.org, cw00.choi@samsung.com, gregkh@linuxfoundation.org, krzysztof.kozlowski+dt@linaro.org, linus.walleij@linaro.org, linux@roeck-us.net, mturquette@baylibre.com, olof@lixom.net, robh+dt@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com, will@kernel.org, wim@linux-watchdog.org Date: Thu, 12 Oct 2023 16:34:14 -0700 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231012_163420_566051_8796EB9B X-CRM114-Status: UNSURE ( 9.93 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Peter Griffin (2023-10-11 11:48:05) > diff --git a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml > new file mode 100644 > index 000000000000..f74494594b3b > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml > @@ -0,0 +1,125 @@ [...] > +properties: > + compatible: > + enum: > + - google,gs101-cmu-top > + - google,gs101-cmu-apm > + - google,gs101-cmu-misc > + > + clocks: > + minItems: 1 > + maxItems: 2 > + > + clock-names: > + minItems: 1 > + maxItems: 2 Can you remove clock-names from the binding and simply use the index of the clocks property? That means less string comparisons in the kernel. I'm not sure if other samsung clk drivers are doing this though so maybe clock-names is preferred for historical reasons. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel