From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 652C26A8CA; Thu, 18 Apr 2024 13:52:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713448356; cv=none; b=ZKjOrqTuJE/EF5vU2s7jauO22adZTTuNkzOviX7mgjlL7eXpUSWhAmth2wdN77XYEhWcOr+rBJr8j6Pckr0lc/qaqWrkxxW+mhTFeyCc1pIambwZoWf+U4jdIfDwHirru5c5D+gaTsQl0QIJ7xXHBqLIkwFdlGaz3zma6i0ST/U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713448356; c=relaxed/simple; bh=DFMBpvLg9bEM08JQ9ob6upTO1i+WiZqw2n6cDonSo4w=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=hkLPK5vSU7Qq1oCMXrswgANtXkRoEOkivWE8HPXRsi8HmUIENYbZi/bAkLl+XpSaD9NKBGffq3D9MXtSnB707scAflPYNu8JMHnNsAncAttM2XpQ5VrCdaN97XoLuq2DqfnQihtwFjdVbGTR+Yqit+dLkiTuxM8LXs7nX/l8D+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=RmxsbDgx; arc=none smtp.client-ip=217.70.183.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="RmxsbDgx" Received: by mail.gandi.net (Postfix) with ESMTPSA id C2C281BF209; Thu, 18 Apr 2024 13:52:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1713448351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8wUOi164P3lAmjE1ClSdezuP19LGck9A7BJ4c8R2rWo=; b=RmxsbDgxhNpNQOPoFlayXDpwdP+tytqkGF2OJI6z52D3jvdH0BINaMaSOJABYa6/o6WxeC ghog+bvm/6xdvqTf7B+xQM1u8PJB3QGicA2yN5ueeF17yS8iO+LMOt3yX/95A/69vx0wFU cWHL5OJ6Vcw7APt18HuFE96l5gziHKoup8zj+aF3KookZJxRSzPjCOjoJAU1e0WxFzVysT v/WQR3MUr8UJwvigXjjQu2WXU9bhHEg4YS9NtOcNTo94oqfGuwGimoaaP5yb6TJK1bx/Ff aiZo6SsBfRs+qKWkz/kuZH1VCi7XUvW5NuGt7bGVzPZKfEQBmV9RD8UVbJaq/w== Date: Thu, 18 Apr 2024 15:53:07 +0200 (CEST) From: Romain Gantois To: Serge Semin cc: Romain Gantois , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Russell King , =?ISO-8859-15?Q?Cl=E9ment_L=E9ger?= , Thomas Petazzoni , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v3 4/5] net: stmmac: add support for RZ/N1 GMAC In-Reply-To: Message-ID: References: <20240415-rzn1-gmac1-v3-0-ab12f2c4401d@bootlin.com> <20240415-rzn1-gmac1-v3-4-ab12f2c4401d@bootlin.com> <232e3b0c-ca55-2da0-1c9f-47520a1bcfbd@bootlin.com> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-GND-Sasl: romain.gantois@bootlin.com On Thu, 18 Apr 2024, Serge Semin wrote: > On Thu, Apr 18, 2024 at 01:57:47PM +0200, Romain Gantois wrote: > > Hi Serge, > > > > On Tue, 16 Apr 2024, Serge Semin wrote: > > > > > > +static int rzn1_dwmac_pcs_init(struct stmmac_priv *priv, > > > > > > > + struct mac_device_info *hw) > > > > > > AFAICS hw is unused, and the mac_device_info instance is reached via > > > the priv pointer. What about dropping the unused argument then? > > > > > Unfortunately, this is an implementation of the pcs_init() callback, which is > > also used by socfpga (see patch 4/6 in this series). The socfpga implementations > > use the hw parameter for both pcs_init() and pcs_exit() so I can't remove it. > > I had that patch content in mind when was writing my comment. There is > no point in passing the hw-pointer there either because you already > have the stmmac_priv pointer. There is stmmac_priv::hw field which you > can use instead in the same way as you do in this patch. Here is the > respective change for your SoCFPGA patch: > You're right, I'll remove the parameter. Thanks, -- Romain Gantois, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAE25C04FF8 for ; Thu, 18 Apr 2024 13:52:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KlzlsepWzoF5Al09UvauzFiu8iWha/FzzKykM/Fd6Q0=; b=1nRil8fLYBWgl6 DPr0z6Hj+ImL7ZR3/JrVyLQznr6BJj4xSNjlVrht5TWGJLgsxyvCvGuJ6u1bF6Gpj59vGJDPRn+7d KyvlspZZhgvi4AVP//RA3nVL53VAgFVohHuCcnT4C0cV0qlxSelQTxWBtSv+f2KHPYNTD9OvK05jN wGMYkOvJTb3s0Lqe29V24POfHk1oWZ3zMViZKDTJKNOY4vgyDFoYKo6TdoPWFr9jncVxy/q1Ya3cA PQOcbmkom0SLmfV3zSY2pnclFB6eDjMN1fQLD41k1sIps9VU6JWQhbH51B/teVbQ+NZ3++PJPZgHu htF2V/LXbo6+QG7+uybA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxSBq-00000002Rih-3bSw; Thu, 18 Apr 2024 13:52:38 +0000 Received: from relay8-d.mail.gandi.net ([2001:4b98:dc4:8::228]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxSBo-00000002Ri7-0XJo for linux-arm-kernel@lists.infradead.org; Thu, 18 Apr 2024 13:52:38 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id C2C281BF209; Thu, 18 Apr 2024 13:52:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1713448351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8wUOi164P3lAmjE1ClSdezuP19LGck9A7BJ4c8R2rWo=; b=RmxsbDgxhNpNQOPoFlayXDpwdP+tytqkGF2OJI6z52D3jvdH0BINaMaSOJABYa6/o6WxeC ghog+bvm/6xdvqTf7B+xQM1u8PJB3QGicA2yN5ueeF17yS8iO+LMOt3yX/95A/69vx0wFU cWHL5OJ6Vcw7APt18HuFE96l5gziHKoup8zj+aF3KookZJxRSzPjCOjoJAU1e0WxFzVysT v/WQR3MUr8UJwvigXjjQu2WXU9bhHEg4YS9NtOcNTo94oqfGuwGimoaaP5yb6TJK1bx/Ff aiZo6SsBfRs+qKWkz/kuZH1VCi7XUvW5NuGt7bGVzPZKfEQBmV9RD8UVbJaq/w== Date: Thu, 18 Apr 2024 15:53:07 +0200 (CEST) From: Romain Gantois To: Serge Semin cc: Romain Gantois , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Russell King , =?ISO-8859-15?Q?Cl=E9ment_L=E9ger?= , Thomas Petazzoni , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v3 4/5] net: stmmac: add support for RZ/N1 GMAC In-Reply-To: Message-ID: References: <20240415-rzn1-gmac1-v3-0-ab12f2c4401d@bootlin.com> <20240415-rzn1-gmac1-v3-4-ab12f2c4401d@bootlin.com> <232e3b0c-ca55-2da0-1c9f-47520a1bcfbd@bootlin.com> MIME-Version: 1.0 X-GND-Sasl: romain.gantois@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240418_065236_482921_6632B68F X-CRM114-Status: GOOD ( 17.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 18 Apr 2024, Serge Semin wrote: > On Thu, Apr 18, 2024 at 01:57:47PM +0200, Romain Gantois wrote: > > Hi Serge, > > > > On Tue, 16 Apr 2024, Serge Semin wrote: > > > > > > +static int rzn1_dwmac_pcs_init(struct stmmac_priv *priv, > > > > > > > + struct mac_device_info *hw) > > > > > > AFAICS hw is unused, and the mac_device_info instance is reached via > > > the priv pointer. What about dropping the unused argument then? > > > > > Unfortunately, this is an implementation of the pcs_init() callback, which is > > also used by socfpga (see patch 4/6 in this series). The socfpga implementations > > use the hw parameter for both pcs_init() and pcs_exit() so I can't remove it. > > I had that patch content in mind when was writing my comment. There is > no point in passing the hw-pointer there either because you already > have the stmmac_priv pointer. There is stmmac_priv::hw field which you > can use instead in the same way as you do in this patch. Here is the > respective change for your SoCFPGA patch: > You're right, I'll remove the parameter. Thanks, -- Romain Gantois, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel